View Issue Details

IDProjectCategoryView StatusLast Update
0000756FSSCPtablespublic2006-01-28 20:37
ReporterWanderer Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionopen 
Summary0000756: PBank Capacity defaults to 1
DescriptionIf ship has ballistic primaries enabled then game defaults the $PBank Capacity: to 1 for all banks. Or atleast that is what in the debug builds error report says. Also it does that even if the capacity is already set to 1.

At least in CVS builds from 27/01/06 to 08/01/06
Additional InformationError:
Warning: Pbank capacity not specified for ballistic-primary-enabled ship GVF Serapis.
Defaulting to capacity of 1 per bank.

File:c:\fs2_open\code\ship\ship.cpp
Line: 3229
[This filename points to the location of a file on the computer that built this executable]

Call stack:
------------------------------------------------------------------
    fs2_open_d-20060127.exe 007f6598()
    fs2_open_d-20060127.exe 00a3529e()
    fs2_open_d-20060127.exe 007f6a19()
    fs2_open_d-20060127.exe 006d3973()
    fs2_open_d-20060127.exe 006e02e9()
    fs2_open_d-20060127.exe 006e0619()
    fs2_open_d-20060127.exe 00b56477()
    kernel32.dll 7c816d4f()
------------------------------------------------------------------

With following line in ships.tbl:
$PBank Capacity: ( 1, 1 )
TagsNo tags attached.

Activities

Wanderer

2006-01-28 14:04

developer   ~0004528

I think the problem is right after this entry in ship.cpp:
if (pbank_capacity_specified)

As it does seem to reset pbank capacity to 1 if ship has ballistic primaries and to 0 otherwise. So that pbank capacity entry in ships.tbl is currently meaningless

Goober5000

2006-01-28 20:37

administrator   ~0004532

This is not the case. If the $PBank Capacity line is found, the pbank capacity is read properly for each bank in the ship. The only time the capacity is reset to 1 is if it was not specified or was incorrectly specified.

Setting capacity to 1 by default is the designed behavior. This is because the capacity corresponds to how many "magazines" it can carry. Typically each weapon has X number of bullets in a magazine, which must be constant across all ship classes.

Closing as not-a-bug.

Issue History

Date Modified Username Field Change
2006-01-28 13:59 Wanderer New Issue
2006-01-28 14:04 Wanderer Note Added: 0004528
2006-01-28 20:37 Goober5000 Status new => closed
2006-01-28 20:37 Goober5000 Note Added: 0004532