View Issue Details

IDProjectCategoryView StatusLast Update
0000746FSSCPdockingpublic2006-01-28 03:45
ReporterStratComm Assigned ToGoober5000  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000746: Initially docked ships in a wing cause docking group leaders to not be found
DescriptionWhen a ship is initially docked to something and also in a wing, the docking code cannot find the docking leader and so none of the ships show up (if the mission runs at all). I've traced the problem, more or less, to the arrival cues; for the ships in question the arrival cues are false for both docker and dockee but true for the docker wing. The example mission is from the first mission of the new Derelict SCP. The problem ships are Ore Carrier 1, 2, and 3 (wing "Ore Carrier") docked with three TC-TRI containers. On load in debug, the following error message pops up:

Warning: No dock leaders found in the docking group containing Ore Carrier 1. The group will not appear in-mission!

File:c:\fs2_open\code\mission\missionparse.cpp
Line: 5457
[This filename points to the location of a file on the computer that built this executable]

Call stack:
------------------------------------------------------------------
    fs2_open_d-20060116.exe 006e48a9()
    fs2_open_d-20060116.exe 006e9131()
    fs2_open_d-20060116.exe 006ea442()
    fs2_open_d-20060116.exe 008aba8f()
    fs2_open_d-20060116.exe 006c881b()
    fs2_open_d-20060116.exe 006d5c3d()
    fs2_open_d-20060116.exe 0088675d()
    fs2_open_d-20060116.exe 006d465c()
    fs2_open_d-20060116.exe 00886d7c()
    fs2_open_d-20060116.exe 006d7cd5()
    fs2_open_d-20060116.exe 006d7f59()
    fs2_open_d-20060116.exe 00b3ffb7()
    kernel32.dll 7c816d4f()
------------------------------------------------------------------

Presumably, the code searching for the dock leader looks for the ship with the true arrival cue and uses that, and it can't find it in this case as the true cue is in the wing rather than any of the ships. Hasn't always been a problem, though, so I'm guessing there is some nastiness in the multidocking code that's cropped up recently. I've attached the broken mission and a fixed version, where the Ore Carrier wing is commented out and the arrival cues of the three freighters set to true.
Additional InformationWith the release of Derelict SCP, this has appeared with recent builds only. Specifically, I've verified it in 1-9-06 and 1-16-06. RandomTiger's voice recognition build does not behave the same way, and so it's been the build of choice for playing this particular mission. I'm not sure how old that branch of code is, though it supports post-3.6.7 modular table formats.

FRED hates this docked-ship/wing combination too, but that's a different animal I'm sure.
TagsNo tags attached.

Activities

2006-01-25 01:08

 

dl1-01-carrier-wing.fs2 (57,613 bytes)

2006-01-25 01:09

 

dl1-01-no-wing.fs2 (57,624 bytes)

Goober5000

2006-01-28 03:45

administrator   ~0004515

Fixed.

Issue History

Date Modified Username Field Change
2006-01-25 01:08 StratComm New Issue
2006-01-25 01:08 StratComm File Added: dl1-01-carrier-wing.fs2
2006-01-25 01:09 StratComm File Added: dl1-01-no-wing.fs2
2006-01-25 03:30 Goober5000 Status new => assigned
2006-01-25 03:30 Goober5000 Assigned To => Goober5000
2006-01-28 03:45 Goober5000 Note Added: 0004515
2006-01-28 03:45 Goober5000 Status assigned => resolved
2006-01-28 03:45 Goober5000 Resolution open => fixed