View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000663 | FSSCP | graphics | public | 2005-12-29 09:00 | 2005-12-29 20:29 |
| Reporter | Alpha0 | Assigned To | taylor | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Dell Latitude D600 Notebook | OS | Windows 2000 Professional | OS Version | 5.00.2195 SP4 |
| Product Version | 3.6.7 | ||||
| Summary | 0000663: Lighting on ship insignias does not work on D3D. | ||||
| Description | Taylor recently implemented lighting on ship insignias, so that they do not appear unnaturally bright. However, it seems that the implementation works only with OpenGL, while D3D rendering of insignias looks unchanged compared to what it was in the past. | ||||
| Steps To Reproduce | Just load any mission in D3D and you will notice immediately that ship insignias appear fully lit. | ||||
| Additional Information | Test system: Dell Latitude D600 Notebook, Intel Centrino 1.6GHz, 512MB RAM, Windows 2000 Professional SP4, Mobility Radeon 9000 w/ 32MB for graphics, graphics drivers version 6.13.10.6279. DX version 8.1 (4.08.01.0881). I tested this with the CVS build of December 22. | ||||
| Tags | No tags attached. | ||||
|
|
I don't really have a good D3D to test this with since what I do have has really crappy lighting. The change I made isn't API specific but I would guess that D3D just isn't testing/using the RGB render flag like it should. If it doesn't then the lighting related color values won't get used. ... Mmm, add TMAP_FLAG_GOURAUD to modelinterp.cpp line 2831 (tmap_flags |= TMAP_FLAG_RGB) and see if that makes it work. This looks to just be a problem with OpenGL actually, it should have the extra check and it doesn't. If adding that flag makes it work in D3D let me know and I'll go ahead and commit the change. |
|
|
Taylor, I tested your proposed fix and indeed it does work. I believe it is OK to commit your change. |
|
|
Fixered. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-12-29 09:00 | Alpha0 | New Issue | |
| 2005-12-29 11:08 | taylor | Note Added: 0004069 | |
| 2005-12-29 11:08 | taylor | Status | new => assigned |
| 2005-12-29 11:08 | taylor | Assigned To | => taylor |
| 2005-12-29 15:10 | Alpha0 | Note Added: 0004070 | |
| 2005-12-29 20:29 | taylor | Status | assigned => resolved |
| 2005-12-29 20:29 | taylor | Resolution | open => fixed |
| 2005-12-29 20:29 | taylor | Note Added: 0004072 |
