View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000065 | FSSCP | FRED | public | 2004-01-16 11:03 | 2005-03-01 23:23 |
| Reporter | kasperl | Assigned To | taylor | ||
| Priority | normal | Severity | minor | Reproducibility | random |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000065: CTD with babylon model "olympus", using FSO 3.5.0 and up | ||||
| Description | In versions 3_5_0 and above the babylon project model "olympus" will not successfully load at any point (tech room, fred2, or ingame) Other team members have a similar problem so I'm sure it is SCP related, also I do not believe it is tbl related. Some feature which was added between v3.4 and v3.5.0 is causing this and has not been rectified in any version since. you can send me exe's to test with various source modifications disabled to: ken.sue@btinternet.com I will check for you to try and further pin point the problem if you like This crash simply drops you back to desktop without an error report - cptwhite | ||||
| Additional Information | Reporter: ken.sue@btinternet.com (Matthew White) Assigned To: fs2source@warpcore.org (Edward Gardner) http://fs2source.warpcore.org/bugzilla/show_bug.cgi?id=72 | ||||
| Tags | No tags attached. | ||||
|
|
CptWhite, do you get this with the 01_20_2004 exe? (I have emailed him with a link here.) edited on: 01-26-04 17:25 |
|
|
This bug seems to be fixed. Note to self: Find out where the long file name problem is (http://dynamic4.gamespy.com/~freespace/forums/showthread.php?s=&threadid=20459) and add some error-checking. I'll close the bug after this is done. |
|
|
This is down to texture names being too long. I tryed really hard to lock this down with an error message but failed. This is bad news since the CTD has no message indicating the problem. |
|
|
I thought this had a working error mesage, it's in the low level file loading code |
|
|
Your check caused other problems. I know because I commented it back in after Goober commented it out. |
|
|
what other problems, and can we close this bug, seeing as it's been basicly resolved |
|
|
Can someone upload the old Olympus model that caused the crash? Just the model, and the single table entry, and I'll merge it with vanilla FS2 data and take a look. |
|
2004-03-21 20:58
|
|
|
|
I only experienced this problem in release which made it difficult to track |
|
|
was an issue with texture name length causing the -shine, etc to walk off the end of their string buffers |
|
|
gah - Kazan, I wanted to take a look at this... see where the problem was, add some friendly messages to trap errors. If we don't watch out for this in the code, someone else with long texture names is going to have the exact same problem. |
|
|
bobboau knows exactly where this resides |
|
|
Okay, I want to squash this. I need: 1) The buggy model 2) The buggy table file 3) The buggy maps It looks like I only have one of the three. Could someone be so kind as to attach the requisite resources? |
|
|
Download the B5 second release without patch |
|
|
K. |
|
|
Well, since no one else did it, I fixed this. Changed model_load_texture() to restrict the length of tmp_name to MAX_FILENAME_LEN since it doesn't help to have it longer and used the 'n' variants of string function (strncpy(), etc.) to avoid going over. I also changed bm_load() and bm_load_animation() to use the same 'n' variants and added an Error() when it goes over MAX_FILENAME_LEN-5. It's -5 to cover the extension and NULL terminator. I'll leave this open until I can commit the changes later tonight or tomorrow. |
|
|
Whoa. Thanks, taylor. :) This was very deep on my to-do stack. ;) |
|
|
Fixered. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2004-01-16 11:03 | kasperl | New Issue | |
| 2004-01-26 22:21 | Goober5000 | Note Added: 0000122 | |
| 2004-01-26 22:25 | Goober5000 | Note Edited: 0000122 | |
| 2004-01-29 21:39 | Goober5000 | Note Added: 0000132 | |
| 2004-01-29 21:39 | Goober5000 | Assigned To | => Goober5000 |
| 2004-01-29 21:39 | Goober5000 | Status | new => assigned |
| 2004-02-20 22:21 | RandomTiger | Note Added: 0000218 | |
| 2004-02-23 00:15 | Bobboau | Note Added: 0000231 | |
| 2004-02-23 09:04 | RandomTiger | Note Added: 0000237 | |
| 2004-03-09 08:36 | Rga_Noris | Summary | CTD with certain models, also in FSO => CTD with babylon model "olympus", using FSO 3.5.0 and up |
| 2004-03-10 05:46 | Bobboau | Note Added: 0000412 | |
| 2004-03-21 20:34 | Goober5000 | Note Added: 0000515 | |
| 2004-03-21 20:58 | RandomTiger | File Added: olympus.pof | |
| 2004-03-21 20:59 | RandomTiger | Note Added: 0000517 | |
| 2004-04-03 15:20 | Kazan | Status | assigned => resolved |
| 2004-04-03 15:20 | Kazan | Resolution | open => fixed |
| 2004-04-03 15:20 | Kazan | Assigned To | Goober5000 => Kazan |
| 2004-04-03 15:20 | Kazan | Note Added: 0000657 | |
| 2004-04-03 21:42 | Goober5000 | Status | resolved => feedback |
| 2004-04-03 21:42 | Goober5000 | Resolution | fixed => reopened |
| 2004-04-03 21:42 | Goober5000 | Note Added: 0000669 | |
| 2004-04-03 21:42 | Goober5000 | Assigned To | Kazan => Goober5000 |
| 2004-04-03 21:42 | Goober5000 | Status | feedback => assigned |
| 2004-04-03 22:06 | Kazan | Note Added: 0000672 | |
| 2004-05-10 04:54 | Goober5000 | Note Added: 0000920 | |
| 2004-05-10 06:31 | RandomTiger | Note Added: 0000922 | |
| 2004-05-10 10:50 | Goober5000 | Note Added: 0000925 | |
| 2005-03-01 03:28 | taylor | Note Added: 0001709 | |
| 2005-03-01 03:28 | taylor | Assigned To | Goober5000 => taylor |
| 2005-03-01 04:43 | Goober5000 | Note Added: 0001710 | |
| 2005-03-01 23:23 | taylor | Status | assigned => resolved |
| 2005-03-01 23:23 | taylor | Resolution | reopened => fixed |
| 2005-03-01 23:23 | taylor | Note Added: 0001718 |
