View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000509 | FSSCP | tables | public | 2005-08-17 23:17 | 2005-08-18 12:53 |
| Reporter | Kazan | Assigned To | taylor | ||
| Priority | immediate | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Wintel | OS | Windows | OS Version | XP |
| Product Version | 3.6.5 | ||||
| Summary | 0000509: Player-file tech room settings zero out all ships techroom flag - causes crash | ||||
| Description | Taylor's new pilot code zeros out all ships techroom flags when you are playing a mod campaign - this happened on a cloned pilot. It causes an IMMEDIATE crash that cannot be mitigated. Just tested on a new pilot - doesn't happen on new pilots. Just tested changing to default campaign, then to mod campaign - does not solve crash. | ||||
| Steps To Reproduce | Create a pilot and play the main campaign or the fsport campaign for one mission. Clone Pilot. Switch to wcsaga mod [probably happens with any other mod that replaces ships.tbl] on cloned pilot. Attempt to enter techroom | ||||
| Additional Information | error exists at lines 1557 through 1606 in missioncampaign.cpp - I assigned it to you taylor since it's your code and you know it so much better - I have placed a comment at the beginning of the code block | ||||
| Tags | No tags attached. | ||||
|
|
The actual zero out part shouldn't be causing a crash (if that's where you are seeing the problem) since it doesn't care about ships.tbl, or anything else mod or campaign specific for that matter. Where it fills in the proper values does have a problem if you are using a different ships.tbl since the name check screws up. This is a bug in my code since it doesn't do a -1 check before assigning the value. I had made a partial change for this at one point and a full change later which never hit CVS since it evolved into the new code. The new code doesn't use the same method of looking up entries for speed sake, sanity sake, and safety sake. Just so I understand the proceedure here (in case the above is wrong)... - Create a pilot and play at least one mission in a mod - clone the pilot - change to a different mod - enter techroom - crash If that's all then it's a known problem and already included in the pilot container bug entry. With the current code you have to change the active campaign first thing to whatever is available with the current ships.tbl. This is a slight design flaw in how I did the multi mod pilot files and how Volition had the code setup to now allow that. Rather than trying to fix this with more hacks the pilot code and campaign savefile code is being rewritten from scratch to properly handle multi-mods and dynamic limits plus have some error handling for user-related screwups. The new code saves a checksum of the current ships.tbl and weapons.tbl and will notify you of a possible problem if it differs from what was last used with that campaign. If the campaign is not currently available then it will take you right to the simroom rather than the mainhall and make you change the campaign before allowing you do to anything but exit. Pilot/mission/campaign state will be checked by a series of flags so that it will handle problems as best as possible rather than freaking out as it has a tendency to do now. |
|
|
you're on it like white on rice :D |
|
|
On which part? The -1 thing or the campaign switch thing? :) I'll to fix the -1 thing if that's it but most people never seem to hit it so it wasn't a priority. The other part is fixed by the new uber code so I'm just telling everyone to suck that one up until the new code is unleashed. EDIT: Oh and I want to add that the -1 check will prevent a crash but totally screw up your pilot files. The only way to get around it is to correct campaign switch that I mentioned. edited on: 08-17-05 20:03 |
|
|
i saw both the -1 thing and the campaign switch - but the campaign switch was causing the crash |
|
|
Ok. The -1 fix is going in now. It will keep you from crashing but won't help save the pilot file so it's not something that I'm going to call a fix. |
|
|
The -1 check is in place. The rest of the bug will be fixed by the new pilot code. Fixered. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-08-17 23:17 | Kazan | New Issue | |
| 2005-08-17 23:43 | taylor | Note Added: 0003012 | |
| 2005-08-17 23:53 | Kazan | Note Added: 0003013 | |
| 2005-08-17 23:58 | taylor | Note Added: 0003014 | |
| 2005-08-17 23:59 | taylor | Note Edited: 0003014 | |
| 2005-08-18 00:03 | taylor | Note Edited: 0003014 | |
| 2005-08-18 00:10 | Kazan | Note Added: 0003015 | |
| 2005-08-18 00:20 | taylor | Note Added: 0003016 | |
| 2005-08-18 12:53 | taylor | Status | assigned => resolved |
| 2005-08-18 12:53 | taylor | Resolution | open => fixed |
| 2005-08-18 12:53 | taylor | Note Added: 0003017 |
