View Issue Details

IDProjectCategoryView StatusLast Update
0000420FSSCPDirectXpublic2005-05-23 04:54
ReporterRansom Arceihn Assigned Totaylor  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000420: Training-msg displays only first line
DescriptionWhen it fires, for only a millisecond or so the full message is visible, but then is cropped to only the first line.
TagsNo tags attached.

Activities

2005-05-23 00:24

 

training-msg.fs2 (3,714 bytes)

2005-05-23 00:24

 

tmcompare.jpg (32,957 bytes)   
tmcompare.jpg (32,957 bytes)   

taylor

2005-05-23 02:34

administrator   ~0002454

I've already been sent a fix for this and it will go in later tonight. If it isn't fixed in the next available build then reopen this bug.

Goober5000

2005-05-23 02:34

administrator   ~0002455

This is probably my fault. Which build does this first appear in?

phreak

2005-05-23 02:52

developer   ~0002456

drat!. The day i release a test build, another bug is fixed :)

taylor

2005-05-23 04:09

administrator   ~0002459

Last edited: 2005-05-23 04:31

It is your fault Goober. ;)

It's because of the way Training_buf and Training_lines work together. When a change is made to Training_lines it makes that same change to Training_buf. That's why Training_text was there, to have a clean copy to reset the message. When it goes through the split lines it will put NULL at the end of the line. This ends up in Training _buf as well which is why it ends up showing only one line. It does show all of the lines the first frame but doesn't at any time later.

The basic fix I have is to spilt_str just the once in message_training_setup() but I really don't know if that breaks any variable replacement which is why I haven't put it in CVS yet. Simply going back to having Training_text there fixes it without breaking anything else but it is rather wasteful.

Moving the split_str() lines to message_training_setup() should also reduce some processing time on each frame if that's a valid fix for you. The variable replacement would still work, but only once, so it wouldn't ever be change *while* the message is displayed. I don't know if that's intended though and if it is then the Training_text fix should be used. It's the least problematic fix as I'm sitting here looking at it though. After testing it seems to work fine but if it's wrong then feel free to change it.

EDIT2: Yeah, I'm tired, just leave me alone ;) Simply moving split_str() does all that's needed. Gotta commit and then get to the bed before I fall over. :)

edited on: 05-23-05 00:15

edited on: 05-23-05 00:31

taylor

2005-05-23 04:54

administrator   ~0002460

Fixered... I hope.

Issue History

Date Modified Username Field Change
2005-05-23 00:24 Ransom Arceihn New Issue
2005-05-23 00:24 Ransom Arceihn File Added: training-msg.fs2
2005-05-23 00:24 Ransom Arceihn File Added: tmcompare.jpg
2005-05-23 02:33 taylor Status new => assigned
2005-05-23 02:33 taylor Assigned To => taylor
2005-05-23 02:34 taylor Note Added: 0002454
2005-05-23 02:34 Goober5000 Note Added: 0002455
2005-05-23 02:52 phreak Note Added: 0002456
2005-05-23 04:09 taylor Note Added: 0002459
2005-05-23 04:15 taylor Note Edited: 0002459
2005-05-23 04:31 taylor Note Edited: 0002459
2005-05-23 04:54 taylor Status assigned => resolved
2005-05-23 04:54 taylor Resolution open => fixed
2005-05-23 04:54 taylor Note Added: 0002460