View Issue Details

IDProjectCategoryView StatusLast Update
0000327FSSCPlauncherpublic2005-05-14 11:51
ReporterThe Grim Reaper Assigned Totaylor  
PrioritynormalSeveritytrivialReproducibilityalways
Status resolvedResolutionfixed 
Summary0000327: launcher fails to read registry if there are too many cmd switches
DescriptionIf there are alot of cmd switches and I select the registry tab in the launcher I get "An error has occured reading from the registry, cancelling".
If I close the launcher and re-open it, all options are deselected.
The actual writing of the options to the registry is unaffected.
This is the longest string that the launcher accepts without returning an error:
"-spec -glow -pcx32 -jpgtga -d3dmipmap -nomotiondebris -2d_poof -rlm -dualscanlines "
TagsNo tags attached.

Activities

taylor

2005-02-20 21:53

administrator   ~0001670

Never even noticed this one, and I use a long cmdline. I'm just not one to use the Resgistry tab I guess. :)

It's got a max length of 100 characters. When it goes over RegEnumValue() will return ERROR_MORE_DATA and that case isn't handled. It's not fatal, just means that it can't display the entire string and therefore terminates it to fit in the space allotted. Easy enough to fix but it doesn't really matter at this point.

We're moving away from the registry on Windows to an ini file like is used under Linux and OSX. This will even allow mod specific config options. This isn't going to be in use until after 3.6.6 though. But I'll go ahead and fix the current Launcher CVS and release it as 5.3 so that it can be used for 3.6.6 and older builds.

taylor

2005-03-14 00:47

administrator   ~0001869

Still haven't gotten this in even though it's been fixed for a while. I'd like to run it by RandomTiger before commit but then it will go in.

administrator

2005-03-14 01:36

administrator   ~0001877

commit then point RT to thse notes or re-assign to RT

kasperl

2005-04-04 17:21

developer   ~0002098

BUMP! One of you needs to resolve this....

taylor

2005-04-09 18:38

administrator   ~0002116

Eh, forgot about this. It will go in later today and then RT can fix it if he doesn't like it.

taylor

2005-05-14 11:51

administrator   ~0002395

This is fixed (in a better way) and will hit CVS later today. The only real holdup is unrelated Launcher changes that I have left to make and RT to release a new version.

Fixered.

Issue History

Date Modified Username Field Change
2005-02-20 19:46 The Grim Reaper New Issue
2005-02-20 21:53 taylor Note Added: 0001670
2005-02-20 21:53 taylor Status new => assigned
2005-02-20 21:53 taylor Assigned To => taylor
2005-03-14 00:47 taylor Note Added: 0001869
2005-03-14 01:36 administrator Note Added: 0001877
2005-04-04 17:21 kasperl Note Added: 0002098
2005-04-09 18:38 taylor Note Added: 0002116
2005-05-14 11:51 taylor Status assigned => resolved
2005-05-14 11:51 taylor Resolution open => fixed
2005-05-14 11:51 taylor Note Added: 0002395