View Issue Details

IDProjectCategoryView StatusLast Update
0003086FSSCPtablespublic2014-08-08 08:51
ReporterYarn Assigned ToYarn  
PriorityhighSeverityblockReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindows 7 
Product Version3.7.1 
Target Version3.7.2 
Summary0003086: Tstrings.tbl from German Dimension Pack and 2014 MediaVPs causes crash
DescriptionThe tstrings.tbl file from the Dimension Pack (the German version of the Sci-Fi Sim of the Year Edition) and 2014 MediaVPs includes a string in the German section that includes double quotes. Most likely due to the changes in revision 10894 (but not because of the comment system), that string is causing the game to throw an error at startup if the language is set to German.

The attached patch fixes this by replacing the double quotes in that string with single quotes.
Additional InformationIn case you're curious, this is the error that appears:

tstrings.tbl(line 18365):
Error: Expecting int, found [verbndet", so dass sie sich dem Konvoi ungehindert n„hern konn].

ntdll.dll! ZwWaitForSingleObject + 21 bytes
kernel32.dll! WaitForSingleObjectEx + 67 bytes
kernel32.dll! WaitForSingleObject + 18 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! SCP_DumpStack + 354 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! Error + 229 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! error_display + 369 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! atoi2 + 109 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! stuff_int + 35 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! parse_stringstbl_common + 347 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! parse_tstringstbl + 41 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! lcl_xstr_init + 257 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! game_init + 418 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! game_main + 519 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! WinMain + 328 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! __tmainCRTStartup + 296 bytes
fs2_open_3_7_1_SSE2-DEBUG.exe! WinMainCRTStartup + 13 bytes
kernel32.dll! BaseThreadInitThunk + 18 bytes
ntdll.dll! RtlInitializeExceptionChain + 99 bytes
ntdll.dll! RtlInitializeExceptionChain + 54 bytes
TagsNo tags attached.

Activities

Yarn

2014-08-07 02:31

developer  

mantis3086.patch (887 bytes)   
Index: code/parse/parselo.cpp
===================================================================
--- code/parse/parselo.cpp	(revision 10973)
+++ code/parse/parselo.cpp	(working copy)
@@ -2309,6 +2309,9 @@
 			} while (*ch);
 		} else if (!strcmp(outbuf, "1337, \"(fr)Loading\"\n")) {
 			outbuf[3] = '6';
+		} else if (!strcmp(outbuf, "3966, \"Es sieht so aus, als habe Staffel Kappa Zugriff auf die GTVA-Zugangscodes f\xFCr das System gehabt. Das ist ein ernstes Sicherheitsleck. Ihre IFF-Kennung erschien als \"verb\xFCndet\", so da\xDF sie sich dem Konvoi ungehindert n\xE4hern konnten. Zum Gl\xFC\x63k flogen Sie und  Alpha 2 Geleitschutz und lie\xDF\x65n den Schwindel auffliegen, bevor Kappa ihren Befehl ausf\xFChren konnte.\"\n")) {
+			outbuf[171] = '\'';
+			outbuf[181] = '\'';
 		}
 
 		strip_comments(outbuf, in_quote, in_multiline_comment_a, in_multiline_comment_b);
mantis3086.patch (887 bytes)   

niffiwan

2014-08-08 08:48

developer   ~0016187

looks good - committing shortly.

niffiwan

2014-08-08 08:51

developer   ~0016188

Fix committed to trunk@10977.

Related Changesets

fs2open: trunk r10977

2014-08-08 05:19

niffiwan


Ported: N/A

Details Diff
Fix mantis 3086 (from Yarn)

Add special case to avoid crash from mismatched quotes in
tstrings.tbl German text
Affected Issues
0003086
mod - /trunk/fs2_open/code/parse/parselo.cpp Diff File

Issue History

Date Modified Username Field Change
2014-08-07 02:03 Yarn New Issue
2014-08-07 02:03 Yarn Status new => assigned
2014-08-07 02:03 Yarn Assigned To => Yarn
2014-08-07 02:31 Yarn File Added: mantis3086.patch
2014-08-07 02:31 Yarn Status assigned => code review
2014-08-08 08:48 niffiwan Note Added: 0016187
2014-08-08 08:51 niffiwan Changeset attached => fs2open trunk r10977
2014-08-08 08:51 niffiwan Note Added: 0016188
2014-08-08 08:51 niffiwan Status code review => resolved
2014-08-08 08:51 niffiwan Resolution open => fixed