View Issue Details

IDProjectCategoryView StatusLast Update
0003074FSSCPFREDpublic2014-07-05 15:48
ReporterMjnMixael Assigned ToMageKing17  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
PlatformPCOSWindowsOS VersionWin7
Product Version3.7.2 RC3 
Target Version3.7.2 
Summary0003074: Fiction Viewer plus #Cutscene flags equals FRED crash
DescriptionSo.. if you have a mission with a Fiction Viewer stage and #Cutscene flags (which you have to add via text editor still)... Open that mission in FRED and save it and you'll get a crash.

It looks like the Fiction Viewer flags and the Cutscene flags are fighting over who gets to be listed first. Cutscene flags lose which invalidates the mission file. Cutscene flags have to be first.
Steps To ReproduceOpen the attached mission in a text editor and find #Cutscene. Note how it's listed before Fiction Viewer. This is correct.

Open the mission in FRED and save it. (You don't have to change anything at all.) FRED will crash after saving the file.

Open the mission again in a text editor and you'll see that Fiction Viewer and #Cutscene have been swapped.
TagsNo tags attached.

Activities

MjnMixael

2014-07-05 06:46

manager  

3074.fs2 (3,230 bytes)

MageKing17

2014-07-05 15:45

developer  

missionsave.cpp.patch (476 bytes)   
Index: code/fred2/missionsave.cpp
===================================================================
--- code/fred2/missionsave.cpp	(revision 10884)
+++ code/fred2/missionsave.cpp	(working copy)
@@ -133,10 +133,10 @@
 		err = -3;
 //	else if (save_briefing_info())
 //		err = -4;
+	else if (save_cutscenes())
+		err = -4;
 	else if (save_fiction())
 		err = -3;
-	else if (save_cutscenes())
-		err = -4;
 	else if (save_cmd_briefs())
 		err = -4;
 	else if (save_briefing())
missionsave.cpp.patch (476 bytes)   

MageKing17

2014-07-05 15:45

developer   ~0016025

Easily fixed by swapping the order in which those are saved.

The_E

2014-07-05 15:48

administrator   ~0016027

Patch committed to trunk in r10886

Issue History

Date Modified Username Field Change
2014-07-05 06:46 MjnMixael New Issue
2014-07-05 06:46 MjnMixael File Added: 3074.fs2
2014-07-05 15:45 MageKing17 File Added: missionsave.cpp.patch
2014-07-05 15:45 MageKing17 Assigned To => MageKing17
2014-07-05 15:45 MageKing17 Status new => code review
2014-07-05 15:45 MageKing17 Note Added: 0016025
2014-07-05 15:48 The_E Note Added: 0016027
2014-07-05 15:48 The_E Status code review => resolved
2014-07-05 15:48 The_E Resolution open => fixed