View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003010 | FSSCP | beams | public | 2014-02-18 19:59 | 2022-06-11 00:53 |
| Reporter | Joshua | Assigned To | MjnMixael | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | R10541 | OS | Windows | OS Version | 7 |
| Product Version | 3.7.1 | ||||
| Fixed in Version | 22.0.0 | ||||
| Summary | 0003010: Beams stay whilst ship casting them has been destroyed. | ||||
| Description | I am aware of a ship being capable of shooting weapons whilsts it's in it's "Final detonation" sequence, but currently, beams are able to fully finish their firing sequence even though the ship firing has been destroyed. The beams "Stay on" for their predetermined time whilst the ship's model has already been reduced to fiery debris. | ||||
| Additional Information | Tested repeatedly in the "Rescue" mission of the "Incursion" campaign (as provided by the campaign restoration project") | ||||
| Tags | No tags attached. | ||||
|
|
Replicable. Inspection of beam.cpp shows that the check for beam firing only takes place during the beam warmup. There is no way to turn off the beams mid-firing (if the firing ship has been destroyed). |
|
|
There is code that is supposed to serve this purpose, in beam_move_all_pre():
// check if parent object has died, if so then delete beam
if (b->objp->type == OBJ_NONE) {
// set next beam
moveup = GET_NEXT(moveup);
// delete current beam
beam_delete(b);
continue;
}
The object's type should be set to OBJ_NONE when it's deleted, which should happen shortly after OF_SHOULD_BE_DEAD gets set, which should happen if the ship is either vaporized or finished exploding. Is the problem that beams aren't stopping during the process of dying? Because that seems like intended behavior. |
|
|
Verified that ships upon final death have their beams deleted. Tested with the attached mission. Press 1 to fire beam. Press 2 to vaporize ship. OR Press 3 to self destruct ship. Recommend closing. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-02-18 19:59 | Joshua | New Issue | |
| 2014-08-17 04:38 | Echelon9 | Priority | high => low |
| 2015-05-22 05:04 | SmashMonkey | Note Added: 0016718 | |
| 2015-05-22 05:35 | MageKing17 | Note Added: 0016720 | |
| 2022-06-10 18:32 | MjnMixael | File Added: DestroyedBeamTest.fs2 | |
| 2022-06-10 18:32 | MjnMixael | Note Added: 0017121 | |
| 2022-06-10 18:55 | z64555 | Assigned To | => MjnMixael |
| 2022-06-10 18:55 | z64555 | Status | new => closed |
| 2022-06-10 18:55 | z64555 | Resolution | open => fixed |
| 2022-06-10 18:55 | z64555 | Fixed in Version | => 22.0.0 |
| 2022-06-11 00:53 | Goober5000 | Status | closed => resolved |
