View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000301 | FSSCP | cutscenes | public | 2005-01-13 14:36 | 2005-03-13 08:05 |
| Reporter | Alpha0 | Assigned To | taylor | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Dell Latitude D600 Notebook | OS | Windows 2000 Professional | OS Version | 5.00.2195 SP4 |
| Product Version | 3.6.5 | ||||
| Summary | 0000301: Red alert missions starting with a cutscene have the cutscene played twice. | ||||
| Description | On red alert missions that have an intro cutscene (such as the last FS2 main campaign mission), said cutscene is played twice. | ||||
| Steps To Reproduce | 1) Download attached zipped pilot files, extract and copy them to [fs2_open_main_dir]\data\players\single. The avis4 pilot is set to start on the last main campaign mission. 2) Launch fs2_open and select the avis4 pilot. 3) Go to ready room. 4) Sit back and enjoy the Bastion cutscene being played twice :) | ||||
| Additional Information | I believe the bug is at code\freespace2\freespace.cpp, line 6860. The mission_campaign_maybe_play_movie function is not required. The GS_STATE_RED_ALERT gamestate is not set initially, so the game flow arrives a few lines after that point, at line 6887 and mission_campaign_maybe_play_movie() is called for the first time. Then cmd_brief_init is called and a GS_EVENT_RED_ALERT is posted. This sets the GS_STATE_RED_ALERT gamestate, so when the program loops again it arrives at freespace.cpp line 6859 and enters the case statement. This results in the movie being played for a second time. Proposed fix: Comment out freespace.cpp, line 6860. This makes it work ok, at least on my system. | ||||
| Tags | No tags attached. | ||||
|
2005-01-13 14:36
|
|
|
|
Can someone confirm the fix works and commit it? (I'm not a coder.) |
|
|
The mission_campaign_maybe_play_movie() calls are the same as in retail so I don't really want to remove one of them. There must be some other change which is the real cause of this. I'll play with it some and see if I can't track it down. |
|
|
Ok, better use of a red_alert_mission() check will make sure this works as expected. Still not sure what's changed in the gamestate stuff to make it wrong but bringing the red_alert_mission() checks out to more prominent locations gets the job done without risking the movie not playing in any other cases. Fix will be going in CVS shortly. |
|
|
Fixered. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-01-13 14:36 | Alpha0 | New Issue | |
| 2005-01-13 14:36 | Alpha0 | File Added: avis4.zip | |
| 2005-03-12 20:09 | kasperl | Note Added: 0001760 | |
| 2005-03-12 23:44 | taylor | Note Added: 0001796 | |
| 2005-03-12 23:44 | taylor | Status | new => assigned |
| 2005-03-12 23:44 | taylor | Assigned To | => taylor |
| 2005-03-13 05:09 | taylor | Note Added: 0001797 | |
| 2005-03-13 08:05 | taylor | Status | assigned => resolved |
| 2005-03-13 08:05 | taylor | Resolution | open => fixed |
| 2005-03-13 08:05 | taylor | Note Added: 0001808 |
