View Issue Details

IDProjectCategoryView StatusLast Update
0002952FSSCPdockingpublic2013-11-15 03:31
Reporterniffiwan Assigned ToGoober5000  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.7.1 
Fixed in Version3.7.1 
Summary0002952: dock lists are not cleared between missions
DescriptionPretty much as the summary says.
In a release build, you can get cool stuff like the attached screenshot (from Surrender Belisarius!)
In a debug build, FSO hits an Assertion:
ASSERTION FAILED: "dock_list == NULL" at object/object.cpp:155 dock_list should have been cleared already!

It may also be responsible for some recently reported BluePlanet issues:
http://www.hard-light.net/forums/index.php?topic=86058.0
http://www.hard-light.net/forums/index.php?topic=86001.msg1719055#msg1719055
Steps To ReproduceStart any mission
Call in a support ship
When it is docked with you, end the mission (escape - quit)
Start any new mission
Additional InformationI believe this was introduced in 9995.
TagsNo tags attached.

Activities

niffiwan

2013-11-13 09:20

developer  

docked_with_WHAT.png (769,702 bytes)

Goober5000

2013-11-14 00:21

administrator   ~0015406

Okay, I added a method to clear out docking instance information when obj_delete is called. The methods are called again in object::clear, so this should take care of all possibilities.

niffiwan

2013-11-14 08:21

developer   ~0015407

that looks like its solved the issue. I'll follow up with Lykurgos88 on the forum to confirm, but you may as well close it for now. I can always reopen if required.

Goober5000

2013-11-15 03:31

administrator   ~0015408

Super. :)

Related Changesets

fs2open: trunk r10058

2013-11-13 19:46

Goober5000


Ported: N/A

Details Diff
clear dock lists when objects are deleted, and redundantly clear them between missions and when object instances are destroyed (Mantis 0002952) Affected Issues
0002952
mod - /trunk/fs2_open/code/object/deadobjectdock.cpp Diff File
mod - /trunk/fs2_open/code/object/deadobjectdock.h Diff File
mod - /trunk/fs2_open/code/object/object.cpp Diff File
mod - /trunk/fs2_open/code/object/objectdock.cpp Diff File
mod - /trunk/fs2_open/code/object/objectdock.h Diff File

Issue History

Date Modified Username Field Change
2013-11-13 09:20 niffiwan New Issue
2013-11-13 09:20 niffiwan Status new => assigned
2013-11-13 09:20 niffiwan Assigned To => Goober5000
2013-11-13 09:20 niffiwan File Added: docked_with_WHAT.png
2013-11-14 00:20 Goober5000 Changeset attached => fs2open trunk r10058
2013-11-14 00:21 Goober5000 Note Added: 0015406
2013-11-14 08:21 niffiwan Note Added: 0015407
2013-11-15 03:31 Goober5000 Note Added: 0015408
2013-11-15 03:31 Goober5000 Status assigned => resolved
2013-11-15 03:31 Goober5000 Resolution open => fixed
2013-11-15 03:31 Goober5000 Fixed in Version => 3.7.1