View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002921 | FSSCP | sound | public | 2013-09-21 06:46 | 2014-03-20 09:28 |
| Reporter | Goober5000 | Assigned To | niffiwan | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0002921: Main hall music isn't restored after credits | ||||
| Description | When you go to the tech room and view the credits tab, the credits music starts playing. If you then switch to the tech db menu, the credits music stops playing but the main hall music doesn't start. The main hall music will only start if you alt-tab away and back, or if you go back to the main hall. | ||||
| Tags | No tags attached. | ||||
|
|
This is a fairly simple fix - any comments? Note that main_hall_start_music() only starts the music if it's not already playing which means that I didn't worry about trying to deal with the previous state. https://github.com/niffiwan/fs2open.github.com/commit/6b1518eac04387d1bb9addb40d816d100ae4f032 |
|
|
I don't see anything obviously wrong with it, and it makes intuitive sense. If you've tested it and it works, go ahead and commit+resolve. |
|
|
per discussion with Goober on IRC, I've changed the implementation. Now start the music when leaving the credits state rather than in 3x init functions. This is similar to the way most of the mainhall music is stopped/started. |
|
|
Fix committed to trunk@10507. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-09-21 06:46 | Goober5000 | New Issue | |
| 2014-03-18 08:36 | niffiwan | Assigned To | => niffiwan |
| 2014-03-18 08:36 | niffiwan | Status | new => assigned |
| 2014-03-18 08:41 | niffiwan | Note Added: 0015669 | |
| 2014-03-18 08:41 | niffiwan | Status | assigned => feedback |
| 2014-03-19 01:02 | Goober5000 | Note Added: 0015670 | |
| 2014-03-19 01:02 | Goober5000 | Status | feedback => assigned |
| 2014-03-20 09:28 | niffiwan | Note Added: 0015671 | |
| 2014-03-20 09:28 | niffiwan | Changeset attached | => fs2open trunk r10507 |
| 2014-03-20 09:28 | niffiwan | Note Added: 0015672 | |
| 2014-03-20 09:28 | niffiwan | Status | assigned => resolved |
| 2014-03-20 09:28 | niffiwan | Resolution | open => fixed |
