View Issue Details

IDProjectCategoryView StatusLast Update
0000292FSSCPuser interfacepublic2004-12-28 16:17
ReporterAlpha0 Assigned Totaylor  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformDell Latitude D600 NotebookOSWindows 2000 ProfessionalOS Version5.00.2195 SP4
Product Version3.6.5 
Summary0000292: On pilot file upgrade, old .plr file is not deleted on released fs2_open v3.6.5..
DescriptionWhen an old type player file is selected, the program brings up a dialog requesting a confirmation from the user to convert the .plr file to .pl2 (the new fs_open pilot file format). Upon confirmation, the new player file is created, but the old .plr file is not deleted, as it is supposed to.
Steps To ReproduceYou must have an old format .plr file.
1) Launch the fs2_open executable.
2) On pilot select, select the .plr pilot file.
3) Confirm that you want the pilot file converted to fs2_open format.
4) Exit the game.
5) Go to [fs2 root directory]\data\players\single. You will see that the old .plr file is still there, although it should have been deleted.
Additional InformationTest system: Dell Latitude D600 Notebook, Intel Centrino 1.6GHz, 512MB RAM, Windows 2000 Professional SP4, Mobility Radeon 9000 w/ 32MB for graphics, graphics drivers version 6.13.10.6279. DX version 8.1 (4.08.01.0881).
Check file code\playerman\managepilot.cpp, function pilot_file_upgrade_check, line 534. The pilot file is opened for check, but is never closed, which results in the subsequent call to cf_delete to fail. Proposed fix:
Add the following line, below line 537 ( if (file) { ), in pilot_file_upgrade_check:
cfclose (file);
TagsNo tags attached.

Activities

taylor

2004-12-28 16:17

administrator   ~0001475

Bah, your right. I just missed that when copying the changes from my unstable to a stable tree.

Fixered.

Issue History

Date Modified Username Field Change
2004-12-28 10:07 Alpha0 New Issue
2004-12-28 16:17 taylor Status new => resolved
2004-12-28 16:17 taylor Resolution open => fixed
2004-12-28 16:17 taylor Assigned To => taylor
2004-12-28 16:17 taylor Note Added: 0001475