View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000291 | FSSCP | FRED | public | 2004-12-27 20:03 | 2005-06-30 15:25 |
| Reporter | Axem | Assigned To | taylor | ||
| Priority | normal | Severity | tweak | Reproducibility | sometimes |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000291: Adding new personas messes them up | ||||
| Description | taylor said on HLP that he added code for unlimited personas. So I modified the messages.tbl and added a few new personas. All of them showed up in FRED, and allowed me to select them. But once I exited the Ship Editor screen, the persona sometimes changed to another one. This only happens in fred2_open_3_6_5.exe, all the other builds just give an illegal operation right away with the modifed messages.tbl. Running fred2_open_3_6_5_debug.exe didn't show any problems (apart from some usual ones), but the debug_filter.cfg gave me this: +Parse +General +BmpMan +wash +but I did find %s.pcx, +couldn't find %s.ani +Fred routing | ||||
| Tags | No tags attached. | ||||
|
|
Egh, something freaky is going on there. The unlimited personas thing was tested my a few people before being made public and the only reported problem was fixed. Does it work differently with the 3.6.5 beta? The second one (that was public) not the first one that went to testers. Goober's 1215 build had a hard coded limit for the personas but no check to make sure it didn't go over that limit. I fixed that crash that was causing problems for him so I hope that old code didn't end up in the final 3.6.5. |
|
|
Ah okay, just tried it with fred2_open_r-T365.exe, didn't crash but it gives the same problem as with the 3.6.5 build. |
|
|
Haven't been able to reproduce this yet. If doing so doesn't violate state secrets or anything please attach the messages.tbl in question for me to test with. Oh and don't worry about the stuff in debug_filter.cfg. It's just people using mprintf()/nprintf() wrong. I had fixed those problems but never put the changes in CVS (forgot). edited on: 12-30-04 11:36 |
|
|
I just changed the names of the characters to protect the guilty, shouldn't make a difference. I only did the first two sections to see if they worked ingame. But it didn't so I haven't finished all their lines yet. |
|
2004-12-30 16:59
|
|
|
|
Man do I hate it when too much time is spent finding something that was totally obvious in the first place. The Persona combo box shouldn't be sorted. Because it's sorted the index into Personas is coming out wrong and will untimately get reset to <None>. That's why it worked for me, I added "Wingman 8" and "Wingman 9" for testing. Since those don't affect the order any it didn't show the problem. I'll go ahead and fix this but it will probably be this weekend before I can get the chance to make a new FRED2 build. |
|
|
Fixered. |
|
|
Finally got around to working on this mod again, and tried out the personas. The personas are in order in the drop down box, but as soon as I close the ship editor and reopen it, it just shows a blank space where it should show the current persona. When I try it out ingame anyway, any ship with a added persona won't say anything. |
|
|
K, I'll have another look. |
|
|
Haven't been able to recreate this yet. How many personas are you working with? |
|
|
I am working with the default personas, plus 6 ones I've added in myself. All of them are wingmen. I tried running a recent FRED2 debug build, but it froze after countless sound range errors. Through playing with it, I've noticed that when I add an added persona, it will set itself to whatever the last original persona was. So if I've set one fighter to Wingman 5, and then set another fighter to a custom one, exit the ship editor and go back, the fighter with the custom persona now has Wingman 5. I've uploaded the tbl I'm using right now. Maybe I have some stupid mistake I've missed with parsing or something. The latest build I've tried this in is Phreak's 05222005 build. |
|
2005-06-29 17:50
|
|
|
|
Ok, I'll try with this tbl and see what happens. Thanks for the explanation on the procedure to reproduce, that will help me out a lot. The sound problem is now fixed along with a few other crash bugs so I'm going to release a new FRED build tonight or tomorrow. I'll hold off until I get the personas thing figured out though so you can make sure it's good and fixed before the 3.6.7 version of FRED2 comes out. |
|
|
Hmm, this does look like a tbl problem. At least in the way the code has to handle it. In this tbl you have something like ...wingman ...wingman ...support ...command ...wingman ...wingman, but if you have all of the wingmen entries together, ...wingman ...wingman ...wingman ...wingman ...support ...command, then it works. The reason is that it only adds wingman entries to the dropdown list so if the wingman entries are separated by a non-wingman entry then the index into the personas and the index into the persona list don't match up. This is why it will either change to another wingman entry or go back to <None>. So this is basically the same sort of thing as the original sorting bug but this one isn't really code fixable. It's easily fixed by correcting the tbl though so that's what I would suggest. Try putting all of your wingman entries together and try again. Let me know if it works correctly for you. |
|
|
Aaah. That was it then, they all have to be grouped like that. Works like a charm now. Thanks a ton. :) |
|
|
Sweet. Fixered. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2004-12-27 20:03 | Axem | New Issue | |
| 2004-12-27 20:44 | taylor | Note Added: 0001473 | |
| 2004-12-27 20:44 | taylor | Status | new => assigned |
| 2004-12-27 20:44 | taylor | Assigned To | => taylor |
| 2004-12-27 20:56 | Axem | Note Added: 0001474 | |
| 2004-12-30 16:36 | taylor | Note Added: 0001480 | |
| 2004-12-30 16:36 | taylor | Note Edited: 0001480 | |
| 2004-12-30 16:59 | Axem | Note Added: 0001481 | |
| 2004-12-30 16:59 | Axem | File Added: messages.tbl | |
| 2004-12-30 18:42 | taylor | Note Added: 0001482 | |
| 2004-12-30 18:48 | taylor | Status | assigned => resolved |
| 2004-12-30 18:48 | taylor | Resolution | open => fixed |
| 2004-12-30 18:48 | taylor | Note Added: 0001483 | |
| 2005-06-17 04:38 | Axem | Status | resolved => feedback |
| 2005-06-17 04:38 | Axem | Resolution | fixed => reopened |
| 2005-06-17 04:38 | Axem | Note Added: 0002640 | |
| 2005-06-17 07:07 | taylor | Note Added: 0002642 | |
| 2005-06-19 03:59 | taylor | Status | feedback => assigned |
| 2005-06-29 14:28 | taylor | Note Added: 0002712 | |
| 2005-06-29 17:50 | Axem | Note Added: 0002715 | |
| 2005-06-29 17:50 | Axem | File Added: messages.tbl | |
| 2005-06-29 18:03 | taylor | Note Added: 0002716 | |
| 2005-06-30 05:48 | taylor | Note Added: 0002723 | |
| 2005-06-30 14:31 | Axem | Note Added: 0002725 | |
| 2005-06-30 15:25 | taylor | Status | assigned => resolved |
| 2005-06-30 15:25 | taylor | Resolution | reopened => fixed |
| 2005-06-30 15:25 | taylor | Note Added: 0002726 |
