View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002851 | FSSCP | FRED | public | 2013-04-24 02:16 | 2017-01-23 19:31 |
| Reporter | FUBAR-BDHR | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.19 | ||||
| Fixed in Version | 3.8 | ||||
| Summary | 0002851: Messages with special characters not being updated to there $ versions on mission save | ||||
| Description | I've been going over some old missions and have noticed things like dates being updated correctly on mission save from using / to $slash. I just found a mission with about 15 copies of a strange message. Removed the duplicates in notepad, opened in FRED and resaved thinking it would fix it like it did with the other fields. No dice. Not only did it not fix it but it added a new duplicate. Message as it appears in the .fs2 file is: $MessageNew: XSTR("--//--//----\\--\\--", -1) For every save an additional //--//----\\--\\--", -1) line is added. Now if I go into the event editor and look at the message it appears correctly. If I save after that it does change to using $slash and $backslash. | ||||
| Steps To Reproduce | I'll attach the original mission (which is TBP) and a retail mission with a message edited to use the TBP mission one. Open the mission in notepad, find and look at the message. Open mission in FRED, save it, look at the message in notepad again. | ||||
| Tags | No tags attached. | ||||
|
|
|
|
|
|
|
|
Found that FRED supported //-style comments, see CFred_mission_save::parse_comments(). This was causing the duplicates of the message. Note that parselo.cpp's strip_comments() does not support //-style comments (i.e. FSO itself doesn't support them), so in discussion with MageKing17, the decision was made to remove the support from FRED (PR 592). Running the $-substitution on mission save was deemed unnecessary. |
|
|
Resolved per PR 592 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-04-24 02:16 | FUBAR-BDHR | New Issue | |
| 2013-04-24 02:16 | FUBAR-BDHR | File Added: BH1_10_bc.fs2 | |
| 2013-04-24 02:22 | FUBAR-BDHR | File Added: SM1-01 - Copy.FS2 | |
| 2016-04-16 22:03 | FSF | Note Added: 0016826 | |
| 2017-01-23 18:19 | The_E | Assigned To | => MageKing17 |
| 2017-01-23 18:19 | The_E | Status | new => resolved |
| 2017-01-23 18:19 | The_E | Resolution | open => fixed |
| 2017-01-23 18:19 | The_E | Fixed in Version | => 3.8 |
| 2017-01-23 18:19 | The_E | Note Added: 0016854 | |
| 2017-01-23 19:31 | The_E | Assigned To | MageKing17 => |
