All Projects FSSCP  wxFRED

View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002800FSSCPmultiplayerpublic2013-02-26 21:192013-12-03 09:35
ReporterFUBAR-BDHR Assigned ToEchelon9  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version3.6.16 
Summary0002800: Particles not removed on standalone
DescriptionHad a crash on a standalone the other day and notice that the num_particles high water marks being logged where huge. Values were exceeding 395k. This didn't seem right (not to mention making for a 30meg log file) so I went fishing. Seems that particles are created on a standalone but the only place I can find that they are removed is in particle_move_all() which isn't called from a standalone. They also don't appear to be cleared between missions. Not sure if they are in single or not so that may be an issue as well.
Steps To ReproduceHost a debug standalone, play a few games on it, check the log. Although as with most multiplayer issues it's probably easier to just look at the code.
TagsNo tags attached.

Activities

Echelon9

2013-12-01 10:53

developer  

fix-mantis-2800.patch (441 bytes)    
Index: code/freespace2/freespace.cpp
===================================================================
--- code/freespace2/freespace.cpp	(revision 10178)
+++ code/freespace2/freespace.cpp	(working copy)
@@ -902,6 +902,7 @@
 		mission_brief_common_reset();		// close out parsed briefing/mission stuff
 		cam_close();
 		subtitles_close();
+		particle_close();
 		trail_level_close();
 		ship_clear_cockpit_displays();
 		hud_level_close();
fix-mantis-2800.patch (441 bytes)   

Echelon9

2013-12-01 10:55

developer   ~0015478

Patch uploaded which should ensure the particles STL container is cleared between missions, and does not grow indefinitely.

This is a code path which is definitely reached by the standalone server.

Echelon9

2013-12-03 09:35

developer   ~0015488

Fix committed to trunk@10182.

Related Changesets

fs2open: trunk r10182

2013-12-03 05:05

Echelon9


Ported: N/A

Details Diff		 Fix Mantis 2800: Particles not removed on standalone Affected Issues
0002800
mod - /trunk/fs2_open/code/freespace2/freespace.cpp Diff File

Issue History

Date Modified Username Field Change
2013-02-26 21:19 FUBAR-BDHR New Issue
2013-12-01 10:52 Echelon9 Assigned To => Echelon9
2013-12-01 10:52 Echelon9 Status new => assigned
2013-12-01 10:53 Echelon9 File Added: fix-mantis-2800.patch
2013-12-01 10:54 Echelon9 Status assigned => code review
2013-12-01 10:55 Echelon9 Note Added: 0015478
2013-12-03 09:35 Echelon9 Changeset attached => fs2open trunk r10182
2013-12-03 09:35 Echelon9 Note Added: 0015488
2013-12-03 09:35 Echelon9 Status code review => resolved
2013-12-03 09:35 Echelon9 Resolution open => fixed