View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002747 | FSSCP | HUD | public | 2012-12-04 00:19 | 2012-12-06 03:12 |
| Reporter | FUBAR-BDHR | Assigned To | Goober5000 | ||
| Priority | high | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.15 | ||||
| Target Version | 3.6.16 | ||||
| Summary | 0002747: Default player ships with no shields have shield ETS | ||||
| Description | This bug occurs on any ship without shields that is the player ship at mission start. If you do not change the default ship or change and change back to the default ship you will have ETS for shields. This cuts power regen to engines and weapons. | ||||
| Steps To Reproduce | Easily reproducible with any TBP ship. Default aurora works fine. Start mission and notice you have ETS gauges for weapons, engines and shields. Exit mission, launch again, select different ship and notice only weapon and engine ETS guages with higher power regen. | ||||
| Additional Information | Traced to r7268. | ||||
| Tags | No tags attached. | ||||
|
|
To clarify, TBP is not using the "intrinsic no shields" ship flag. TBP wants to be able to set shields to default off by setting shield strength to 0 instead. If FUBAR doesn't attach the necessary files for easy reproduction (since not everyone has "any TBP ship") by the time I get home, I'll attach them. |
|
|
I'm going to have to default this one to being a "Will Not Fix" in my opinion. TBP utilized a very bad assumption short cut. It's all well and nice that the ships have no modeled shields. That is also irrelevant. By setting a value for a variable, you acknowledge the variable and as such, it is something that can then be modified. They could have fredded for genuine no shields in other ways, and chose not to. I appreciate that the original data is unalterable and I don't envy that issue. But Zathras can correct for it via a TBM and TBP as it was released was never intended for any FSO build other than the one it was released with. I do not agree to manipulating this into being able to work with the original flawed logic premise. |
|
|
Addendum: ships.tbl in TBP released has several ships where a value OTHER than 0 was defined for the shields. Code is operating as expected. |
|
|
|
|
|
Alright, you can use the shieldmod I attached to reproduce. It includes a Uly with no shields in POF and table data, just to reproduce accurately. The POF data shouldn't make a difference though. Run the mission included on a trunk build and you'll have Shields in your ETS. Run the same mission on build 7265 or earlier and you won't have Shields in your ETS. I'll leave it to the SCP guys to discuss if and how this should be resolved because this is mostly just a legacy code path. New mods should use the 'no shields' ship flag. |
|
|
This is due to an actual and legitimate bug in the revision. The test was comparing the multiplier rather than the result of the multiplier and the shield strength. This obviously results in an incorrect answer if you have a multiplier of 1.0 and a tabled shield strength of 0. A separate, different problem in the revision is that you can now no longer give custom shields to a ship which has been tabled for 0 shields. But that's a question for The E... This bug should be fixed as of revision 9397. A test would be appreciated. |
|
|
You'll also need r9399, otherwise trunk, she won't compile :) edit: also tested using the shieldmod - fixes the issue for the default player ship (Uly) |
|
|
Works for me as well.. but it's FUBAR's bug, so we'll need his almighty approval. |
|
|
If two people confirmed it, that's good enough for me. Resolving. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-12-04 00:19 | FUBAR-BDHR | New Issue | |
| 2012-12-04 00:50 | MjnMixael | Note Added: 0014278 | |
| 2012-12-04 01:13 | Zacam | Note Added: 0014279 | |
| 2012-12-04 02:58 | Zacam | Note Added: 0014280 | |
| 2012-12-04 04:05 | MjnMixael | File Added: shieldmod.7z | |
| 2012-12-04 04:07 | MjnMixael | Note Added: 0014281 | |
| 2012-12-05 07:20 | Goober5000 | Note Added: 0014302 | |
| 2012-12-05 07:20 | Goober5000 | Assigned To | => Goober5000 |
| 2012-12-05 07:20 | Goober5000 | Status | new => feedback |
| 2012-12-05 08:54 | niffiwan | Note Added: 0014304 | |
| 2012-12-05 09:04 | niffiwan | Note Edited: 0014304 | |
| 2012-12-05 09:04 | niffiwan | Note Edited: 0014304 | |
| 2012-12-05 15:31 | MjnMixael | Note Added: 0014305 | |
| 2012-12-06 03:12 | Goober5000 | Note Added: 0014321 | |
| 2012-12-06 03:12 | Goober5000 | Status | feedback => resolved |
| 2012-12-06 03:12 | Goober5000 | Resolution | open => fixed |
