All Projects FSSCP  wxFRED

View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002681FSSCPHUDpublic2012-07-07 02:482012-07-24 02:08
ReporterGoober5000 Assigned Toniffiwan  
PriorityurgentSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Target Version3.6.14 
Summary0002681: One part of the FSPort reticle is miscolored
DescriptionSee attached screenshot. The reticle quadrant on the lower-right is not colored the same as the rest of the HUD.

This appears to only happen with the modified lower-right quadrant (i.e. the one that shows primary and secondary weapon selection). The FS2 reticle displays in the expected color.
TagsNo tags attached.

Activities

Goober5000

2012-07-07 02:50

administrator  

reticle.png (113,520 bytes)   
reticle.png (113,520 bytes)   

niffiwan

2012-07-07 10:27

developer  

mantis2681.patch (467 bytes)    
Index: fs2_open/code/hud/hudreticle.cpp
===================================================================
--- fs2_open/code/hud/hudreticle.cpp    (revision 8995)
+++ fs2_open/code/hud/hudreticle.cpp    (working copy)
@@ -755,6 +755,8 @@ void HudGaugeWeaponLinking::render(float frametime)
 	int			gauge_index=0, frame_offset=0;
 	ship_weapon	*swp;
 
+	setGaugeColor();
+
 	renderBitmap(arc.first_frame+1, position[0], position[1]);
 
 	swp = &Player_ship->weapons;
mantis2681.patch (467 bytes)   

niffiwan

2012-07-07 10:29

developer   ~0013838

I hope Swifty doesn't mind me pushing in here.... I think this is a simple fix - please see the attached patch. Could you please test this Goober?

Goober5000

2012-07-07 20:46

administrator   ~0013840

I was hoping it would be a quick fix like that. That does indeed fix the issue. :)

I just want to get Swifty's input on whether this is the right place to put that, and if it is, we can mark this as fixed.

Swifty

2012-07-07 20:48

developer   ~0013841

It's fine.

Goober5000

2012-07-07 20:49

administrator   ~0013842

Terrific -- Swifty has signed off on it.

Goober5000

2012-07-07 20:49

administrator   ~0013843

Fix committed to trunk@9000.

Zacam

2012-07-24 02:08

administrator   ~0013880

Fix committed to fs2_open_3_6_14@9035.

Related Changesets

fs2open: trunk r9000

2012-07-07 16:51

Goober5000


Ported: N/A

Details Diff		 niffiwan's fix for Mantis 0002681 Affected Issues
0002681
mod - /trunk/fs2_open/code/hud/hudreticle.cpp Diff File

fs2open: fs2_open_3_6_14 r9035

2012-07-23 22:13

Zacam


Ported: N/A

Details Diff		 Backport: Trunk r9000; niffiwan's fix for Mantis 0002681 Affected Issues
0002681
mod - /branches/fs2_open_3_6_14/code/hud/hudreticle.cpp Diff File

Issue History

Date Modified Username Field Change
2012-07-07 02:48 Goober5000 New Issue
2012-07-07 02:48 Goober5000 Assigned To => Swifty
2012-07-07 02:48 Goober5000 Status new => assigned
2012-07-07 02:50 Goober5000 File Added: reticle.png
2012-07-07 10:27 niffiwan File Added: mantis2681.patch
2012-07-07 10:29 niffiwan Note Added: 0013838
2012-07-07 10:30 niffiwan Status assigned => feedback
2012-07-07 20:46 Goober5000 Note Added: 0013840
2012-07-07 20:46 Goober5000 Status feedback => assigned
2012-07-07 20:46 Goober5000 Assigned To Swifty => niffiwan
2012-07-07 20:46 Goober5000 Status assigned => feedback
2012-07-07 20:48 Swifty Note Added: 0013841
2012-07-07 20:49 Goober5000 Note Added: 0013842
2012-07-07 20:49 Goober5000 Status feedback => assigned
2012-07-07 20:49 Goober5000 Status assigned => resolved
2012-07-07 20:49 Goober5000 Resolution open => fixed
2012-07-07 20:49 Goober5000 Changeset attached => fs2open trunk r9000
2012-07-07 20:49 Goober5000 Note Added: 0013843
2012-07-24 02:08 Zacam Changeset attached => fs2open fs2_open_3_6_14 r9035
2012-07-24 02:08 Zacam Note Added: 0013880