0002678: FRED can save coop missions that will crash on start

ID	Project	Category	View Status	Date Submitted	Last Update

0002678	FSSCP	FRED	public	2012-07-04 20:25	2012-07-24 03:03

Reporter	MatthTheGeek	Assigned To	Goober5000
Priority	normal	Severity	minor	Reproducibility	always
Status	resolved	Resolution	fixed
Product Version	3.6.14 RC5

Summary	0002678: FRED can save coop missions that will crash on start
Description	FSO crashes with an "ASSERTION: "Player_start_shipnum != -1" at missionparse.cpp:5279" when trying to start a mission where a player wing has the +Arrival delay: property set. This is not a problem by itself since that property is entirely optional. However, FRED automatically sets that property by default when you create a new wing, and the corresponding field (Delay XX seconds) is greyed out and uneditable for player wings. FRED will not raise any warning when saving. This can only be solved by hand-editing the mission file. It doesn't crash with a release build, but it opens an in-game pop-up : "server encountered errors trying to assign players to ships" and gets you back to the lobby.
Steps To Reproduce	1) Open FRED 2) set mission specs to multiplayer - coop 3) select the player ship and create alpha wing 4) save and try to open the mission with a debug build
Additional Information	The crash itself isn't really an issue. Ideally, however, FRED should be able to fix it itself when saving and/or send a warning when saving.
Tags	No tags attached.

Goober5000 2012-07-04 21:41 administrator ~0013824	Your steps did not reproduce the problem for me. Can you test it again on the latest 3.6.14 branch build? http://staff.hard-light.net/goober5000/temp/r8994.zip

MatthTheGeek 2012-07-05 05:56 reporter ~0013829 Last edited: 2012-07-05 05:57	Indeed. It seems those builds set Arrival delay to 0 by default. The problem can still happen if you do something like 1) create a new ship 2) put it in Alpha wing 3) add an arrival delay to alpha wing 3) set mission specs to coop 4) make alpha 1 the player ship However it is more contrived and I doubt many people will hit it now. I'm uploading a copy of a mission set up like this that crashes FSO at load. See files attached to the mantis report.

MatthTheGeek 2012-07-05 05:57 reporter	...CoopTest.fs2 (3,337 bytes)

Goober5000 2012-07-13 05:04 administrator ~0013855	Fixed and tested on FRED and FSO.

fs2open: trunk r9010 2012-07-13 01:06 Goober5000 Ported: N/A Details Diff	check to make sure a wing that has a player does not also have an arrival delay (Mantis 0002678)	Affected Issues 0002678
	mod - /trunk/fs2_open/code/mission/missionparse.cpp	Diff File
fs2open: fs2_open_3_6_14 r9041 2012-07-23 23:08 Zacam Ported: N/A Details Diff	Backport: Trunk r9010; check to make sure a wing that has a player does not also have an arrival delay (Mantis 0002678)	Affected Issues 0002678
	mod - /branches/fs2_open_3_6_14/code/mission/missionparse.cpp	Diff File

Date Modified	Username	Field	Change
2012-07-04 20:25	MatthTheGeek	New Issue
2012-07-04 21:41	Goober5000	Note Added: 0013824
2012-07-04 21:41	Goober5000	Assigned To	=> Goober5000
2012-07-04 21:41	Goober5000	Status	new => feedback
2012-07-05 05:56	MatthTheGeek	Note Added: 0013829
2012-07-05 05:56	MatthTheGeek	Status	feedback => assigned
2012-07-05 05:57	MatthTheGeek	File Added: ...CoopTest.fs2
2012-07-05 05:57	MatthTheGeek	Note Edited: 0013829
2012-07-13 05:03	Goober5000	Changeset attached	=> fs2open trunk r9010
2012-07-13 05:04	Goober5000	Note Added: 0013855
2012-07-13 05:04	Goober5000	Status	assigned => resolved
2012-07-13 05:04	Goober5000	Resolution	open => fixed
2012-07-24 03:03	Zacam	Changeset attached	=> fs2open fs2_open_3_6_14 r9041