View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002676 | FSSCP | FRED graphics | public | 2012-07-02 17:05 | 2012-07-24 02:10 |
| Reporter | Zacam | Assigned To | Zacam | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Target Version | 3.6.14 | ||||
| Summary | 0002676: FRED "Show Outlines" rendering mode exceptionally slow. | ||||
| Description | Wireframe rendering mode in FRED 2 Open has been exceptionally slow compared to not showing any models at all and even slower than when showing models. | ||||
| Additional Information | Attached patch adjusts 2 instances of MR_SHOW_OUTLINE to MR_SHOW_OUTLINE_HTL. | ||||
| Tags | No tags attached. | ||||
|
|
2676_fredrender.cpp.patch (1,022 bytes)
Index: fredrender.cpp
===================================================================
--- fredrender.cpp (revision 8973)
+++ fredrender.cpp (working copy)
@@ -768,7 +768,7 @@
{
if (Fred_outline) {
model_set_outline_color(Fred_outline >> 16, (Fred_outline >> 8) & 0xff, Fred_outline & 0xff);
- model_render(Ship_info[Ships[z].ship_info_index].model_num, &objp->orient, &objp->pos, j | MR_SHOW_OUTLINE, -1, -1, Ships[z].ship_replacement_textures);
+ model_render(Ship_info[Ships[z].ship_info_index].model_num, &objp->orient, &objp->pos, j | MR_SHOW_OUTLINE_HTL, -1, -1, Ships[z].ship_replacement_textures);
} else {
model_render(Ship_info[Ships[z].ship_info_index].model_num, &objp->orient, &objp->pos, j, -1, -1, Ships[z].ship_replacement_textures);
}
@@ -905,7 +905,7 @@
if (Fred_outline) {
model_set_outline_color(Fred_outline >> 16, (Fred_outline >> 8) & 0xff, Fred_outline & 0xff);
- j |= MR_SHOW_OUTLINE;
+ j |= MR_SHOW_OUTLINE_HTL;
}
g3_done_instance(0);
|
|
fs2open: trunk r8977 2012-07-03 01:05 Ported: N/A Details Diff |
this is the equivalent of r8975 for FRED (Mantis 0002676) |
Affected Issues 0002676 |
|
| mod - /trunk/fs2_open/code/fred2/fredrender.cpp | Diff File | ||
|
fs2open: fs2_open_3_6_14 r8989 2012-07-04 15:51 Ported: N/A Details Diff |
Backport: Trunk r8977; this is the equivalent of r8975 for FRED (Mantis 0002676) |
Affected Issues 0002676 |
|
| mod - /branches/fs2_open_3_6_14/code/fred2/fredrender.cpp | Diff File | ||
|
fs2open: trunk r9002 2012-07-07 17:01 Ported: N/A Details Diff |
also revert the "nohtl" part of r8977 for FRED (Mantis 0002676) because no-HTL models shouldn't use HTL rendering |
Affected Issues 0002676 |
|
| mod - /trunk/fs2_open/code/fred2/fredrender.cpp | Diff File | ||
|
fs2open: fs2_open_3_6_14 r9037 2012-07-23 22:15 Ported: N/A Details Diff |
Backport: Trunk r9002; also revert the "nohtl" part of r8977 for FRED (Mantis 0002676) because no-HTL models shouldn't use HTL rendering |
Affected Issues 0002676 |
|
| mod - /branches/fs2_open_3_6_14/code/fred2/fredrender.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-02 17:05 | Zacam | New Issue | |
| 2012-07-02 17:05 | Zacam | Status | new => assigned |
| 2012-07-02 17:05 | Zacam | Assigned To | => Zacam |
| 2012-07-02 17:05 | Zacam | File Added: 2676_fredrender.cpp.patch | |
| 2012-07-02 19:10 | Zacam | Status | assigned => code review |
| 2012-07-03 05:04 | Goober5000 | Changeset attached | => fs2open trunk r8977 |
| 2012-07-03 05:04 | Goober5000 | Status | code review => resolved |
| 2012-07-03 05:04 | Goober5000 | Resolution | open => fixed |
| 2012-07-04 19:50 | Zacam | Changeset attached | => fs2open fs2_open_3_6_14 r8989 |
| 2012-07-07 20:53 | Goober5000 | Relationship added | related to 0002396 |
| 2012-07-07 20:59 | Goober5000 | Changeset attached | => fs2open trunk r9002 |
| 2012-07-24 02:10 | Zacam | Changeset attached | => fs2open fs2_open_3_6_14 r9037 |
