View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002655 | FSSCP | HUD | public | 2012-05-20 05:36 | 2012-07-02 01:03 |
| Reporter | niffiwan | Assigned To | niffiwan | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | Ubuntu | OS Version | 12.04 |
| Product Version | 3.6.14 RC5 | ||||
| Summary | 0002655: Messages without audio play too quickly | ||||
| Description | Messages don't check if the head ani is complete. They only check if the audio is complete and the message expiry (which is relatively new), therefore in certain cases the messages play too fast. See Axem's test mission for one example: http://lazymodders.fsmods.net/files/hudbugs.fs2 | ||||
| Tags | No tags attached. | ||||
|
|
Fix committed to trunk@8802. |
|
|
note: commit 8802 depends on 8801 - it'll break messages without Playing_messages[x].play_anim being set to false when a head anis aren't playing |
|
|
Hold on. The hud ani is subordinate to the message, not vice versa. If there is a wav file provided for the message, the message should end immediately upon the completion of the wav file. Some voice acted campaigns depend on this. If this is referring to a message *without* a wav file, though, then that's different. Clarification is needed. |
|
|
I made a poor choice of commit title :) This is for messages without a wav file so they play at least as long as the head ani runs - this was the behaviour in 3.6.12 (tested with Axem's mission). There's other code (that I haven't changed) to deal with a message with ani & wav, and will abort the ani when the wav ends. mission/missionmessage.cpp // AL 1-20-98: If voice message is done, kill the animation early if ( (Playing_messages[i].wave != -1) && wave_done ) { /*if ( !ani_done ) { anim_stop_playing( Playing_messages[i].anim ); }*/ Playing_messages[i].play_anim = false; } |
|
|
Okay. What changed between 3.6.12 and 3.6.14 to alter the behavior? |
|
|
In r6833 some code was commented out: In mission/missionmessage.cpp @@ -1182,8 +1186,8 @@ void message_queue_process() int ani_done, wave_done, j; ani_done = 1; - if ( (Playing_messages[i].anim != NULL) && anim_playing(Playing_messages[i].anim) ) - ani_done = 0; + //if ( (Playing_messages[i].anim != NULL) && anim_playing(Playing_messages[i].anim) ) + // ani_done = 0; wave_done = 1; I believe this was done because Playing_messages (array of struct pmessage) changed to remove the .anim pointer, however it also meant that ani_done was always 1 and therefore the check to see if messages should end always assumed that the head ani had finished. This situation probably doesn't come up very often, i.e. where the length of the head ani is the deciding factor in whether a message ends or not. You need a message without a wav and one that is repeated at a short interval. I think the only place I saw something like this (outside of Axem's test mission) was in JAD - Burn baby burn, Burn! Burn! Burn! :-) (although maybe that was where I saw the head ani not being repeated properly... i.e. mantis 2411...) |
|
|
Okay. And presumably your commit takes this into account? If everything is kosher, then we can go ahead and mark this resolved again. :) |
|
|
yeah - I essentially re-instated the commented out code, except using the new variable which records if an ani is playing or not (bool Playing_message[].play_anim). It does require r8801 to work properly though, as that commit correctly sets .play_anim to false when an ani ends ;) |
|
|
Fix committed to fs2_open_3_6_14@8938. |
|
fs2open: trunk r8802 2012-05-20 02:03 Ported: N/A Details Diff |
Fix for mantis 2655: play messages at least until head ani finishes |
Affected Issues 0002655 |
|
| mod - /trunk/fs2_open/code/mission/missionmessage.cpp | Diff File | ||
|
fs2open: fs2_open_3_6_14 r8938 2012-07-01 21:04 Ported: N/A Details Diff |
Backport: Trunk r8802; Fix for mantis 2655: play messages at least until head ani finishes |
Affected Issues 0002655 |
|
| mod - /branches/fs2_open_3_6_14/code/mission/missionmessage.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-05-20 05:36 | niffiwan | New Issue | |
| 2012-05-20 05:36 | niffiwan | Status | new => assigned |
| 2012-05-20 05:36 | niffiwan | Assigned To | => niffiwan |
| 2012-05-20 05:36 | niffiwan | Relationship added | related to 0002411 |
| 2012-05-20 05:38 | niffiwan | Relationship added | related to 0002588 |
| 2012-05-20 06:01 | niffiwan | Changeset attached | => fs2open trunk r8802 |
| 2012-05-20 06:01 | niffiwan | Note Added: 0013572 | |
| 2012-05-20 06:01 | niffiwan | Status | assigned => resolved |
| 2012-05-20 06:01 | niffiwan | Resolution | open => fixed |
| 2012-05-20 06:04 | niffiwan | Note Added: 0013573 | |
| 2012-05-20 06:04 | niffiwan | Status | resolved => feedback |
| 2012-05-20 06:04 | niffiwan | Resolution | fixed => reopened |
| 2012-05-20 06:04 | niffiwan | Status | feedback => resolved |
| 2012-05-20 06:04 | niffiwan | Resolution | reopened => fixed |
| 2012-05-20 19:45 | Goober5000 | Note Added: 0013579 | |
| 2012-05-20 19:45 | Goober5000 | Status | resolved => code review |
| 2012-05-20 21:39 | niffiwan | Note Added: 0013585 | |
| 2012-05-21 04:54 | Goober5000 | Note Added: 0013589 | |
| 2012-05-21 07:02 | niffiwan | Note Added: 0013590 | |
| 2012-05-21 08:24 | Goober5000 | Note Added: 0013595 | |
| 2012-05-21 09:16 | niffiwan | Note Added: 0013596 | |
| 2012-05-21 09:16 | niffiwan | Status | code review => resolved |
| 2012-07-02 01:03 | Zacam | Changeset attached | => fs2open fs2_open_3_6_14 r8938 |
| 2012-07-02 01:03 | Zacam | Note Added: 0013762 |
