View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002650 | FSSCP | tables | public | 2012-05-09 04:05 | 2012-05-10 12:31 |
Reporter | CommanderDJ | Assigned To | CommanderDJ | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Summary | 0002650: Allow 0 door animations in mainhall.tbl/tbms | ||||
Description | [2012-05-09 11:57:17] <CommanderDJ> Sir? [2012-05-09 11:57:30] <MjnMixael|AWAY> just ran my AP tests [2012-05-09 11:57:57] <CommanderDJ> What'd you find? [2012-05-09 11:57:57] <MjnMixael|AWAY> intercom sounds can't be 0 on antipodes (as you probably guessed). misc anims can be 0 with no problems... [2012-05-09 11:58:34] <MjnMixael|AWAY> Doors is somewhat more complicated [2012-05-09 11:59:00] <MjnMixael|AWAY> 0 door animations works fine until you mouse over where one of the buttons should be according to the mainhall mask [2012-05-09 11:59:35] <MjnMixael|AWAY> so the mainhall loads properly without door animations, but when you mouseover a "door" it seems like it's hardcoded that there should be some sort of animation.. which causes a CTD [2012-05-09 11:59:56] <CommanderDJ> Ooh, ouch. Yes, this confirms my hypothesis: parsing handles it fine, it's the functions which actually play animations that freak out. [2012-05-09 12:01:10] <CommanderDJ> I'll have to have a look at this in the near future. [2012-05-09 12:01:13] <MjnMixael|AWAY> so it would be nice to either have FSO handle 0 anims (and intercom sounds, possibly with m!m's patch) or cause a debug error to be written to the log [2012-05-09 12:01:39] <CommanderDJ> Having no anims shouldn't be a problem. I'd prefer if it could just handle it. [2012-05-09 12:01:53] <MjnMixael|AWAY> as would I [2012-05-09 12:02:15] <MjnMixael|AWAY> as Axem pointed out to me recently, it makes sense for people to be able to simply bake a BG image and a mainhall mask, and call it a day [2012-05-09 12:02:22] <MjnMixael|AWAY> bake = make [2012-05-09 12:02:26] <CommanderDJ> Lol, bake. [2012-05-09 12:03:01] <MjnMixael|AWAY> so anyway, thanks for adding this to your todo list | ||||
Additional Information | Related to 0002648. May be able to use code from that. | ||||
Tags | No tags attached. | ||||
|
So I have determined that m_m's solution to the intercom sounds issue is probably the best way of doing it without too much effort. In light of this, the code in 2648's patch has been synced to Antipodes, and testing confirms that intercom sounds are no longer a problem. Hopefully I just have to do something similar with doors. |
|
Okay, I'm changing this bug's name and type, since I'm only dealing with doors, and we want this not to happen in trunk as well as Antipodes. So the patch I'm about to upload will be a trunk patch, and then that can just get synced to Antipodes to fix it there. |
|
mantis_2650.patch (831 bytes)
Index: code/menuui/mainhallmenu.cpp =================================================================== --- code/menuui/mainhallmenu.cpp (revision 8766) +++ code/menuui/mainhallmenu.cpp (working copy) @@ -1316,6 +1316,12 @@ return; } + //don't do anything if there are no animations to play + else if (Main_hall_door_anim.size() == 0) + { + return; + } + //run backwards and stop at the first frame Main_hall_door_anim.at(region).direction = GENERIC_ANIM_DIRECTION_BACKWARDS | GENERIC_ANIM_DIRECTION_NOLOOP; @@ -1345,6 +1351,12 @@ return; } + //don't do anything if there are no animations to play + else if (Main_hall_door_anim.size() == 0) + { + return; + } + //run forwards Main_hall_door_anim.at(region).direction = GENERIC_ANIM_DIRECTION_FORWARDS; //stay on last frame if we have no keyframe |
|
Fix committed to trunk in rev 8768 |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-05-09 04:05 | CommanderDJ | New Issue | |
2012-05-09 04:05 | CommanderDJ | Status | new => assigned |
2012-05-09 04:05 | CommanderDJ | Assigned To | => CommanderDJ |
2012-05-09 04:05 | CommanderDJ | Relationship added | related to 0002648 |
2012-05-10 10:12 | CommanderDJ | Note Added: 0013536 | |
2012-05-10 10:56 | CommanderDJ | Note Added: 0013537 | |
2012-05-10 10:56 | CommanderDJ | Product Version | Antipodes 8 => |
2012-05-10 10:56 | CommanderDJ | Summary | Allow 0 animations in refactored mainhall.tbl/tbms => Allow 0 door animations in mainhall.tbl/tbms |
2012-05-10 11:00 | CommanderDJ | File Added: mantis_2650.patch | |
2012-05-10 11:01 | CommanderDJ | Status | assigned => code review |
2012-05-10 11:58 | CommanderDJ | File Deleted: mantis_2650.patch | |
2012-05-10 11:58 | CommanderDJ | File Added: mantis_2650.patch | |
2012-05-10 12:31 | The_E | Status | code review => assigned |
2012-05-10 12:31 | The_E | Note Added: 0013538 | |
2012-05-10 12:31 | The_E | Status | assigned => resolved |
2012-05-10 12:31 | The_E | Resolution | open => fixed |