View Issue Details

IDProjectCategoryView StatusLast Update
0002635FSSCPFREDpublic2012-11-26 01:08
Reporterjg18 Assigned ToThe_E  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
OSWindows 7OS VersionWin7 Pro x86 
Product Version3.6.14 RC5 
Summary0002635: A ship's weapon of None is saved in .fs2 file as "ÿÿÿÿ"
DescriptionWhen a ship has a primary or secondary bank set to None, the bank is recorded in the .fs2 file as "ÿÿÿÿ" instead of "" (including the quotes in both cases). I've seen this behavior in 3.6.14 RC5 but not in 3.6.14 RC4.
Steps To Reproduce(1) Open the attached noweaponstest.fs2 file in FRED 3.6.14 RC4. Note that Alpha 1's first primary bank is set to None.

(2) Save the mission without making changes and close FRED.

(3) Open the mission in Notepad or Notepad++ (I used Notepad++). Note that Alpha 1's first primary bank is listed as "" (including the quotes).

(4) Now open the file in FRED 3.6.14 RC5. Alpha 1's first primary bank should still be None.

(5) Save the mission again without making any changes and close FRED.

(6) Open the mission in Notepad or Notepad++ again. Alpha 1's first primary bank should be "ÿÿÿÿ" instead of "" (including the quotes).
TagsNo tags attached.

Relationships

related to 0002735 resolvedValathil Assigning "None" as a turret weapon gets saved as "ÿÿÿÿ" 

Activities

jg18

2012-03-30 23:35

developer  

noweaponstest.fs2 (2,268 bytes)

Echelon9

2012-03-31 02:20

developer   ~0013427

Looks like an issue with the way in which a string or char array is initialized within the engine.

The_E

2012-04-01 14:56

administrator   ~0013435

Fix committed to trunk@8643.

niffiwan

2012-05-02 11:36

developer   ~0013506

Fix committed to fs2_open_3_6_14@8728.

Related Changesets

fs2open: trunk r8643

2012-04-01 10:57

The_E


Ported: N/A

Details Diff
Fix for Mantis 2635: Invalid memory access when saving a mission due to a weapon bank set to empty.
Affected Issues
0002635
mod - /trunk/fs2_open/code/fred2/missionsave.cpp Diff File

fs2open: fs2_open_3_6_14 r8728

2012-05-02 07:37

niffiwan


Ported: N/A

Details Diff
Backport: Trunk r8643 + r8644; Fix for Mantis 2635: Invalid memory access when saving a mission due to a weapon bank set to empty. && Same for secondary weapons Affected Issues
0002635
mod - /branches/fs2_open_3_6_14/code/fred2/missionsave.cpp Diff File

Issue History

Date Modified Username Field Change
2012-03-30 23:35 jg18 New Issue
2012-03-30 23:35 jg18 File Added: noweaponstest.fs2
2012-03-31 02:20 Echelon9 Note Added: 0013427
2012-04-01 14:56 The_E Changeset attached => fs2open trunk r8643
2012-04-01 14:56 The_E Note Added: 0013435
2012-04-01 14:56 The_E Status new => resolved
2012-04-01 14:56 The_E Resolution open => fixed
2012-05-02 11:36 niffiwan Changeset attached => fs2open fs2_open_3_6_14 r8728
2012-05-02 11:36 niffiwan Note Added: 0013506
2012-05-20 20:04 Goober5000 Assigned To => The_E
2012-11-26 01:08 Goober5000 Relationship added related to 0002735