0002627: potential data corruption in generic_anim_init

ID	Project	Category	View Status	Date Submitted	Last Update

0002627	FSSCP	graphics	public	2012-03-10 03:54	2012-03-15 09:00

Reporter	niffiwan	Assigned To	niffiwan
Priority	normal	Severity	minor	Reproducibility	always
Status	resolved	Resolution	fixed
Platform	All
Product Version	3.6.14 RC5
Target Version	3.6.14

Summary	0002627: potential data corruption in generic_anim_init
Description	This function will not perform as expected when its two input pointers point to the same location. i.e. ga->filename == filename This results in filename being memset to zero in "void generic_anim_init(generic_anim *ga)" Thus filename is lost before it can be restored to the ga structure. Fix this by saving filename to a temporary var & setting ga->filename from the temporary var
Tags	No tags attached.

fs2open: trunk r8609 2012-03-09 23:01 niffiwan Ported: N/A Details Diff	Fix for mantis 0002627: save filename to temp var in generic_anim_init	Affected Issues 0002627
	mod - /trunk/fs2_open/code/graphics/generic.cpp	Diff File
fs2open: trunk r8611 2012-03-12 02:49 Goober5000 Ported: N/A Details Diff	redo the fix for Mantis 0002627 so that we don't create temporary SCP_strings	Affected Issues 0002627
	mod - /trunk/fs2_open/code/graphics/generic.cpp	Diff File

Date Modified	Username	Field	Change
2012-03-10 03:54	niffiwan	New Issue
2012-03-10 03:54	niffiwan	Status	new => assigned
2012-03-10 03:54	niffiwan	Assigned To	=> niffiwan
2012-03-10 03:56	niffiwan	Description Updated
2012-03-10 04:01	niffiwan	Changeset attached	=> fs2open trunk r8609
2012-03-10 04:01	niffiwan	Note Added: 0013412
2012-03-10 04:01	niffiwan	Status	assigned => resolved
2012-03-10 04:01	niffiwan	Resolution	open => fixed
2012-03-12 06:48	Goober5000	Changeset attached	=> fs2open trunk r8611
2012-03-12 06:48	Goober5000	Note Added: 0013415