View Issue Details

IDProjectCategoryView StatusLast Update
0002614FSSCPmath-relatedpublic2012-05-01 12:24
ReporterEchelon9 Assigned ToValathil  
PrioritynormalSeveritytweakReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version3.6.14 RC5 
Target Version3.6.14 RC5 
Summary0002614: LLVM: Ignoring return value of function declared with const attribute - pow() in modelinterp.cpp
DescriptionLLVM warnings 'Ignoring return value of function declared with const attribute', on modelinterp.cpp within model_render_thrusters().

Relevant code is:
-----------------------
float mag = vm_vec_mag(&gpt->pnt);
pow(mag,12); <==== WARNING HERE
mag -= (float)((int)mag);//Valathil - Get a fairly random but constant number to offset the distortion texture

Issue:
-----------------------
The pow() function by itself does not modify either variable, so I believe the return value of pow() should be assigned to a variable here. cf all other uses of pow() within FSO.
TagsNo tags attached.

Activities

Valathil

2012-02-27 16:44

developer   ~0013365

Fix committed to trunk@8533.

niffiwan

2012-05-01 12:24

developer   ~0013494

Fix committed to fs2_open_3_6_14@8701.

Related Changesets

fs2open: trunk r8533

2012-02-27 11:45

Valathil


Ported: N/A

Details Diff
Fix for Mantis 2614: Remove that statement, it works fine without exponentiating the offset. Affected Issues
0002614
mod - /trunk/fs2_open/code/model/modelinterp.cpp Diff File

fs2open: fs2_open_3_6_14 r8701

2012-05-01 08:26

niffiwan


Ported: N/A

Details Diff
Backport: Trunk r8533; Fix for Mantis 2614: Remove that statement, it works fine without exponentiating the offset. Affected Issues
0002614
mod - /branches/fs2_open_3_6_14/code/model/modelinterp.cpp Diff File

Issue History

Date Modified Username Field Change
2012-02-27 13:44 Echelon9 New Issue
2012-02-27 13:44 Echelon9 Status new => assigned
2012-02-27 13:44 Echelon9 Assigned To => Valathil
2012-02-27 16:44 Valathil Changeset attached => fs2open trunk r8533
2012-02-27 16:44 Valathil Note Added: 0013365
2012-02-27 16:44 Valathil Status assigned => resolved
2012-02-27 16:44 Valathil Resolution open => fixed
2012-05-01 12:24 niffiwan Changeset attached => fs2open fs2_open_3_6_14 r8701
2012-05-01 12:24 niffiwan Note Added: 0013494