View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002614 | FSSCP | math-related | public | 2012-02-27 13:44 | 2012-05-01 12:24 |
Reporter | Echelon9 | Assigned To | Valathil | ||
Priority | normal | Severity | tweak | Reproducibility | have not tried |
Status | resolved | Resolution | fixed | ||
Product Version | 3.6.14 RC5 | ||||
Target Version | 3.6.14 RC5 | ||||
Summary | 0002614: LLVM: Ignoring return value of function declared with const attribute - pow() in modelinterp.cpp | ||||
Description | LLVM warnings 'Ignoring return value of function declared with const attribute', on modelinterp.cpp within model_render_thrusters(). Relevant code is: ----------------------- float mag = vm_vec_mag(&gpt->pnt); pow(mag,12); <==== WARNING HERE mag -= (float)((int)mag);//Valathil - Get a fairly random but constant number to offset the distortion texture Issue: ----------------------- The pow() function by itself does not modify either variable, so I believe the return value of pow() should be assigned to a variable here. cf all other uses of pow() within FSO. | ||||
Tags | No tags attached. | ||||
fs2open: trunk r8533 2012-02-27 11:45 Ported: N/A Details Diff |
Fix for Mantis 2614: Remove that statement, it works fine without exponentiating the offset. |
Affected Issues 0002614 |
|
mod - /trunk/fs2_open/code/model/modelinterp.cpp | Diff File | ||
fs2open: fs2_open_3_6_14 r8701 2012-05-01 08:26 Ported: N/A Details Diff |
Backport: Trunk r8533; Fix for Mantis 2614: Remove that statement, it works fine without exponentiating the offset. |
Affected Issues 0002614 |
|
mod - /branches/fs2_open_3_6_14/code/model/modelinterp.cpp | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-02-27 13:44 | Echelon9 | New Issue | |
2012-02-27 13:44 | Echelon9 | Status | new => assigned |
2012-02-27 13:44 | Echelon9 | Assigned To | => Valathil |
2012-02-27 16:44 | Valathil | Changeset attached | => fs2open trunk r8533 |
2012-02-27 16:44 | Valathil | Note Added: 0013365 | |
2012-02-27 16:44 | Valathil | Status | assigned => resolved |
2012-02-27 16:44 | Valathil | Resolution | open => fixed |
2012-05-01 12:24 | niffiwan | Changeset attached | => fs2open fs2_open_3_6_14 r8701 |
2012-05-01 12:24 | niffiwan | Note Added: 0013494 |