View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002470 | FSSCP | tables | public | 2011-07-12 04:53 | 2011-10-05 15:23 |
Reporter | bigchunk1 | Assigned To | niffiwan | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | 3.6.13 | ||||
Fixed in Version | 3.6.14 | ||||
Summary | 0002470: $Flags: ("untargetable") does not work on turret subsystems | ||||
Description | If you have a turret subsystem on a ship and try to add the "untargetable" flag to it in the ships.tbl, the turret will remain targetable in game. The flag will not cause any errors or warnings in debug, but will fail to work on turrets. | ||||
Additional Information | I have included a test mod for this issue. http://www.mediafire.com/?14h6gt6v5c4m4ky | ||||
Tags | No tags attached. | ||||
|
I may be wrong here, but it doesn't help when the turret you are setting to "untargetable" also happens to be loaded with a weapon, as I'm pretty sure it was not meant to work that way. AFAIR, "untargetable" (along with "damage as hull" "no aggregate" in conjunction) are to be used with -empty- turrets. |
|
But there are cases where it's desirable to have an untargetable turret that still fires weapons. Case in point.. my Construction Drone.. If this is not a bug.. then could we get it as a feature/expansion of the current flag? |
|
I was the one who implemented "untargetable", and this was just an oversight. Even though turrets are subsystems, they're treated slightly differently than bog-standard subsystems. |
|
Fix committed to trunk 7853 Note that the test mission triggers a different bug which I've mantised here: http://scp.indiegames.us/mantis/view.php?id=2513 I used the attached files to test this issue was fixed, I just swapped the untargetable Fenris for an Aten. When the patch arrives in a nightly, could you please test this with the new mission file & table? Thanks |
2011-10-03 10:40
|
|
2011-10-03 10:40
|
|
2011-10-03 10:42
|
mantis-2470.patch (868 bytes)
Index: code/hud/hudtarget.cpp =================================================================== --- code/hud/hudtarget.cpp (revision 7852) +++ code/hud/hudtarget.cpp (working copy) @@ -1694,6 +1694,10 @@ for (A=GET_FIRST(&target_shipp->subsys_list); A!=END_OF_LIST(&target_shipp->subsys_list); A=GET_NEXT(A)) { // get a turret if (A->system_info->type == SUBSYSTEM_TURRET) { + // niffiwan: ignore untargetable turrets + if ( A->flags & SSF_UNTARGETABLE ) { + continue; + } // check turret has hit points and has a weapon if ( (A->current_hits > 0) && (A->weapons.num_primary_banks > 0 || A->weapons.num_secondary_banks > 0) ) { if ( !only_player_target || (A->turret_enemy_objnum == OBJ_INDEX(Player_obj)) ) { @@ -6711,4 +6715,4 @@ } else { gr_line(fl2i(x2),fl2i(y2-1),fl2i(x5),fl2i(y5-1)); } -} \ No newline at end of file +} |
|
Here's the windows nightly: http://www.hard-light.net/forums/index.php?topic=78498.0 |
|
Tested and works as expected on my end. |
|
Thanks for testing MjnMixael |
|
Changed from closed to resolved, since that has been the de facto convention. (Fixed issues are resolved; issues that aren't fixed for whatever reason are closed.) |
Date Modified | Username | Field | Change |
---|---|---|---|
2011-07-12 04:53 | bigchunk1 | New Issue | |
2011-07-17 06:20 | Zacam | Note Added: 0012748 | |
2011-08-12 23:53 | MjnMixael | Note Added: 0012763 | |
2011-08-22 01:59 | Goober5000 | Note Added: 0012775 | |
2011-10-02 04:23 | niffiwan | Status | new => assigned |
2011-10-02 04:23 | niffiwan | Assigned To | => niffiwan |
2011-10-03 10:39 | niffiwan | Note Added: 0012876 | |
2011-10-03 10:40 | niffiwan | File Added: ufen-shp.tbm | |
2011-10-03 10:40 | niffiwan | File Added: TestBC102.fs2 | |
2011-10-03 10:40 | niffiwan | Status | assigned => feedback |
2011-10-03 10:41 | niffiwan | Note Edited: 0012876 | |
2011-10-03 10:41 | niffiwan | Note Edited: 0012876 | |
2011-10-03 10:42 | niffiwan | File Added: mantis-2470.patch | |
2011-10-03 21:39 | niffiwan | Note Added: 0012877 | |
2011-10-04 02:42 | MjnMixael | Note Added: 0012878 | |
2011-10-05 10:30 | niffiwan | Note Added: 0012881 | |
2011-10-05 10:30 | niffiwan | Status | feedback => closed |
2011-10-05 10:30 | niffiwan | Resolution | open => fixed |
2011-10-05 10:30 | niffiwan | Fixed in Version | => 3.6.14 |
2011-10-05 15:23 | Goober5000 | Note Added: 0012882 | |
2011-10-05 15:23 | Goober5000 | Status | closed => resolved |