View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002441 | FSSCP | gameplay | public | 2011-05-22 16:42 | 2012-01-23 22:56 |
| Reporter | MatthTheGeek | Assigned To | Goober5000 | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.13 | ||||
| Target Version | 3.6.14 | Fixed in Version | 3.6.14 | ||
| Summary | 0002441: "friendly-stealth-invisible" flag doesn't work | ||||
| Description | When a friendly ship uses both the "stealth" and "friendly-stealth-invisible" FRED flags (known as "Stealth" and "Invisible to Friendlies When Stealthed" in the Misc tab of the Ship editor), you can still see it correctly on the radar and target it. | ||||
| Additional Information | Reproduced with retail assets, see attachment. | ||||
| Tags | No tags attached. | ||||
| has duplicate | 0002170 | closed | Goober5000 | Friendly stealth invisible doesn't seem to work |
|
2011-05-22 16:42
|
|
|
2011-05-27 06:16
|
Mantis2441.diff (467 bytes)
Index: code/ship/awacs.cpp =================================================================== --- code/ship/awacs.cpp (revision 7210) +++ code/ship/awacs.cpp (working copy) @@ -370,7 +370,7 @@ continue; // check if ship if flagged as invisible - if (shipp->flags & SF_HIDDEN_FROM_SENSORS) + if ((shipp->flags & SF_HIDDEN_FROM_SENSORS) || (shipp->flags2 & SF2_FRIENDLY_STEALTH_INVIS)) continue; Ship_visibility_by_team[shipp->team][ship_num] = 1; |
|
|
Added fix. |
|
|
Committed to trunk in revision 7221 |
|
|
Rolling that commit back and reopening. The change made is most certainly *not* a fix. In fact, it is 90 degrees away from being a fix. |
|
|
Fix committed to trunk@8232. |
|
|
Fix committed to fs2_open_3_6_14@8251. |
|
|
Properly fixed in revision 8299. |
|
|
Fix committed to fs2_open_3_6_14@8352. |
|
fs2open: trunk r8232 2012-01-15 09:14 The_E Ported: N/A Details Diff |
Fix for Mantis 2441: "friendly-stealth-invisible" flag doesn't work |
Affected Issues 0002441 |
|
| mod - /trunk/fs2_open/code/ship/awacs.cpp | Diff File | ||
| mod - /trunk/fs2_open/code/hud/hudtarget.cpp | Diff File | ||
|
fs2open: fs2_open_3_6_14 r8251 2012-01-15 19:31 Ported: N/A Details Diff |
backport: Trunk 8232 + 8237; Fix for Mantis 2441: "friendly-stealth-invisible" flag doesn't work |
Affected Issues 0002441 |
|
| mod - /branches/fs2_open_3_6_14/code/ship/awacs.cpp | Diff File | ||
| mod - /branches/fs2_open_3_6_14/code/hud/hudtarget.cpp | Diff File | ||
|
fs2open: fs2_open_3_6_14 r8352 2012-01-23 17:56 Ported: N/A Details Diff |
Backport: Trunk 8299 + 8302; the proper way to fix Mantis 0002441 is by modifying the team_visibility_update function && follow-up to 8299: we need to check visibility for our own team in case we have a friendly-stealth-invisible ship covered by AWACS, or something\nalso, clarify terminology: in-frustum/not-in-frustum replaces visible/invisible\nand do some minor rewrites for additional clarification |
Affected Issues 0002441 |
|
| mod - /branches/fs2_open_3_6_14/code/ship/awacs.cpp | Diff File | ||
| mod - /branches/fs2_open_3_6_14/code/radar/radarsetup.cpp | Diff File | ||
| mod - /branches/fs2_open_3_6_14/code/nebula/neb.cpp | Diff File | ||
| mod - /branches/fs2_open_3_6_14/code/hud/hudtarget.cpp | Diff File | ||
| mod - /branches/fs2_open_3_6_14/code/ai/aicode.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-05-22 16:42 | MatthTheGeek | New Issue | |
| 2011-05-22 16:42 | MatthTheGeek | File Added: Stealth Test.fs2 | |
| 2011-05-27 06:16 | pyro3d | File Added: Mantis2441.diff | |
| 2011-05-27 06:16 | pyro3d | Note Added: 0012687 | |
| 2011-05-27 09:11 | The_E | Note Added: 0012688 | |
| 2011-05-27 09:11 | The_E | Status | new => resolved |
| 2011-05-27 09:11 | The_E | Fixed in Version | => 3.6.13 |
| 2011-05-27 09:11 | The_E | Resolution | open => fixed |
| 2011-05-27 09:11 | The_E | Assigned To | => The_E |
| 2011-05-29 06:55 | Goober5000 | Note Added: 0012690 | |
| 2011-05-29 06:55 | Goober5000 | Status | resolved => feedback |
| 2011-05-29 06:55 | Goober5000 | Resolution | fixed => reopened |
| 2011-05-29 06:55 | Goober5000 | Fixed in Version | 3.6.13 => |
| 2012-01-15 14:11 | Changeset attached | => fs2open trunk r8232 | |
| 2012-01-15 14:11 | guest | Note Added: 0013058 | |
| 2012-01-15 14:11 | guest | Status | feedback => resolved |
| 2012-01-16 00:28 | Zacam | Changeset attached | => fs2open fs2_open_3_6_14 r8251 |
| 2012-01-16 00:28 | Zacam | Note Added: 0013071 | |
| 2012-01-16 00:28 | Zacam | Assigned To | The_E => Zacam |
| 2012-01-22 05:23 | Goober5000 | Assigned To | Zacam => Goober5000 |
| 2012-01-22 05:23 | Goober5000 | Severity | minor => major |
| 2012-01-22 05:23 | Goober5000 | Status | resolved => confirmed |
| 2012-01-22 05:23 | Goober5000 | Category | FRED => gameplay |
| 2012-01-22 05:23 | Goober5000 | Target Version | => 3.6.14 |
| 2012-01-22 05:24 | Goober5000 | Relationship added | has duplicate 0002170 |
| 2012-01-22 05:38 | Goober5000 | Note Added: 0013101 | |
| 2012-01-22 05:38 | Goober5000 | Status | confirmed => resolved |
| 2012-01-22 05:38 | Goober5000 | Resolution | reopened => fixed |
| 2012-01-22 05:38 | Goober5000 | Fixed in Version | => 3.6.14 |
| 2012-01-23 22:56 | chief1983 | Changeset attached | => fs2open fs2_open_3_6_14 r8352 |
| 2012-01-23 22:56 | chief1983 | Note Added: 0013133 |
