View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002360 | FSSCP | user interface | public | 2010-12-22 08:57 | 2012-11-19 15:49 |
| Reporter | FUBAR-BDHR | Assigned To | Wanderer | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.13 | ||||
| Summary | 0002360: Problem in missionweaponchoice.cpp message | ||||
| Description | Not sure the exact line number but somewhere around 2907. Just do a search for unable to carry. There are 2 issues here with the same line. One is the logic is backwards resulting in the ship name not showing up in the message. The other is the operation could fail if the value of name[0] begins with 0. There is more then one occurrence and I would bet other messages have the issue as well. SVN is currently down so can't take a look at current trunk. | ||||
| Tags | No tags attached. | ||||
|
|
If I understand this correctly, the issue is the pop-up message not listing a ship name on the "Unable to Carry" dialog, which should or has previously been fixed before. Need to determine if this needs re-fixing or not depending on the scenario of this report, setting for feedback (from anybody) for 48 hours, otherwise closing. |
|
|
I think this is just FUBAR getting the wrong impression from the code rather than seeing an actual bug in the wild. First of all, \0 is the null character, not the digit 0; the code is testing to see whether the string is empty or not. Second of all, the logic is not backwards; the conditional expression intentionally displays the alt_name if it exists, and the regular class name if it does not. |
|
|
Recategorizing per FUBAR's information. It looks like this originally checked the pointer, which meant the conditional expression always printed the alt_name, even if it was blank. It was fixed in revision 7536, but never reported here. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-12-22 08:57 | FUBAR-BDHR | New Issue | |
| 2010-12-24 07:19 | FUBAR-BDHR | Status | new => assigned |
| 2010-12-24 07:19 | FUBAR-BDHR | Assigned To | => FUBAR-BDHR |
| 2012-11-19 07:06 | Zacam | Note Added: 0014064 | |
| 2012-11-19 07:06 | Zacam | Status | assigned => feedback |
| 2012-11-19 07:56 | Goober5000 | Note Added: 0014068 | |
| 2012-11-19 07:56 | Goober5000 | Assigned To | FUBAR-BDHR => Goober5000 |
| 2012-11-19 07:56 | Goober5000 | Status | feedback => closed |
| 2012-11-19 07:56 | Goober5000 | Resolution | open => no change required |
| 2012-11-19 15:49 | Goober5000 | Note Added: 0014078 | |
| 2012-11-19 15:49 | Goober5000 | Assigned To | Goober5000 => Wanderer |
| 2012-11-19 15:49 | Goober5000 | Status | closed => resolved |
| 2012-11-19 15:49 | Goober5000 | Resolution | no change required => fixed |
