View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002343 | FSSCP | gameplay | public | 2010-11-23 22:18 | 2011-11-10 12:20 |
| Reporter | FSF | Assigned To | Echelon9 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.13 | ||||
| Fixed in Version | 3.6.14 RC1 | ||||
| Summary | 0002343: Assert on arriving from destroyed ship | ||||
| Description | Transport arrives from fighterbay of a destroyed station -> assert. Tested on (today's) Nightly 6773. | ||||
| Additional Information | Attached mission (runs on retail) produces the assert 30 seconds into the mission. | ||||
| Tags | No tags attached. | ||||
|
2010-11-23 22:18
|
|
|
|
I believe the current approach is the correct one. In Release, nothing will happen. In Debug, it will Assert with the explanation that having a ship arrive from a destroyed fighterbay doesn't make much sense. Where in space would the ship be arriving from? The check has been there for some time, it looks like previously we weren't setting the P_SF_CANNOT_ARRIVE flag on destroyed objects. Just because it is in Retail doesn't make it necessarily correct. |
|
|
Well, asserts are always kinda hard to interpret. Something like "Warning: <ship name> cannot depart from <ship name> fighterbay" would be more useful. |
|
|
Actually, an assert or warning popup would be wrong here. All that is warranted is a mention in the log (Ship X was set to arrive from bay Y on object Z, but Z doesn't exist anymore), as a mission designer might want to set it up that something like this might happen (imagine a scenario where you're escorting a bunch of non-critical ships that launch reinforcements after some time). |
|
|
I agree, in this circumstance a mention in the log is all that should occur in Debug; and no event in Release. |
|
|
For reference: still asserts on 3.6.14 RC1. |
|
|
Thanks for reminding me I had the patch sitting on my laptop. Fix committed to r7971. If one of the good build maintainers approvers, it'll be in RC2. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-11-23 22:18 | FSF | New Issue | |
| 2010-11-23 22:18 | FSF | File Added: Test_arv.fs2 | |
| 2010-11-29 14:27 | Echelon9 | Note Added: 0012492 | |
| 2010-11-29 14:27 | Echelon9 | Status | new => feedback |
| 2010-11-29 14:27 | Echelon9 | Status | feedback => assigned |
| 2010-11-29 14:27 | Echelon9 | Assigned To | => Echelon9 |
| 2010-11-29 19:18 | FSF | Note Added: 0012493 | |
| 2010-11-30 07:27 | The_E | Note Added: 0012494 | |
| 2010-11-30 13:16 | Echelon9 | Note Added: 0012495 | |
| 2011-06-24 04:47 | Zacam | Category | --------- => gameplay |
| 2011-11-10 09:38 | FSF | Note Added: 0012949 | |
| 2011-11-10 12:20 | Echelon9 | Note Added: 0012950 | |
| 2011-11-10 12:20 | Echelon9 | Status | assigned => resolved |
| 2011-11-10 12:20 | Echelon9 | Fixed in Version | => 3.6.14 RC1 |
| 2011-11-10 12:20 | Echelon9 | Resolution | open => fixed |
