View Issue Details

IDProjectCategoryView StatusLast Update
0002293FSSCPHUDpublic2013-02-16 20:16
ReporterDroid803 Assigned ToAdmiral MS  
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionreopened 
Product Version3.6.13 
Summary0002293: Destroyed/departed AI showing up as present in wingmen display.
DescriptionSemi-random, but happens fairly regularly when wingmen depart, more often than when they're destroyed in combat.

When wingmen are destroyed/depart, the wingmen display (ie, the Alpha through Epsilon wing "dots") sometimes still shows them as being present. That is, the dot remains filled in when it should be blanked because they have either departed or been destroyed.
TagsNo tags attached.

Activities

MjnMixael

2012-07-02 16:33

manager   ~0013798

I remember experiencing this issue on 3.6.12. It always seemed to occur when a lot of your wingmen would be destroyed or warp out at the same time.

I tested with the attached mission multiple times and couldn't reproduce.

MjnMixael

2012-07-02 16:33

manager  

WingmanDisplayTest.fs2 (17,452 bytes)

Goober5000

2012-07-02 16:54

administrator   ~0013800

Assuming it no longer occurs then. Someone can reopen if that's not the case.

Goober5000

2013-02-12 04:23

administrator   ~0014706

Reopening per Yarn.

Yarn

2013-02-12 04:25

developer   ~0014707

I think I figured out how to reproduce the bug. It appears to happen only if time compression is set to x4 or higher. It happens randomly, but the higher the time compression, the more likely it is to happen. At x16 compression and higher, it almost always occurs.

This seems to happen only with departed wingmen, never destroyed wingmen. It also doesn't seem to matter how many wingmen are involved; it can happen even if only one wingman departs.

When it does happen, the wingmen in question do appear in the event log as departed, and SEXPs triggered by their departure are still triggered. So this appears to be strictly a HUD issue.

This happens as far back as 3.6.10 and possibly earlier, so this is certainly not a recent bug.

Admiral MS

2013-02-15 23:57

developer  

2293.patch (558 bytes)   
Index: code/hud/hudwingmanstatus.cpp
===================================================================
--- code/hud/hudwingmanstatus.cpp	(revision 9532)
+++ code/hud/hudwingmanstatus.cpp	(working copy)
@@ -189,7 +189,7 @@
 			wing_index = shipp->wing_status_wing_index;
 			wing_pos = shipp->wing_status_wing_pos;
 
-			if ( (wing_index >= 0) && (wing_pos >= 0) ) {
+			if ( (wing_index >= 0) && (wing_pos >= 0) && !(ship_objp->flags & OF_SHOULD_BE_DEAD) ) {
 
 				HUD_wingman_status[wing_index].used = 1;
 				if (!(shipp->flags & SF_DEPARTING) ) {
2293.patch (558 bytes)   

Admiral MS

2013-02-16 00:03

developer   ~0014711

Added a patch. Bug is mostly hidden during normal gameplay without time compression because of a timer in the update function that is based on gametime.

The_E

2013-02-16 20:16

administrator   ~0014717

Fix committed to trunk@9535.

Related Changesets

fs2open: trunk r9535

2013-02-16 15:56

The_E


Ported: N/A

Details Diff
From AMS: Fix for Mantis 2293: Destroyed/departed AI showing up as present in wingmen display. Affected Issues
0002293
mod - /trunk/fs2_open/code/hud/hudwingmanstatus.cpp Diff File

Issue History

Date Modified Username Field Change
2010-08-22 00:27 Droid803 New Issue
2012-07-02 16:33 MjnMixael Note Added: 0013798
2012-07-02 16:33 MjnMixael File Added: WingmanDisplayTest.fs2
2012-07-02 16:54 Goober5000 Note Added: 0013800
2012-07-02 16:54 Goober5000 Assigned To => Goober5000
2012-07-02 16:54 Goober5000 Status new => closed
2012-07-02 16:54 Goober5000 Resolution open => unable to reproduce
2013-02-12 04:23 Goober5000 Note Added: 0014706
2013-02-12 04:23 Goober5000 Assigned To Goober5000 =>
2013-02-12 04:23 Goober5000 Status closed => confirmed
2013-02-12 04:23 Goober5000 Resolution unable to reproduce => reopened
2013-02-12 04:25 Yarn Note Added: 0014707
2013-02-15 23:57 Admiral MS File Added: 2293.patch
2013-02-15 23:58 Admiral MS Assigned To => Admiral MS
2013-02-15 23:58 Admiral MS Status confirmed => assigned
2013-02-16 00:03 Admiral MS Note Added: 0014711
2013-02-16 00:04 Admiral MS Status assigned => code review
2013-02-16 20:16 The_E Changeset attached => fs2open trunk r9535
2013-02-16 20:16 The_E Note Added: 0014717
2013-02-16 20:16 The_E Status code review => resolved