|
2010-07-19 05:48
|
mainhallerror.jpg (102,506 bytes) |
|
|
Galemp, we have png support and animated eff. Those two things both involved some significant rewrites in those areas of the code, so we do need to get any bugs in those areas sorted out asap. |
|
2010-07-22 13:43
|
mainhallani.patch (434 bytes) |
|
|
Found the cause. Before the ani/eff rewrite, there was a hack in there that would play misc ani 3 first, and then all the others. In other words, this was caused by the engine working correctly. The attached patch switches the rendering order around, so that the last misc ani is rendered first; but it seems to me as if this is more of a data issue than an engine one. |
|
|
Unless we can fix that data, we're gonna have to keep supporting the hack. |
|
|
I strongly disagree. We're supposed to reduce the number of stupid compatibility hacks for broken data, not keep supporting them ad infinitum. The problem is, if we keep supporting it, it would cause bugs once the data is fixed (as the rendering would once again be broken). I'd rather the data was fixed, really. And since it's not like we need to change retail data, I don't quite see the problem. |
|
|
Well, often we can't get rid of hacks without breaking retail support. But since this wasn't a bug in FS2 retail data that makes it somewhat interesting. |
|
|
What exactly needs to be fixed in the data? Is every mod gonna have to go and edit all the Main Halls and change the order of the animations from the defaults? That doesn't sound optimal. Is 'hacking' the code to play Misc Ani 3 first going to break anything or frustrate anyone? |
|
|
It frustrates me, because it's something that is severely unintuitive. Rendering the animations in normal order, that is 1, 2, 3, 4, that's simple to explain and easy to take advantage of. Rendering them in stupid order, that is 3, 1, 2, 4, is just a stupid, stupid hack that never should have been needed in the first place. In order to get the correct layering, you need to make sure that what is now misc anim 3 is rendered before what is now misc anim 1. Swapping those two should fix the problem quite easily. In addition, the only mod that would be broken by this change is the FSPort. Correct me if I'm wrong, but I don't know of any other mod that uses layered mainhall anis. |
|
|
Have a look at the thread in the HPC forum: http://www.hard-light.net/forums/index.php?topic=70512.0 If we simply moved the main2-m3 entry (along with its coordinates) to the top of the list of animations in mainhall.tbl, hopefully that should fix the issue. I can't test it right now though. |
|
|
Closing this, as it is a data issue that should be handled by the modders. |
- Anonymous
