View Issue Details

IDProjectCategoryView StatusLast Update
0002200FSSCPuser interfacepublic2012-12-08 19:51
ReporterGalemp Assigned ToEli2  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0002200: Briefing Icons do not fade properly
DescriptionMission briefing icons fade in just fine, but they no longer transition smoothly to their 'fade' version when fading out. They appear to shrink 50% and then vanish.
Additional InformationTested on FS2 3.6.12 RC2 Inferno, with retail data and with FSPort MVPs.
TagsNo tags attached.

Activities

Galemp

2010-05-04 15:34

reporter   ~0011936

...did I file this on wxFRED? whoops.

MjnMixael

2012-12-06 04:13

manager   ~0014324

Last edited: 2012-12-06 04:17

I've reproduced the issue. I'm attaching two screenshots. They are actually frames from the video below where the icons "jump" to their fade variants. (Briefing icons have two separate files, a normal and a fade.)

The jump is basically showing that the fade icons are not being stretched to fill widescreen resolutions like the regular icons are.

https://www.youtube.com/watch?v=Zg37kAGUf6E

Use the test mission to reproduce easily.

MjnMixael

2012-12-06 04:13

manager  

briefingtest.fs2 (5,108 bytes)

MjnMixael

2012-12-06 04:13

manager  

Image1.jpg (216,867 bytes)   
Image1.jpg (216,867 bytes)   

MjnMixael

2012-12-06 04:14

manager  

Image2.jpg (215,520 bytes)   
Image2.jpg (215,520 bytes)   

Eli2

2012-12-08 00:58

developer  

mantis2200.svn.patch (1,062 bytes)   
diff --git a/code/mission/missionbriefcommon.cpp b/code/mission/missionbriefcommon.cpp
index 737aa71..b766bc9 100644
Index: code/mission/missionbriefcommon.cpp
===================================================================
--- code/mission/missionbriefcommon.cpp
+++ code/mission/missionbriefcommon.cpp
@@ -774,18 +774,19 @@ void brief_render_fade_outs(float frametime)
 			}
 
 			bm_get_info( fi->fade_anim.first_frame, &w, &h, NULL);
+			float screenX = tv.screen.xyw.x;
+			float screenY = tv.screen.xyw.y;
+			gr_unsize_screen_posf( &screenX, &screenY );
 
-			gr_resize_screen_pos( &w, &h );
-
-			bxf = tv.screen.xyw.x - w / 2.0f + 0.5f;
-			byf = tv.screen.xyw.y - h / 2.0f + 0.5f;
+			bxf = screenX - w / 2.0f + 0.5f;
+			byf = screenY - h / 2.0f + 0.5f;
 			bx = fl2i(bxf);
 			by = fl2i(byf);
 
 			if ( fi->fade_anim.first_frame >= 0 ) {
 				fi->fade_anim.sx = bx;
 				fi->fade_anim.sy = by;
-				hud_anim_render(&fi->fade_anim, frametime, 1, 0, 0, 0, false);
+				hud_anim_render(&fi->fade_anim, frametime, 1, 0, 0, 0, true);
 			}
 		}
 	}

mantis2200.svn.patch (1,062 bytes)   

Eli2

2012-12-08 00:59

developer   ~0014353

Attached fix.

MjnMixael

2012-12-08 07:16

manager   ~0014354

Tested and it works as expected!

Issue History

Date Modified Username Field Change
2010-05-04 15:33 Galemp New Issue
2010-05-04 15:34 Galemp Note Added: 0011936
2010-05-04 15:39 Goober5000 Project wxFRED => FSSCP
2011-06-24 04:38 Zacam Category => user interface
2012-12-06 04:13 MjnMixael Note Added: 0014324
2012-12-06 04:13 MjnMixael File Added: briefingtest.fs2
2012-12-06 04:13 MjnMixael File Added: Image1.jpg
2012-12-06 04:14 MjnMixael File Added: Image2.jpg
2012-12-06 04:17 MjnMixael Note Edited: 0014324
2012-12-08 00:51 Eli2 Assigned To => Eli2
2012-12-08 00:51 Eli2 Status new => assigned
2012-12-08 00:58 Eli2 File Added: mantis2200.svn.patch
2012-12-08 00:59 Eli2 Note Added: 0014353
2012-12-08 00:59 Eli2 Status assigned => feedback
2012-12-08 07:16 MjnMixael Note Added: 0014354
2012-12-08 19:51 The_E Status feedback => resolved
2012-12-08 19:51 The_E Resolution open => fixed