View Issue Details

IDProjectCategoryView StatusLast Update
0002021FSSCPFREDpublic2009-11-23 23:15
ReporterFUBAR-BDHR Assigned ToGoober5000  
PrioritynormalSeveritytrivialReproducibilityhave not tried
Status closedResolutionno change required 
Product Version3.6.11 
Summary0002021: Repeat count not reset when event is changed from repeating to everytime
DescriptionJust changed an event with a repeat count to everytime and it left the repeat count instead of setting it to 1 and disabling the option as it does when there is no repeat count. Manually changing the repeat count back to 1 resulted in the option being greyed out.
Additional Information3.6.11 r5640
TagsNo tags attached.

Activities

Goober5000

2009-11-13 06:57

administrator   ~0011255

Huh? Screenshot or something please.

2009-11-13 07:41

 

2021a.jpg (138,785 bytes)   
2021a.jpg (138,785 bytes)   

FUBAR-BDHR

2009-11-13 07:42

developer   ~0011256

Repeat count and interval are useless for every-time so they should be set and/or locked.

Goober5000

2009-11-13 07:59

administrator   ~0011257

For the umpteenth time, the every-time sexp is NOT equivalent to an infinite repeat. It's a very specialized sexp that should be used extremely rarely. It's also a completely different concept to the repeat count -- if you're using every-time when you should be using repeat instead, then "ur doing it wrong", to coin a phrase.

Furthermore, repeat count affects the whole sexp, whereas every-time only affects a node tree. Suppose you have something like this:

when
--some temporary condition
--do some stuff
--do some other stuff
--every-time
----do some specialized stuff

Repeat might be necessary to continually check that temporary condition. Now granted this is an extremely unlikely edge case, but it illustrates the fact that the two concepts are not the same.

FUBAR-BDHR

2009-11-13 08:38

developer   ~0011262

I realize that and the only reason I am using ever-time is that a repeating when either with a trigger or repeat count is not reevaluating the conditions for this particular event. Every-time does that. Believe me I don't want to use every-time but am forced to in this particular instance.

The thin is that when ever-time is the root of the event the other options are meaningless and just letting them be changed is misleading.

Goober5000

2009-11-23 23:15

administrator   ~0011330

If it's misleading, the FREDder shouldn't be using that sexp. As I said, repeat count and every-time are two totally different concepts. We've been saying for a while now that FREDders shouldn't be using every-time unless they have a very good reason.

Furthermore, in the most recent mission I FREDded (for SA) I *did* use every-time in a repeating event. It wasn't in the root node, but it was part of the sexp and it served a very important function. So if we change the behavior here, it will confuse the issue for people who *actually know what they're doing*.

I'm closing this as "no change required".

Issue History

Date Modified Username Field Change
2009-11-08 07:07 FUBAR-BDHR New Issue
2009-11-13 06:57 Goober5000 Note Added: 0011255
2009-11-13 07:41 FUBAR-BDHR File Added: 2021a.jpg
2009-11-13 07:42 FUBAR-BDHR Note Added: 0011256
2009-11-13 07:59 Goober5000 Note Added: 0011257
2009-11-13 07:59 Goober5000 Status new => assigned
2009-11-13 07:59 Goober5000 Assigned To => Goober5000
2009-11-13 08:38 FUBAR-BDHR Note Added: 0011262
2009-11-23 23:15 Goober5000 Note Added: 0011330
2009-11-23 23:15 Goober5000 Status assigned => closed
2009-11-23 23:15 Goober5000 Resolution open => no change required