View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001990 | FSSCP | graphics | public | 2009-09-11 09:53 | 2009-12-21 11:31 |
| Reporter | FUBAR-BDHR | Assigned To | Hery | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.11 | ||||
| Fixed in Version | 3.6.11 | ||||
| Summary | 0001990: Unable to release environment map render target | ||||
| Description | Basically this happens if you play certain missions after each other. Seemed pretty random but I have been able to reproduce it every time in a TBP campaign. FH2260 intro followed by M1. As soon as M1 starts loading this warning pops up. Attaching fs2_open.log and call stack. Kara walked me through getting additional info. I put a breakpoint at 3488 of freespace.cpp. clear_render_targets is 1 at line 1711 in bmpman.cpp but the expression still evaluates to true resulting in 0 being returned. | ||||
| Additional Information | 3.6.11 r5591. I've seen it in other mods besides TBP as well. Will happen playing missions from the tech room as well as campaigns. | ||||
| Tags | No tags attached. | ||||
|
2009-09-11 09:53
|
|
|
|
Almost forgot. be->type = 17 at line 1711 as well. |
|
2009-12-19 00:46
|
1990_render_targets.patch (608 bytes)
Index: code/bmpman/bmpman.cpp
===================================================================
--- code/bmpman/bmpman.cpp (revision 5726)
+++ code/bmpman/bmpman.cpp (working copy)
@@ -1769,7 +1769,7 @@
Assert( be->handle == handle ); // INVALID BITMAP HANDLE
- if ( !clear_render_targets && (be->type == BM_TYPE_RENDER_TARGET_STATIC) || (be->type == BM_TYPE_RENDER_TARGET_DYNAMIC) ) {
+ if ( !clear_render_targets && ((be->type == BM_TYPE_RENDER_TARGET_STATIC) || (be->type == BM_TYPE_RENDER_TARGET_DYNAMIC)) ) {
nprintf(("BmpMan", "Tried to release a render target!\n"));
return 0;
}
|
|
|
Apparently, there was a mistake in check whether it is possible to release render target. Patch attached. |
|
|
Patch committed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-09-11 09:53 | FUBAR-BDHR | New Issue | |
| 2009-09-11 09:53 | FUBAR-BDHR | File Added: MRT.rar | |
| 2009-09-11 09:55 | FUBAR-BDHR | Note Added: 0011174 | |
| 2009-11-17 17:14 | Hery | Status | new => assigned |
| 2009-11-17 17:14 | Hery | Assigned To | => Hery |
| 2009-12-19 00:46 | Hery | File Added: 1990_render_targets.patch | |
| 2009-12-19 00:47 | Hery | Note Added: 0011442 | |
| 2009-12-21 11:31 | Hery | Note Added: 0011453 | |
| 2009-12-21 11:31 | Hery | Status | assigned => resolved |
| 2009-12-21 11:31 | Hery | Fixed in Version | => 3.6.11 |
| 2009-12-21 11:31 | Hery | Resolution | open => fixed |
