View Issue Details

IDProjectCategoryView StatusLast Update
0001964FSSCPtablespublic2009-08-23 09:46
Reporterchief1983 Assigned ToWanderer  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.6.11 
Summary0001964: ship_set_default_weapons() contains hardcoded retail weapon names
DescriptionSo a change_ship_type() call leads to ship_set_default_weapons() being called. When there are more banks on the ship than the table defines, it tries to fill the holes with Light Lasers and Rockeyes via:

// Make unspecified weapon for bank be a Light Laser
swp->primary_bank_weapons[i] = weapon_info_lookup(NOX("Light Laser"));

and

// Make unspecified weapon for bank be a Rockeye Missile
swp->secondary_bank_weapons[i] = weapon_info_lookup(NOX("Rockeye Missile"));

We already have a player weapon precedence table, shouldn't it go through that in order and pick the first one by some more intelligent means?
TagsNo tags attached.

Activities

Wanderer

2009-08-23 09:46

developer   ~0011153

Should now be fixed in trunk

Issue History

Date Modified Username Field Change
2009-07-16 23:38 chief1983 New Issue
2009-08-23 09:46 Wanderer Status new => resolved
2009-08-23 09:46 Wanderer Resolution open => fixed
2009-08-23 09:46 Wanderer Assigned To => Wanderer
2009-08-23 09:46 Wanderer Note Added: 0011153