View Issue Details

IDProjectCategoryView StatusLast Update
0001959FSSCPgraphicspublic2009-07-16 14:55
ReporterTolwyn Assigned Tochief1983  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.6.11 
Summary0001959: 2d/3d shockwave detection code not working properly
DescriptionThis was introduced after there was a decision to go back to 2D shockwave by the FSU team. As far as I understand it: 2D shockwave became mandatory, while 3D shockwave can still be enabled via launcher. Now, this breaks existing TCs, that rely only on the 3D shockwave.

I believe chief submitted a fix, that would on startup check if 2D shockwace is present and, if none is detected, default to 3D shockwave. Me *thinks* that the fix worked. At the moment, however, it is not getting its job done as the game would crash on startup, complaining about missing data.
TagsNo tags attached.

Activities

Tolwyn

2009-07-09 21:56

reporter   ~0011071

I take this one back. fs2_open_3_6_11r-20090706_r5411.exe works perfectly. It did not work in earlier revisions though. Maybe I am just getting senile.

chief1983

2009-07-10 19:21

administrator   ~0011073

Closed.

Tolwyn

2009-07-11 13:56

reporter   ~0011074

Okay ,I take it back. It still doesn't work. I was under the impression that the game crashed on startup, which is why I did not investigate further. It crashes on mission load with the following error message:

Error: Unable to load 2D shockwave 'shockwave01'!

File: shockwave.cpp
Line: 510


Call stack:
------------------------------------------------------------------
------------------------------------------------------------------

chief1983

2009-07-13 00:12

administrator   ~0011076

This shockwave code doesn't even work the way the person who originally wrote it intended for it to work. It checks a return value for a function that will never be hit because the call to ERROR prevents that. Disabling the call to ERROR causes a later Assert to be hit no matter what, as soon as it tries to load a file that doesn't exist. And checking to see if the 2d shockwave file exists doesn't appear to work either unless I'm doing it wrong, but I can't see how. Frustrated...

chief1983

2009-07-13 01:20

administrator   ~0011077

Tried another attempt at fixing this now. Should be fixed in r5432. Nightly build will be out sometime tomorrow.

Tolwyn

2009-07-16 11:11

reporter   ~0011088

Seems to be fixed now.

chief1983

2009-07-16 14:55

administrator   ~0011089

Yay closed again.

Issue History

Date Modified Username Field Change
2009-07-09 11:18 Tolwyn New Issue
2009-07-09 21:56 Tolwyn Note Added: 0011071
2009-07-10 19:21 chief1983 Note Added: 0011073
2009-07-10 19:21 chief1983 Assigned To => chief1983
2009-07-10 19:21 chief1983 Status new => closed
2009-07-10 19:21 chief1983 Resolution open => no change required
2009-07-10 19:21 chief1983 Product Version => 3.6.11
2009-07-11 13:56 Tolwyn Status closed => feedback
2009-07-11 13:56 Tolwyn Resolution no change required => reopened
2009-07-11 13:56 Tolwyn Note Added: 0011074
2009-07-13 00:12 chief1983 Note Added: 0011076
2009-07-13 01:20 chief1983 Note Added: 0011077
2009-07-16 11:11 Tolwyn Note Added: 0011088
2009-07-16 14:55 chief1983 Note Added: 0011089
2009-07-16 14:55 chief1983 Status feedback => resolved
2009-07-16 14:55 chief1983 Resolution reopened => fixed