View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001959 | FSSCP | graphics | public | 2009-07-09 11:18 | 2009-07-16 14:55 |
| Reporter | Tolwyn | Assigned To | chief1983 | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.11 | ||||
| Summary | 0001959: 2d/3d shockwave detection code not working properly | ||||
| Description | This was introduced after there was a decision to go back to 2D shockwave by the FSU team. As far as I understand it: 2D shockwave became mandatory, while 3D shockwave can still be enabled via launcher. Now, this breaks existing TCs, that rely only on the 3D shockwave. I believe chief submitted a fix, that would on startup check if 2D shockwace is present and, if none is detected, default to 3D shockwave. Me *thinks* that the fix worked. At the moment, however, it is not getting its job done as the game would crash on startup, complaining about missing data. | ||||
| Tags | No tags attached. | ||||
|
|
I take this one back. fs2_open_3_6_11r-20090706_r5411.exe works perfectly. It did not work in earlier revisions though. Maybe I am just getting senile. |
|
|
Closed. |
|
|
Okay ,I take it back. It still doesn't work. I was under the impression that the game crashed on startup, which is why I did not investigate further. It crashes on mission load with the following error message: Error: Unable to load 2D shockwave 'shockwave01'! File: shockwave.cpp Line: 510 Call stack: ------------------------------------------------------------------ ------------------------------------------------------------------ |
|
|
This shockwave code doesn't even work the way the person who originally wrote it intended for it to work. It checks a return value for a function that will never be hit because the call to ERROR prevents that. Disabling the call to ERROR causes a later Assert to be hit no matter what, as soon as it tries to load a file that doesn't exist. And checking to see if the 2d shockwave file exists doesn't appear to work either unless I'm doing it wrong, but I can't see how. Frustrated... |
|
|
Tried another attempt at fixing this now. Should be fixed in r5432. Nightly build will be out sometime tomorrow. |
|
|
Seems to be fixed now. |
|
|
Yay closed again. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-07-09 11:18 | Tolwyn | New Issue | |
| 2009-07-09 21:56 | Tolwyn | Note Added: 0011071 | |
| 2009-07-10 19:21 | chief1983 | Note Added: 0011073 | |
| 2009-07-10 19:21 | chief1983 | Assigned To | => chief1983 |
| 2009-07-10 19:21 | chief1983 | Status | new => closed |
| 2009-07-10 19:21 | chief1983 | Resolution | open => no change required |
| 2009-07-10 19:21 | chief1983 | Product Version | => 3.6.11 |
| 2009-07-11 13:56 | Tolwyn | Status | closed => feedback |
| 2009-07-11 13:56 | Tolwyn | Resolution | no change required => reopened |
| 2009-07-11 13:56 | Tolwyn | Note Added: 0011074 | |
| 2009-07-13 00:12 | chief1983 | Note Added: 0011076 | |
| 2009-07-13 01:20 | chief1983 | Note Added: 0011077 | |
| 2009-07-16 11:11 | Tolwyn | Note Added: 0011088 | |
| 2009-07-16 14:55 | chief1983 | Note Added: 0011089 | |
| 2009-07-16 14:55 | chief1983 | Status | feedback => resolved |
| 2009-07-16 14:55 | chief1983 | Resolution | reopened => fixed |