|
2009-05-25 07:08
|
text_replace1.jpg (104,082 bytes) |
|
2009-05-25 07:09
|
text_replace2.jpg (147,427 bytes) |
|
|
Well this one is a little deeper then I though. Couldn't reproduce with retail data. Also couldn't reproduce with some TBP models. B5 and the EA explorer both exhibit the problem so it is reproducible with more then one model. Both models have both shine and glow maps as well as debris textures. First pic shows the PCS2 texture order as well as where texture rotation6a is.. Second shows what happened when I tried to replace rotation6a with the asteroid texture. The .fs2 file saved it as: $Texture Replace: +old: b5rotation1a-shine +new: asteroid01a Which is 3 textures in the sorted FRED list above rotation6a. Interestingly enough there are 3 glow textures in the list. All 3 are above rotation6a in the unsorted list. |
|
2009-05-30 04:55
|
texreplace_prob.jpg (182,862 bytes) |
|
|
Just uploaded another screenshot. The first ship with the Patton name plate was previously the only ship in the mission (besides Alpha 1) and had texture replacement that was fixed in notepad. Loaded the mission and added 4 more Novas. Didn't do anything else but you can see they all have missing textures. Saved the mission and checked it in notepad. It was correct and the texture replacement for the Patton did not change. Other 4 had no texture replacement as they should. |
|
|
Is this still an issue? I didn't run into any such problems when I was working on 0002340. |
|
|
Tested 1 part and it still exists. Replaced texture b5rotation6a with asteroid01a just like in the screenshot above. Saved mission. FRED still shows b5rotation6a replaced but in notepad there is this: $Texture Replace: +old: b5rotation1a-shine +new: asteroid01a I think there are a few factors in reproducing this. First you need a model where the textures aren't in alphabetical order in PCS2. Second you need one that has "missing" maps. By missing I mean things like -glow -shine don't exist for some textures but do for others. So if you have a model with textures a.dds, b.dds, and c.dds where a has -glow, -shine, -normal, b only has -glow, and c only has -glow and -shine you should be able to repo this. I believe there are 2 things happening. First is with the sort order and second is with the routine assuming that all map types (probably all map types used previously on the model) will exist for every map on the model. I'll see if I can come up with something in retail that can make this happen. |
|
|
Can't find anything retail but the 3.6.12 mediavp Arcidia can reproduce issues. Just add one to FRED and start replacing textures and looking at the mission in notepad. It seems more random then using b5 so I haven't figured out a single texture that will cause the issue yet. Also I found another issue where the missing texture warning will pop up for valid textures the second time. I replaced texture cruisertile5 with asteroid01 as a first test. No warning. That didn't trigger the issue so I tried replacing a different texture with asteroid02a which triggered a warning as I assume there is no asteroid02a. I then changed it to asteroid01a and received 2 warnings that asteroid01a doesn't exist which it does. |
|
|
Okay, well I just tried the mediaVPs Arcadia and the textures appeared exactly as expected. |
|
|
Alright here is one with that is reproducible every time. Start FRED, drop in Arcadia, texture replace install01-06 with asteroid01a. Save mission. Delete Arcadia. Add Arcadia. Go to texture replacement and look at install01-06. Save mission. Notice that the texture replacement is in the .fs2 file. |
|
|
Another one. Place Arcadia. Texture replace instal01-06 and install01-07 with asteroid01a. Save mission. Select Arcadia and texture replace install01-01c with asteroid01a. Save mission. Check the .fs2 file and you should see: $Texture Replace: +old: install01-01-glow +new: asteroid01a +old: install01-06 +new: asteroid01a +old: install01-07 +new: asteroid01a |
|
|
I wonder if you have the same Arcadia as I do. The mediaVPs one doesn't have the install01-06 and install01-07 textures; instead it has arcadia_01, etc. And the retail one has install01-06a, etc., not install01-06. (Note the a.) Anyway, I followed your instructions and the only thing I noticed was that the texture replacements for "GTI Arcadia 1" carried over to the next ship called "GTI Arcadia 1" after I deleted and recreated it. That's because the texture replacement is assigned by name in FRED, and the two ships had the same name. But by the same token, since it was the "same" ship, just deleted and recreated, I'm not convinced it's an actual bug. As for your second example, that one worked just fine for me, and I didn't see the results you reported. |
|
|
I am testing on the one from the 3.6.12 mediavps. Testing on retail doesn't work as there are no shine, glow, or normal maps. |
|
|
Okay, I figured out what my mod problem was. I was able to reproduce both tests. |
|
|
I've attached a patch that should fix the remaining issues (since "invisible" support was re-reported as 2340 and fixed by r9444). |
|
|
Patch looks reasonable, but I merely did a test merge and skimmed it. What tests did you do to verify that this was fixed? |
|
|
On IRC I saw Axem report that this patch fixed the issue in the related ticket (0003145) |
|
|
1929.patch (2,086 bytes) |
|
|
Apparently that particular patch file got made before I'd compiled it, because it was missing a semicolon that is required for it to compile; I must've forgotten to remake the patch file afterwards. Fixed. |
|
|
Well I don't think we're going to get any additional opinions. :) If you're satisfied the patch fixes the issues you noticed, then go ahead and commit it. |
|
|
Fix committed to trunk@11274. |
- Anonymous
