View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001887 | FSSCP | FRED | public | 2009-02-23 07:20 | 2010-05-19 06:07 |
| Reporter | FUBAR-BDHR | Assigned To | FSO 4 | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | suspended | ||
| Product Version | 3.6.9 | ||||
| Summary | 0001887: Is-event-true updates argument if wing name is changed | ||||
| Description | Couldn't figure out how to even summarize this one. Basically doing some wing renaming (without the event editor open this time). There are events name the same as the wings and the wings arrival cue is set to is-event-true <wing name>. Example Alpha wing has an arrival of is-event-true Alpha. Now when I changed the wing name it updated the arrival cue so it was pointing to an event that now does not exist. | ||||
| Additional Information | FRED 3.6.10 r5063. To recreate toss a couple of ships in FRED and make them wing Beta. Open the event editor and create an event called Beta. Close the event editor. Open the wing editor and set the arrival cue for Beta to is-event-true Beta. Change the wing name to Gamma, exit the wing editor, and hit the error checker. You should get an error in arrival cue message box. | ||||
| Tags | No tags attached. | ||||
|
|
This is caused by wing_editor::update_data() calling update_sexp_references() Since there is no easy way for update_sexp_references() to tell apart an event name from a ship name the best I can do is fix this at the other end and make FRED give you a warning if you try to name an event (or message for that matter) after an existing ship name. Since I don't particularly want a whole host of debug messages appearing for existing messages I think the smartest thing to do is make it warn only when you rename an event to the same name as an existing ship. I suspect Mantis 1449 is also related to this. |
|
|
This is by design. The update code runs through all the sexps and renames all the names to *what it thinks they should be*. But the Volition coders weren't 100% sure the updater would get it right all the time, so they put it in brackets. I strongly recommend leaving it alone. The updater should be re-engineered so that it *can* tell the type of sexp argument, but that's probably a task for wxFRED. |
|
|
Yeah, I wasn't planning on touching update_sexp_references() or update_data(). I was saying that the only solution I was willing to contemplate was having the Event rename function quickly check if there were any ships or wings with the same name you just entered for the event and warning that using this name might cause problems due to the match. It's not a great solution (basically it's telling people off for entering a legal name cause it causes a bug) but it does have the side effect of social engineering more sensible event names. Cause naming an event with the exact same name as a ship is pretty silly to start with. :p |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-02-23 07:20 | FUBAR-BDHR | New Issue | |
| 2009-04-01 21:37 | karajorma | Note Added: 0010790 | |
| 2009-04-22 17:21 | Goober5000 | Note Added: 0010818 | |
| 2009-04-22 17:23 | Goober5000 | Assigned To | => FSO 4 |
| 2009-04-22 17:23 | Goober5000 | Status | new => confirmed |
| 2009-04-22 17:23 | Goober5000 | Resolution | open => suspended |
| 2009-04-22 17:26 | karajorma | Note Added: 0010819 | |
| 2009-04-24 16:41 | karajorma | Relationship added | related to 0001449 |
| 2010-05-19 06:07 | Goober5000 | Status | confirmed => closed |
