View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001843 | FSSCP | user interface | public | 2008-12-10 19:54 | 2008-12-14 16:04 |
| Reporter | Joshua | Assigned To | phreak | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | open | ||
| Product Version | 3.6.9 | ||||
| Summary | 0001843: MIssion skipping sorta screwed. | ||||
| Description | I failed "Slaying Ravana" 10 times (My first time on Hard), and eventually managed to get it right. However, during my mission fail spree, the message box that said "You have failed this mission 5 times, do you want to skip it?" showed up. I clicked "do not show this again". Then, on the next mission, I was shotdown by the Hawkwood. Then, the "You have failed this mission 5 times, do you want to skip?" showed up, although, as you can see, have only failed the mission once. | ||||
| Additional Information | I am using the Nightly build from 6 december | ||||
| Tags | No tags attached. | ||||
|
|
See attached (potential-fix-mantis-1843.diff) for a proposed patch against r4994 trunk. It adds into mission_campaign_mission_over() in missioncampaign.cpp the line "Player->failures_this_session = 0;" to ensure that Player->failures_this_session equals 0 at the start of a new mission. Currently, my reading of the code would be that FS2_Open only resets the Player->failures_this_session to be 0 if the user chooses to skip the mission, but not if the offer is declined and the user subsequently passes the mission. I wasn't able to reproduce this actual bug given my limited time, so consider this a very early prospective solution. I'd appreciate testing from those that can rebuild a nightly trunk build with the attached diff. |
|
2008-12-14 07:51
|
potential-fix-mantis-1843.diff (518 bytes)
Index: code/mission/missioncampaign.cpp =================================================================== --- code/mission/missioncampaign.cpp (revision 4994) +++ code/mission/missioncampaign.cpp (working copy) @@ -2444,6 +2444,7 @@ // Goober5000 - player-persistent variables are handled when the mission is // over, not necessarily when the mission is accepted + Player->failures_this_session = 0; // DKA 12/11/98 - Unneeded already evaluated and stored // determine what new mission we are moving to. |
|
|
looks like it will work, committed. |
|
|
I managed to repeat the scenario with Love The Treason... ... But hate the traitor. (I was using the same build as before, have not tried the fix yet. It is not really something one would wish to test) |
|
|
Joshua, was that repro with Love the Treason... using a newer post r4995 build? If so, I'll have to look into the proposed patch again. |
|
|
Negative, it was with an older build (the 6 december one). I had not reproduced the bug yet, so I posted that note there to say I now have. I'll test the bugfix as soon as the new windows nightly comes out. |
|
|
Ok, thanks for the update. I'll be looking forward to hearing how it goes (unfortunately, it can be a rather time intensive bug to reproduce repeatedly on different platforms as I'm sure you've experienced) |
|
|
The problem does no longer seem to occure. Nice job. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-12-10 19:54 | Joshua | New Issue | |
| 2008-12-14 07:51 | Echelon9 | Note Added: 0010409 | |
| 2008-12-14 07:51 | Echelon9 | File Added: potential-fix-mantis-1843.diff | |
| 2008-12-14 08:07 | phreak | Note Added: 0010411 | |
| 2008-12-14 11:27 | Joshua | Note Added: 0010413 | |
| 2008-12-14 12:07 | Echelon9 | Note Added: 0010414 | |
| 2008-12-14 12:08 | Joshua | Note Edited: 0010413 | |
| 2008-12-14 12:12 | Joshua | Note Added: 0010415 | |
| 2008-12-14 12:16 | Echelon9 | Note Added: 0010416 | |
| 2008-12-14 14:04 | Joshua | Note Added: 0010417 | |
| 2008-12-14 14:14 | Joshua | Note Edited: 0010417 | |
| 2008-12-14 16:04 | phreak | Assigned To | => phreak |
| 2008-12-14 16:04 | phreak | Status | new => resolved |
| 2008-12-20 16:59 | phreak | Relationship added | related to 0001849 |
