View Issue Details

IDProjectCategoryView StatusLast Update
0001839FSSCPFREDpublic2010-05-19 05:31
Reporterchief1983 Assigned ToFSO 4  
PrioritylowSeverityfeatureReproducibilityN/A
Status closedResolutionsuspended 
Summary0001839: Rewrite of Undo system
DescriptionCurrently, the undo system uses a series of 9 saved backups of the mission file for its undo system. After some IRC discussion, it sounds like rewriting this to use a series of diffs saved into memory instead would be a great idea. It would allow for a vastly larger change stack. An autosave after every so many changes would be needed then as no more files would be written to the filesystem. A useful feature alongside this then would be a Undo/redo list to allow you to jump to any change you've made in the series of changes. Similar to the list found in Paint.NET and other apps.
TagsNo tags attached.

Activities

karajorma

2008-12-05 23:35

administrator   ~0010357

The undo list would only require some interface changes as FRED keeps an internal list of the last 9 changes anyway (names are in the undo_desc array).

chief1983

2008-12-05 23:53

administrator   ~0010361

Right, so the list would just need to be visible to the user (and increased in size). Options on the list could include the ability to click any change and revert to it as well. What would be really interesting is forking in the situation where you revert back and then make a new change, so the previous change branch still exists. Slightly useful but I'd probably consider that above and beyond the call of duty.

chief1983

2008-12-06 19:26

administrator   ~0010368

Wait wut...I thought you didn't want this beast of a request...

Goober5000

2008-12-06 19:54

administrator   ~0010370

...ugh.

This shouldn't be in Mantis IMHO. Besides, this is one of the things that wxFRED is supposed to take care of. IIRC wxWidgets has an Undoable interface that you can use to keep track of operations. There wouldn't be a need to repeatedly save the mission.

chief1983

2008-12-06 20:12

administrator   ~0010371

I didn't know wxWidgets had that kind of stuff built in, I figured anything written for this would also work with wxWidgets for the most part. Also, if feature requests like this aren't any good here, where are they good then? It's marked both low priority and feature severity, so I'm still confused as to why I keep hearing that Mantis is no place for feature requests.

Goober5000

2008-12-06 22:48

administrator   ~0010373

Mostly because I want Mantis to be exclusively for bugfixing. You can take a quick look at the first page and see that there are 129 open issues. That immediately says how "broken" (for lack of a better word) FSO is. If the first page said 200 open issues, it would be a bit discouraging, especially if there's no quick way to tell how many are feature requests and how many are bugs.

I'm not adverse to opening a separate Mantis repository for feature requests, if we decide we need it.

chief1983

2008-12-06 23:04

administrator   ~0010374

Actually that's why I was making some quick filters, with one of the public filters I set up you can easily see that there are 30ish major or higher bugs, which is almost half from a few months ago. Could easily make a feature-less display so that switching to that view was a matter of a couple clicks. If you make features low priority then the Minor and lower one already filters them out as well. But I do see your point, I just don't know where else to throw this so it's not forgotten.

karajorma

2008-12-07 09:16

administrator   ~0010385

I maintain my own list of features I want to add. I was just going to let this one grow and then add it to that. :)

karajorma

2008-12-31 11:43

administrator   ~0010494

I've added this to my list of features to look into for 3.6.11

Issue History

Date Modified Username Field Change
2008-12-05 21:40 chief1983 New Issue
2008-12-05 23:35 karajorma Note Added: 0010357
2008-12-05 23:53 chief1983 Note Added: 0010361
2008-12-06 09:41 karajorma Status new => assigned
2008-12-06 09:41 karajorma Assigned To => karajorma
2008-12-06 19:26 chief1983 Note Added: 0010368
2008-12-06 19:54 Goober5000 Note Added: 0010370
2008-12-06 20:12 chief1983 Note Added: 0010371
2008-12-06 22:48 Goober5000 Note Added: 0010373
2008-12-06 23:04 chief1983 Note Added: 0010374
2008-12-07 09:16 karajorma Note Added: 0010385
2008-12-31 11:43 karajorma Status assigned => resolved
2008-12-31 11:43 karajorma Resolution open => won't fix
2008-12-31 11:43 karajorma Note Added: 0010494
2010-05-19 05:31 Goober5000 Assigned To karajorma => FSO 4
2010-05-19 05:31 Goober5000 Status resolved => closed
2010-05-19 05:31 Goober5000 Resolution won't fix => suspended