View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001816 | FSSCP | graphics | public | 2008-11-11 03:57 | 2008-12-06 23:05 |
| Reporter | FUBAR-BDHR | Assigned To | chief1983 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.9 | ||||
| Summary | 0001816: Reminder: Enable 3D shockwave flag problem | ||||
| Description | As discussed here: http://www.hard-light.net/forums/index.php/topic,57712.0.html The Enable 3D shockwave flag results in black boxes around explosions in TBP and other mods. | ||||
| Tags | No tags attached. | ||||
|
|
Ok, so Spicious did provide a possible patch in that thread, but I've been looking at the code and I'm not so sure about it. The patch relies on a failed load of a 2d shockwave, but as far as I can tell, a failed load of both a 2d and 3d shockwave (which would happen since it skips the 3d) should have asserted. Since it's not asserting right now, it seems like it's loading _something_ for the 2d shockwave, I'm just not sure what. I may have misread the code though, and I plan to try out that patch later just to see what it does. Also to clarify, I believe it's when this option is _not_ checked that it causes the problems, as this causes it to attempt to load a 2d shockwave that certain total conversions no longer provide. I'll try to get a test build with that patch very soon, but I've lost my compiling environment for the time being. |
|
|
http://swc.fs2downloads.com/files/shockwavetest.7z This should use the 3d shockwave, regardless of the command line, if the 2d could not be loaded. However, there appears to be a different bug with TBP's files in that when the skybox is enabled, the 2d shockwave effect is broken. I'm not sure if this is a code bug or something in TBP's own stuff. It may be worth forcing 3d if the TBP command line option is checked regardless of the 3d shockwave one, if this is the case. Unless this is related to a separate bug in the SCP code, then it should just require fixing that bug. |
|
|
The 2d shockwave problem sounds like something with the TBP media and not FSO. 2D shockwaves work fine with skyboxes enabled when using the normal FS2 shockwave. |
|
|
What file(s) would I look at to see if it is a TBP problem? I know there are 4 different shockwave0x.eff files. If it is can we get 3D Shockwave forced on if the TBP flag is on? |
|
|
I'm just speculating the TBP 2d shockwave may have the wrong alpha blending type or something to make it look different. I wouldn't know since I don't have TBP. |
|
|
Fubar, I think those are all just different LODs of the same shockwave. I'm not sure but I would imagine it's a problem related to all of them, so it may be the skybox and not the shockwave, but I'm not sure. Perhaps it's a problem with eff effects, although I thought the mediavp shockwaves were also eff and seem to be having no problems. But if the problem is in one shockwave file, it's probably in all of them, stemming from whatever process created them originally. I do find it slightly silly that the 2d shockwaves have been in the pack this long if they were never intended for use though, but I'm guessing the 3d shockwave setting can be tied to the TBP one, or this patch can also check for the existence of the TBP flag. If it ends up that the problem can't be easily rectified on TBP's end I'll try to get that taken care of. |
|
|
I made a test with all the eff. Shockwave01.eff, 02, & 03 appear to be the same just different colors. Shockwave04.eff seems to be the 3D one. I really don't know that much about how these things work. I manage to hack a mod or 2 every once and awhile but that's about it. Could it be something with the .pof files for the shockwaves? |
|
|
If there are only eff's and it not referencing another graphic file which is called to by a model, thene there is no 3D shockwave. Ex from DaBrains Uber: shockwave.pof -> shockwave3d.dds which has a shockwave3d-glow.eff to create the animated effect. If it is just eff files, then those are all 2D LODed versions. |
|
|
Yeah, like Zacam said, when I went through the TBP assets I believe the eff files were all different LODs of basically the same effect. I don't believe any of them is related to the 3d shockwave. Disabling the 3d shockwave, even with my newest patch, will still cause those 2d shockwaves to be used, which have apparently never been tested, or have broken since the 3.6.10 graphics upgrade. When the 2d shockwaves are active, the pof files are never used, so there's no way those should be related to the problem, to answer your question specifically. |
|
|
I saw we just take the easy way out if it's not a issue for FS2. Force the flag on if the TBP flag is on. The TBP core is final anyway so we can't fix the problem even if we find it. On a side note could you force the use models for ship and weapon selection on as well? Kind of the same issue since -ship_choice_3d is the default for TBP in 3.6.9. |
|
|
Ok, the first part of this is committed. I'm looking at setting the flags for TBP. I can see why forcing the weapons one would help, but it looks like there's no problems with turning off the ship one, and it's checked by default in the launcher ini included with TBP. So I don't see any reason to force it when the TBP flag is set, it just takes away control from the user. But the weapons one is using FS2 anis and icons so I can understand forcing it. I still think TBP could have used a lot of cleaning up though table-wise before its final release...this is all stuff that could be fixed by anyone who can read the FS wiki. So basically, checking the TBP flag will force the 3d shockwave and weapon choice 3d flag as I currently have my patch. I'll commit it tonight if I don't hear anything so it makes it in a build for the weekend. |
|
|
Well since turning off 3d ship selection results in a crash probably a good idea to force it on as well. Crash was: Int3(): From e:\storage\fso\fs2_open\code\missionui\missionshipchoice.cpp at line 3504 Just in case you want to know. |
|
|
Strange. I turned it off in 3.6.9 and there was nothing wrong at all. Wonder why that crashes in 3.6.10. Edit: Ok I take that back. It only Int3's in debug, not in the regular build. There must be something wrong with the ship icons, so I guess the 2d ship selection feature was never quite finished. I'll go ahead and throw that flag in there too then I guess. It looks like the crash has to do with bad animation frame counts or something, I'm not really sure. |
|
|
All right, 3d ship selection will be forced too now, as of the next nightly build r4984 or higher. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-11-11 03:57 | FUBAR-BDHR | New Issue | |
| 2008-11-12 22:30 | chief1983 | Note Added: 0010188 | |
| 2008-11-13 18:28 | chief1983 | Note Added: 0010193 | |
| 2008-11-22 15:53 | phreak | Note Added: 0010253 | |
| 2008-11-27 23:42 | FUBAR-BDHR | Note Added: 0010293 | |
| 2008-11-28 02:01 | phreak | Note Added: 0010294 | |
| 2008-11-30 02:02 | chief1983 | Note Added: 0010298 | |
| 2008-11-30 02:38 | FUBAR-BDHR | Note Added: 0010301 | |
| 2008-11-30 09:09 | Zacam | Note Added: 0010304 | |
| 2008-11-30 10:30 | chief1983 | Note Added: 0010306 | |
| 2008-11-30 18:29 | FUBAR-BDHR | Note Added: 0010310 | |
| 2008-12-05 23:05 | chief1983 | Status | new => assigned |
| 2008-12-05 23:05 | chief1983 | Assigned To | => chief1983 |
| 2008-12-05 23:20 | chief1983 | Note Added: 0010356 | |
| 2008-12-06 04:39 | FUBAR-BDHR | Note Added: 0010363 | |
| 2008-12-06 19:24 | chief1983 | Note Added: 0010367 | |
| 2008-12-06 20:05 | chief1983 | Note Edited: 0010367 | |
| 2008-12-06 23:05 | chief1983 | Note Added: 0010375 | |
| 2008-12-06 23:05 | chief1983 | Status | assigned => resolved |
| 2008-12-06 23:05 | chief1983 | Resolution | open => fixed |
