View Issue Details

IDProjectCategoryView StatusLast Update
0001705FSSCPFREDpublic2008-07-29 04:17
Reporterchief1983 Assigned ToWMCoolmon  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.6.9 
Summary0001705: New hyperspace code crashes FRED when changing player ship
DescriptionWhen utilizing ships with the new hyperspace warp type defined, changing the player ship in fred to one of these ships causes FRED to crash to desktop. No debug messages, however with the Visual Studio debugger the crash can be captured and debugged it seems. The builds affected seem to go back to the original commit, or at least back to the 4/05 trunk build, till current revisions. Using the attached modular table, the crash can be reproduced by opening FRED, and switching the player ship to the Myrmidon.
Additional InformationWith the Visual Studio debugger the crash can be captured and debugged it seems. It takes you to this function (exact line [1785] of shipeditordlg.cpp marked below):

void CShipEditorDlg::OnSelchangeShipClass()
{
    object *ptr;

    UpdateData(TRUE);
    UpdateData(TRUE);
    ptr = GET_FIRST(&obj_used_list);
    while (ptr != END_OF_LIST(&obj_used_list)) {
        if (((ptr->type == OBJ_SHIP) || (ptr->type == OBJ_START)) && (ptr->flags & OF_MARKED))
            if (Ships[ptr->instance].ship_info_index != m_ship_class) {
/***** CODE BREAKS TO HERE ON DEBUG ****/ change_ship_type(ptr->instance, m_ship_class);
                set_modified();
            }

        ptr = GET_NEXT(ptr);
    }

    update_map_window();
}

I'm currently at a loss at this point.
TagsNo tags attached.

Activities

2008-05-30 02:08

 

warp_test-shp.tbm (206 bytes)

WMCoolmon

2008-06-29 07:41

developer   ~0009419

I can't reproduce this bug with my local SVN. Are you sure it's still present? I will also try to have a build out by tonight for you to test with.

chief1983

2008-07-29 04:09

administrator   ~0009517

Sorry this took so long, seems fixed to me, can't reproduce on my retail install or the working FotG setup. Case closed.

Issue History

Date Modified Username Field Change
2008-05-30 02:08 chief1983 New Issue
2008-05-30 02:08 chief1983 File Added: warp_test-shp.tbm
2008-06-04 08:21 WMCoolmon Status new => assigned
2008-06-04 08:21 WMCoolmon Assigned To => WMCoolmon
2008-06-29 07:41 WMCoolmon Note Added: 0009419
2008-06-29 07:41 WMCoolmon Status assigned => feedback
2008-07-29 04:09 chief1983 Note Added: 0009517
2008-07-29 04:17 WMCoolmon Status feedback => resolved
2008-07-29 04:17 WMCoolmon Resolution open => fixed