View Issue Details

IDProjectCategoryView StatusLast Update
0001097FSSCPmultiplayerpublic2006-10-09 19:55
ReporterFUBAR-BDHR Assigned ToGoober5000  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Summary0001097: Distance of 0 is invalid in mission_set_arrival_location
DescriptionDecided to test a mission I wrote a while back to see if the ghost gun problem had been fixed. In case you haven't heard of it ghost guns occured when there were too many objects ingame for multiplayer to handle. Guns would go right through ships without doing anything. Chief cause: asteroid fields. Well loaded the mission which worked other than the ghost gun problem. Started playing and receive the error. Tried again, same error. Error occured in FUBAR_M01_b.fs2. Like I said this mission did work in 1.2 and only needed minor adjustments to finish. I was host and only player.
TagsNo tags attached.

Activities

2006-10-08 22:38

 

fubar_m01_b.fs2 (100,673 bytes)

2006-10-08 22:40

 

Media-10-08-06a.rar (31,156 bytes)

Goober5000

2006-10-09 12:46

administrator   ~0006833

That's a bug with the mission itself. Joker wing is cued to arrive when 50% of Trickster wing is destroyed, but Joker is set to arrive 0 meters from <any enemy>.

FUBAR-BDHR

2006-10-09 16:52

developer   ~0006835

Last edited: 2006-10-09 17:00

Well it worked in the retail. I'll have to go back and look to make sure it didn't get overwritten with an old version somehow. Just checked it out in FRED2 and it still passes error checking???

edited on: 10-09-06 13:00

FUBAR-BDHR

2006-10-09 19:23

developer   ~0006837

Opened te mission up in FRED2_3.6.9 from the rc7dot8 build. 0 is a vaild distance. Maybe it shouldn't be but it is. So looks like we do have a bug here. Is it a FS2 bug or a FRED2 bug? That is the real question. Only reason I could see for having 0 for an arrival distance would be something like tagging a ship and having a meson bomb arrive on it. Think someone was playing with hyperspace artillery like that years ago. Sorry digressed for a moment. Anyway could things like this be causing some of the other errors we are seeing in validated missions? By things like this I mean stuff that was valid in 1.2 and FRED2 but isn't now?

Goober5000

2006-10-09 19:30

administrator   ~0006838

0 is not a valid distance because you get div-by-0 errors. You can have 1, but not 0.

This was invalid in retail FS2 (and FS1) just like it's invalid now. The only difference is that now FSO tells you what you did wrong instead of failing silently.

FUBAR-BDHR

2006-10-09 19:38

developer   ~0006839

OK I understand that it is not valid and now I know the reason why. My point of it being a FRED2 bug then still applies. FRED2 should not allow that value and you should receive a message when running error checker in FRED2. Also it did run without crashing in FS2 1.2. Ran that mission many times on insane for testing.

Goober5000

2006-10-09 19:55

administrator   ~0006840

There are two problems. The first problem is that FRED *already* flags it as an error, but due to the vagaries of FRED it's possible to fool the program and add it anyway. Additionally, you can always edit the mission in Notepad.

The second problem is that it doesn't become a bug until you're actually flying the mission. As I said, in retail, it failed silently. It could have handled the bug without displaying an error message, or it could have failed in a way that let it continue running.

Anyway, I've added some extra code to catch the parsing error as the mission is being loaded and set the distance to at least 1. This should prevent you from seeing the message. If you continue to see the message, it's a more serious bug and you should report it again.

Issue History

Date Modified Username Field Change
2006-10-08 22:38 FUBAR-BDHR New Issue
2006-10-08 22:38 FUBAR-BDHR File Added: fubar_m01_b.fs2
2006-10-08 22:40 FUBAR-BDHR File Added: Media-10-08-06a.rar
2006-10-09 12:46 Goober5000 Note Added: 0006833
2006-10-09 16:52 FUBAR-BDHR Note Added: 0006835
2006-10-09 17:00 FUBAR-BDHR Note Edited: 0006835
2006-10-09 19:23 FUBAR-BDHR Note Added: 0006837
2006-10-09 19:30 Goober5000 Note Added: 0006838
2006-10-09 19:38 FUBAR-BDHR Note Added: 0006839
2006-10-09 19:55 Goober5000 Note Added: 0006840
2006-10-09 19:55 Goober5000 Status assigned => resolved
2006-10-09 19:55 Goober5000 Resolution open => fixed
2006-10-09 19:55 Goober5000 Assigned To taylor => Goober5000