View Issue Details

IDProjectCategoryView StatusLast Update
0001093FSSCPgameplaypublic2012-12-05 22:39
ReporterIPAndrews Assigned Tophreak  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionunable to reproduce 
Summary0001093: set-turret-weapon doesn't always set-turret-weapon
DescriptionIt seems to depend on the weapon. I'm using TBP and trying to change Turret01a on a Battlecrab.

   ( turret-change-weapon
      "<argument>"
      "Turret01a"
      "SH HeavyAAA"
      1
      0
   )

If I try to change to Shadow HeavyAAA (above) the turret just stops working. While if I try to change to other weapons (Vree Anti-Matter cannon) the turret works correctly. It's not a beam vs pulse thing either. I cannot figure the pattern as to what works and what doesn't. Seems random.
TagsNo tags attached.

Activities

Backslash

2006-10-14 23:37

developer   ~0006892

Vree Anti-Matter Cannon isn't such a useful test -- you might test changing to other beam weapon types and see if they work.

I just noticed SH HeavyAAA has the "huge" flag set. I could be wrong here but I seem to recall this means it doesn't fire at small ships. However, the Wiki only says it does the final 10% damage to a ship with the "Big Damage" flag.

Ok, upon looking at the code I found a possible culprit:
AiTurret.cpp, function is_target_beam_valid, line 700. Looks to me like it's ignoring any ship that's not BIG or HUGE. Other coders, am I reading this wrong, or is this behavior intended? (If so, I should probably update the Wiki.)

Goober5000

2006-10-15 15:24

administrator   ~0006895

It's a beam. Have you beam-freed the turret after changing the weapon?

karajorma

2007-11-29 23:47

administrator   ~0008707

Can I close this one or does it still happen?

taylor

2008-03-31 08:26

administrator   ~0009101

* BUMP *

Is this still an issue? We'll close it in a few days as a non-issue unless told otherwise.

phreak

2008-05-21 03:49

developer   ~0009339

bump. final warning ;)

FUBAR-BDHR

2008-05-29 06:47

developer   ~0009355

I just ran into the same problem with the same ship. Trying to switch it from anything to anything didn't seem to work. The type would change if one was a beam and the other a turret but no firing of the second weapon. I had the beams and turrets locked but am using the fire-beam sexp for the mission which doesn't require the turret or beam be unlocked. I added the beam-free and turret-free and it fires. Problem is I don't want it free I want to control the firing.

phreak

2008-10-02 18:10

developer   ~0009771

If someone can come up with a simple test mission in retail then I can take a look at it.

Goober5000

2008-10-02 18:48

administrator   ~0009775

I know why this happens. Turret weapons are handled on a per-class basis, not a per-ship basis. In order to handle weapons by ship, a major overhaul of the feature is required, similar to when SIF_STEALTH was changed to SF_STEALTH.

So, let's postpone this until after 3.6.10 is out. Although, it would be helpful to add a note in the sexp saying that it doesn't actually work. :)

The_E

2010-12-11 00:20

administrator   ~0012537

This still an issue?

The_E

2012-12-05 18:42

administrator   ~0014310

Yeah, 2 years and no feedback is making this a non-issue in my book. Especially since noone could be bothered to build a test case or anything.

Goober5000

2012-12-05 22:39

administrator   ~0014318

FUBAR confirmed he was unable to reproduce this on current trunk.

Issue History

Date Modified Username Field Change
2006-10-06 13:55 IPAndrews New Issue
2006-10-14 23:37 Backslash Note Added: 0006892
2006-10-15 15:24 Goober5000 Note Added: 0006895
2007-11-29 23:47 karajorma Note Added: 0008707
2008-03-31 08:26 taylor Note Added: 0009101
2008-05-21 03:49 phreak Note Added: 0009339
2008-05-29 06:47 FUBAR-BDHR Note Added: 0009355
2008-10-02 18:10 phreak Note Added: 0009771
2008-10-02 18:18 phreak Status new => assigned
2008-10-02 18:18 phreak Assigned To => phreak
2008-10-02 18:48 Goober5000 Note Added: 0009775
2010-12-11 00:20 The_E Note Added: 0012537
2012-12-05 18:42 The_E Note Added: 0014310
2012-12-05 18:42 The_E Status assigned => closed
2012-12-05 18:42 The_E Resolution open => unable to reproduce
2012-12-05 22:39 Goober5000 Note Added: 0014318