Changesets: fs2open

trunk r7576

2011-08-30 09:38

The_E


Ported: N/A

Details Diff
PVS Studio fix: "delete operator applied to non-pointer"
mod - /trunk/fs2_open/code/lab/wmcgui.cpp Diff File

trunk r7575

2011-08-30 09:21

The_E


Ported: N/A

Details Diff
PVS Studio fix: duplicated "!strlen(filename)" check
mod - /trunk/fs2_open/code/fred2/voiceactingmanager.cpp Diff File

trunk r7574

2011-08-30 09:12

Echelon9


Ported: N/A

Details Diff
PVS-Studio (courtesy of niffiwan): V523 The 'then' statement is equivalent to the 'else' statement (techmenu.cpp).
mod - /trunk/fs2_open/code/menuui/techmenu.cpp Diff File

trunk r7573

2011-08-30 09:06

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix (courtesy of niffiwan): V523 The 'then' statement is equivalent to the 'else' statement (missiontraining.cpp).
mod - /trunk/fs2_open/code/mission/missiontraining.cpp Diff File

trunk r7572

2011-08-30 07:50

karajorma


Ported: N/A

Details Diff
PVS-Studio fix: V512 A call of the 'memset' function will lead to underflow of the buffer 'type'.

Never really would matter but it's a waste of memory declaring an int buffer and then only using 1/4 of it
mod - /trunk/fs2_open/code/network/multi_sexp.cpp Diff File

trunk r7571

2011-08-30 03:29

Goober5000


Ported: N/A

Details Diff
add fire-beam-at-coordinates, which is as awesome as it sounds
mod - /trunk/fs2_open/code/fred2/sexp_tree.cpp Diff File
mod - /trunk/fs2_open/code/network/multimsgs.cpp Diff File
mod - /trunk/fs2_open/code/network/multimsgs.h Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.h Diff File
mod - /trunk/fs2_open/code/weapon/beam.cpp Diff File
mod - /trunk/fs2_open/code/weapon/beam.h Diff File

trunk r7570

2011-08-30 03:27

Goober5000


Ported: N/A

Details Diff
having null iterators is apparently a no-no according to the C++ standard, so use a globally defined invalid iterator instead
mod - /trunk/fs2_open/code/ai/aicode.cpp Diff File
mod - /trunk/fs2_open/code/object/waypoint.cpp Diff File
mod - /trunk/fs2_open/code/object/waypoint.h Diff File
mod - /trunk/fs2_open/code/ship/ship.cpp Diff File

trunk r7569

2011-08-30 00:12

karajorma


Ported: N/A

Details Diff
Gliding remains on when the player restarts a mission.
mod - /trunk/fs2_open/code/playerman/playercontrol.cpp Diff File

trunk r7568

2011-08-29 23:35

Goober5000


Ported: N/A

Details Diff
waypoints and waypoint paths now have dynamic limits
mod - /trunk/fs2_open/code/ai/ai.cpp Diff File
mod - /trunk/fs2_open/code/ai/ai.h Diff File
mod - /trunk/fs2_open/code/ai/aicode.cpp Diff File
mod - /trunk/fs2_open/code/ai/aigoals.cpp Diff File
mod - /trunk/fs2_open/code/autopilot/autopilot.cpp Diff File
mod - /trunk/fs2_open/code/autopilot/autopilot.h Diff File
mod - /trunk/fs2_open/code/fred2/briefingeditordlg.cpp Diff File
mod - /trunk/fs2_open/code/fred2/campaigneditordlg.cpp Diff File
mod - /trunk/fs2_open/code/fred2/createwingdlg.cpp Diff File
mod - /trunk/fs2_open/code/fred2/dumpstats.cpp Diff File
mod - /trunk/fs2_open/code/fred2/fredrender.cpp Diff File
mod - /trunk/fs2_open/code/fred2/fredview.cpp Diff File
mod - /trunk/fs2_open/code/fred2/management.cpp Diff File
mod - /trunk/fs2_open/code/fred2/management.h Diff File
mod - /trunk/fs2_open/code/fred2/missionnotesdlg.cpp Diff File
mod - /trunk/fs2_open/code/fred2/missionsave.cpp Diff File
mod - /trunk/fs2_open/code/fred2/missionsave.h Diff File
mod - /trunk/fs2_open/code/fred2/orienteditor.cpp Diff File
mod - /trunk/fs2_open/code/fred2/sexp_tree.cpp Diff File
mod - /trunk/fs2_open/code/fred2/ship_select.cpp Diff File
mod - /trunk/fs2_open/code/fred2/ship_select.h Diff File
mod - /trunk/fs2_open/code/fred2/shipeditordlg.cpp Diff File
mod - /trunk/fs2_open/code/fred2/shipgoalsdlg.cpp Diff File
mod - /trunk/fs2_open/code/fred2/waypointpathdlg.cpp Diff File
mod - /trunk/fs2_open/code/fred2/wing_editor.cpp Diff File
mod - /trunk/fs2_open/code/freespace2/freespace.cpp Diff File
mod - /trunk/fs2_open/code/hud/hud.cpp Diff File
mod - /trunk/fs2_open/code/mission/missionparse.cpp Diff File
mod - /trunk/fs2_open/code/network/multimsgs.cpp Diff File
mod - /trunk/fs2_open/code/object/waypoint.cpp Diff File
mod - /trunk/fs2_open/code/object/waypoint.h Diff File
mod - /trunk/fs2_open/code/parse/lua.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.h Diff File
mod - /trunk/fs2_open/code/ship/ship.cpp Diff File
mod - /trunk/fs2_open/code/ship/shipfx.cpp Diff File

trunk r7567

2011-08-29 20:18

karajorma


Ported: N/A

Details Diff
Documentation for the Multiplayer SEXP system.
mod - /trunk/fs2_open/code/network/multi_sexp.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File

trunk r7566

2011-08-29 12:08

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V515 The 'delete' operator is applied to non-pointer (hud.cpp).
mod - /trunk/fs2_open/code/hud/hud.cpp Diff File

trunk r7565

2011-08-29 09:19

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix (Courtesy of niffiwan): V523 The 'then' statement is equivalent to the 'else' statement (barracks.cpp and missionhotkey.cpp).
mod - /trunk/fs2_open/code/menuui/barracks.cpp Diff File
mod - /trunk/fs2_open/code/mission/missionhotkey.cpp Diff File

antipodes r7564

2011-08-28 20:21

Zacam


Ported: N/A

Details Diff
Trunk Sync r7563
mod - /branches/antipodes/code/ai/aicode.cpp Diff File
mod - /branches/antipodes/code/autopilot/autopilot.cpp Diff File
mod - /branches/antipodes/code/bmpman/bm_internal.h Diff File
mod - /branches/antipodes/code/camera/camera.cpp Diff File
mod - /branches/antipodes/code/cfile/cfilesystem.cpp Diff File
mod - /branches/antipodes/code/cutscene/cutscenes.cpp Diff File
mod - /branches/antipodes/code/debris/debris.cpp Diff File
mod - /branches/antipodes/code/fireball/fireballs.cpp Diff File
mod - /branches/antipodes/code/fs2netd/fs2netd_client.cpp Diff File
mod - /branches/antipodes/code/fs2netd/tcp_client.cpp Diff File
mod - /branches/antipodes/code/gamesnd/gamesnd.cpp Diff File
mod - /branches/antipodes/code/graphics/gropenglpostprocessing.cpp Diff File
mod - /branches/antipodes/code/io/joy.cpp Diff File
mod - /branches/antipodes/code/model/model.h Diff File
mod - /branches/antipodes/code/network/chat_api.cpp Diff File
mod - /branches/antipodes/code/network/multi_data.cpp Diff File
mod - /branches/antipodes/code/network/multi_obj.cpp Diff File
mod - /branches/antipodes/code/object/collideshipship.cpp Diff File
mod - /branches/antipodes/code/object/objectdock.h Diff File
mod - /branches/antipodes/code/parse/lua.cpp Diff File
mod - /branches/antipodes/code/parse/parselo.cpp Diff File
mod - /branches/antipodes/code/parse/parselo.h Diff File
mod - /branches/antipodes/code/parse/scripting.cpp Diff File
mod - /branches/antipodes/code/parse/sexp.cpp Diff File
mod - /branches/antipodes/code/sound/ds.cpp Diff File
mod - /branches/antipodes/code/sound/sound.cpp Diff File

trunk r7563

2011-08-28 11:10

Echelon9


Ported: N/A

Details Diff
Documentation: Code cleanup of sexp.cpp
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File

trunk r7562

2011-08-28 08:48

Echelon9


Ported: N/A

Details Diff
Reverting 7545: Due to some odd errors coming through as Asserts in cfile.cpp
mod - /trunk/fs2_open/code/graphics/2d.h Diff File

trunk r7561

2011-08-28 05:49

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V516 Consider inspecting an odd expression. Non-null function pointer is compared to null: 'jumpnode_get_by_name == 0' (sexp.cpp).

Ironic that check_sexp_syntax() appeared to have a mistake in it's check functions.
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File

trunk r7560

2011-08-28 05:41

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V555 The expression '(now - bi->last_down_check) > 0' will work as 'now != bi->last_down_check'.

Due to unsigned int type wrapping the former code would have always returned true.
mod - /trunk/fs2_open/code/io/joy.cpp Diff File

trunk r7559

2011-08-28 05:36

Echelon9


Ported: N/A

Details Diff
Documentation: Code cleanup in multi_obj.cpp
mod - /trunk/fs2_open/code/network/multi_obj.cpp Diff File

trunk r7558

2011-08-28 05:34

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V519 The 'num_users' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 2296, 2297 (multi_pxo.cpp)
mod - /trunk/fs2_open/code/network/multi_pxo.cpp Diff File

trunk r7557

2011-08-28 05:32

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V519 The 'player_index' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1389, 1392 (multi_obj.cpp)
mod - /trunk/fs2_open/code/network/multi_obj.cpp Diff File

trunk r7556

2011-08-28 05:31

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V519 The 'list_size' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 597, 604 (gropenglpostprocessing.cpp)
mod - /trunk/fs2_open/code/graphics/gropenglpostprocessing.cpp Diff File

trunk r7555

2011-08-28 05:30

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V519 The 'path_index' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 12782, 12809 (aicode.cpp)
mod - /trunk/fs2_open/code/ai/aicode.cpp Diff File

trunk r7554

2011-08-28 04:54

Echelon9


Ported: N/A

Details Diff
Documentation: Clean up lua.cpp
mod - /trunk/fs2_open/code/parse/lua.cpp Diff File

trunk r7553

2011-08-28 04:31

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V803 Decreased performance. In case 'tvs' is iterator it's more effective to use prefix form of increment. Replace iterator++ with ++iterator.

For further discussion see, http://www.viva64.com/en/b/0093/

The scenarios where it will improve performance are under Debug builds. This improvement will however allow quicker use of other profiling tools that need to run on Debug builds.

Note. Code with size_t does not see the performance improvement comparison to iterators due to absence of array overrun check.
mod - /trunk/fs2_open/code/autopilot/autopilot.cpp Diff File
mod - /trunk/fs2_open/code/camera/camera.cpp Diff File
mod - /trunk/fs2_open/code/cfile/cfilesystem.cpp Diff File
mod - /trunk/fs2_open/code/cutscene/cutscenes.cpp Diff File
mod - /trunk/fs2_open/code/debris/debris.cpp Diff File
mod - /trunk/fs2_open/code/fireball/fireballs.cpp Diff File
mod - /trunk/fs2_open/code/fs2netd/fs2netd_client.cpp Diff File
mod - /trunk/fs2_open/code/fs2netd/tcp_client.cpp Diff File
mod - /trunk/fs2_open/code/gamesnd/gamesnd.cpp Diff File
mod - /trunk/fs2_open/code/object/collideshipship.cpp Diff File
mod - /trunk/fs2_open/code/parse/scripting.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File
mod - /trunk/fs2_open/code/sound/sound.cpp Diff File

trunk r7552

2011-08-28 03:39

Echelon9


Ported: N/A

Details Diff
Revert r7546 -- will need more work.
mod - /trunk/fs2_open/code/controlconfig/controlsconfig.h Diff File
 First  Prev  1 2 3 ... 40 ... 80 ... 120 ... 134 135 136 137 138 139 140 ... 160 ... 200 ... 240 ... 280 ... 320 ... 360 ... 400 ... 437 438 439  Next  Last