All Projects FSSCP  wxFRED

Changesets: fs2open

Search Browse Back to Index

trunk r7601

2011-08-31 09:00

Echelon9


Ported: N/A

Details Diff		 PVS-Studio false positive: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. Check lines: 185, 189 (dscap.cpp)
mod - /trunk/fs2_open/code/sound/dscap.cpp Diff File

trunk r7600

2011-08-31 08:58

Echelon9


Ported: N/A

Details Diff		 PVS-Studio false positive: V537 Consider reviewing the correctness of 'y' item's usage (3dmath.cpp)
mod - /trunk/fs2_open/code/render/3dmath.cpp Diff File

trunk r7599

2011-08-31 06:58

Zacam


Ported: N/A

Details Diff		 Clean up the commented out code from niffiwan's PVS-Studio patches. (from niffiwan)
mod - /trunk/fs2_open/code/menuui/barracks.cpp Diff File
mod - /trunk/fs2_open/code/mission/missionhotkey.cpp Diff File

trunk r7598

2011-08-31 05:59

Zacam


Ported: N/A

Details Diff		 MSVC Analysis C6244: Local declaration of <variable> hides previous declaration at <line> of <file>. (lock_world_pos; 31; hudlock.cpp)
mod - /trunk/fs2_open/code/hud/hudlock.cpp Diff File

trunk r7597

2011-08-31 05:37

Zacam


Ported: N/A

Details Diff		 MSVC Analysis C6246: Local declaration of <variable> hides declaration of same name in outer scope. (wip, swp, objp, j)
mod - /trunk/fs2_open/code/ship/ship.cpp Diff File

antipodes r7596

2011-08-30 19:00

Zacam


Ported: N/A

Details Diff		 From Trunk 7595: Shipp can be NULL, which would lead to a crash. This resolves that crash from happening.
mod - /branches/antipodes/code/model/modelinterp.cpp Diff File

trunk r7595

2011-08-30 18:59

Zacam


Ported: N/A

Details Diff		 Fix for 7590: Shipp can be NULL, which would lead to a crash. This resolves that crash from happening.
mod - /trunk/fs2_open/code/model/modelinterp.cpp Diff File

antipodes r7594

2011-08-30 14:17

The_E


Ported: N/A

Details Diff		 Trunk sync r7593
mod - /branches/antipodes/code/ai/ai.cpp Diff File
mod - /branches/antipodes/code/ai/ai.h Diff File
mod - /branches/antipodes/code/ai/aicode.cpp Diff File
mod - /branches/antipodes/code/ai/aigoals.cpp Diff File
mod - /branches/antipodes/code/anim/animplay.cpp Diff File
mod - /branches/antipodes/code/autopilot/autopilot.cpp Diff File
mod - /branches/antipodes/code/autopilot/autopilot.h Diff File
mod - /branches/antipodes/code/bmpman/bmpman.cpp Diff File
mod - /branches/antipodes/code/cfile/cfilesystem.cpp Diff File
mod - /branches/antipodes/code/fred2/AltShipClassDlg.cpp Diff File
mod - /branches/antipodes/code/fred2/briefingeditordlg.cpp Diff File
mod - /branches/antipodes/code/fred2/campaigneditordlg.cpp Diff File
mod - /branches/antipodes/code/fred2/createwingdlg.cpp Diff File
mod - /branches/antipodes/code/fred2/dumpstats.cpp Diff File
mod - /branches/antipodes/code/fred2/fredrender.cpp Diff File
mod - /branches/antipodes/code/fred2/fredview.cpp Diff File
mod - /branches/antipodes/code/fred2/management.cpp Diff File
mod - /branches/antipodes/code/fred2/management.h Diff File
mod - /branches/antipodes/code/fred2/missionnotesdlg.cpp Diff File
mod - /branches/antipodes/code/fred2/missionsave.cpp Diff File
mod - /branches/antipodes/code/fred2/missionsave.h Diff File
mod - /branches/antipodes/code/fred2/orienteditor.cpp Diff File
mod - /branches/antipodes/code/fred2/sexp_tree.cpp Diff File
mod - /branches/antipodes/code/fred2/ship_select.cpp Diff File
mod - /branches/antipodes/code/fred2/ship_select.h Diff File
mod - /branches/antipodes/code/fred2/shipeditordlg.cpp Diff File
mod - /branches/antipodes/code/fred2/shipgoalsdlg.cpp Diff File
mod - /branches/antipodes/code/fred2/voiceactingmanager.cpp Diff File
mod - /branches/antipodes/code/fred2/waypointpathdlg.cpp Diff File
mod - /branches/antipodes/code/fred2/wing_editor.cpp Diff File
mod - /branches/antipodes/code/freespace2/freespace.cpp Diff File
mod - /branches/antipodes/code/globalincs/pstypes.h Diff File
mod - /branches/antipodes/code/graphics/font.cpp Diff File
mod - /branches/antipodes/code/hud/hud.cpp Diff File
mod - /branches/antipodes/code/lab/wmcgui.cpp Diff File
mod - /branches/antipodes/code/math/vecmat.cpp Diff File
mod - /branches/antipodes/code/menuui/barracks.cpp Diff File
mod - /branches/antipodes/code/menuui/techmenu.cpp Diff File
mod - /branches/antipodes/code/mission/missionbriefcommon.cpp Diff File
mod - /branches/antipodes/code/mission/missioncampaign.cpp Diff File
mod - /branches/antipodes/code/mission/missionhotkey.cpp Diff File
mod - /branches/antipodes/code/mission/missionmessage.cpp Diff File
mod - /branches/antipodes/code/mission/missionparse.cpp Diff File
mod - /branches/antipodes/code/model/modelanim.cpp Diff File
mod - /branches/antipodes/code/model/modelinterp.cpp Diff File
mod - /branches/antipodes/code/network/multi_options.cpp Diff File
mod - /branches/antipodes/code/network/multi_pinfo.cpp Diff File
mod - /branches/antipodes/code/network/multi_pxo.cpp Diff File
mod - /branches/antipodes/code/network/multi_sexp.cpp Diff File
mod - /branches/antipodes/code/network/multimsgs.cpp Diff File
mod - /branches/antipodes/code/network/multimsgs.h Diff File
mod - /branches/antipodes/code/network/multiui.cpp Diff File
mod - /branches/antipodes/code/network/psnet2.cpp Diff File
mod - /branches/antipodes/code/network/stand_gui.cpp Diff File
mod - /branches/antipodes/code/object/waypoint.cpp Diff File
mod - /branches/antipodes/code/object/waypoint.h Diff File
mod - /branches/antipodes/code/parse/lua.cpp Diff File
mod - /branches/antipodes/code/parse/scripting.cpp Diff File
mod - /branches/antipodes/code/parse/sexp.cpp Diff File
mod - /branches/antipodes/code/parse/sexp.h Diff File
mod - /branches/antipodes/code/pcxutils/pcxutils.cpp Diff File
mod - /branches/antipodes/code/playerman/playercontrol.cpp Diff File
mod - /branches/antipodes/code/ship/ship.cpp Diff File
mod - /branches/antipodes/code/ship/shipfx.cpp Diff File
mod - /branches/antipodes/code/sound/acm.cpp Diff File
mod - /branches/antipodes/code/sound/audiostr.cpp Diff File
mod - /branches/antipodes/code/sound/dscap.cpp Diff File
mod - /branches/antipodes/code/stats/medals.cpp Diff File
mod - /branches/antipodes/code/stats/scoring.h Diff File
mod - /branches/antipodes/code/stats/stats.cpp Diff File
mod - /branches/antipodes/code/weapon/beam.cpp Diff File
mod - /branches/antipodes/code/weapon/beam.h Diff File

trunk r7593

2011-08-30 13:46

The_E


Ported: N/A

Details Diff		 PVS Studio related: Mark false alarms as such.
mod - /trunk/fs2_open/code/bmpman/bmpman.cpp Diff File
mod - /trunk/fs2_open/code/cfile/cfilesystem.cpp Diff File
mod - /trunk/fs2_open/code/graphics/font.cpp Diff File
mod - /trunk/fs2_open/code/math/vecmat.cpp Diff File
mod - /trunk/fs2_open/code/menuui/techmenu.cpp Diff File
mod - /trunk/fs2_open/code/mission/missioncampaign.cpp Diff File
mod - /trunk/fs2_open/code/mission/missionmessage.cpp Diff File
mod - /trunk/fs2_open/code/network/multi_options.cpp Diff File
mod - /trunk/fs2_open/code/network/multimsgs.cpp Diff File
mod - /trunk/fs2_open/code/network/psnet2.cpp Diff File
mod - /trunk/fs2_open/code/network/stand_gui.cpp Diff File
mod - /trunk/fs2_open/code/parse/lua.cpp Diff File
mod - /trunk/fs2_open/code/parse/scripting.cpp Diff File
mod - /trunk/fs2_open/code/pcxutils/pcxutils.cpp Diff File
mod - /trunk/fs2_open/code/playerman/managepilot.cpp Diff File
mod - /trunk/fs2_open/code/sound/acm.cpp Diff File
mod - /trunk/fs2_open/code/sound/audiostr.cpp Diff File

trunk r7592

2011-08-30 13:46

The_E


Ported: N/A

Details Diff		 Removing the RELEASE_REAL define from ye olde :v: days. We really don't need it anymore.
mod - /trunk/fs2_open/code/cutscene/cutscenes.cpp Diff File
mod - /trunk/fs2_open/code/freespace2/freespace.cpp Diff File
mod - /trunk/fs2_open/code/globalincs/pstypes.h Diff File
mod - /trunk/fs2_open/code/menuui/mainhallmenu.cpp Diff File
mod - /trunk/fs2_open/code/menuui/playermenu.cpp Diff File
mod - /trunk/fs2_open/code/network/multiui.cpp Diff File
mod - /trunk/fs2_open/code/playerman/player.h Diff File

trunk r7591

2011-08-30 13:40

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V581 The conditional expressions of the 'if' operators situated alongside each other are identical.
mod - /trunk/fs2_open/code/sound/dscap.cpp Diff File

trunk r7590

2011-08-30 13:39

Swifty


Ported: N/A

Details Diff		 Engine glows no longer render when on the wrong side of a warp-in/out.
mod - /trunk/fs2_open/code/model/modelinterp.cpp Diff File

trunk r7589

2011-08-30 13:29

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V576 Incorrect format. A different number of actual arguments is expected while calling 'Format' function. Expected: 2. Present: 3.
mod - /trunk/fs2_open/code/fred2/dumpstats.cpp Diff File

trunk r7588

2011-08-30 13:28

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V567 Undefined behavior. The 'index' variable is modified while being used twice between sequence points.
mod - /trunk/fs2_open/code/fred2/AltShipClassDlg.cpp Diff File

trunk r7587

2011-08-30 13:26

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V547 Expression 'character <= 127' is always true. The value range of signed char type: [-128, 127].
mod - /trunk/fs2_open/code/fred2/missionsave.cpp Diff File
mod - /trunk/fs2_open/code/mission/missionbriefcommon.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File

trunk r7586

2011-08-30 13:24

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V541 It is dangerous to print the string 'base' into itself.
mod - /trunk/fs2_open/code/stats/medals.cpp Diff File

trunk r7585

2011-08-30 13:23

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V541 It is dangerous to print the string 'ani_name' into itself.
mod - /trunk/fs2_open/code/anim/animplay.cpp Diff File

trunk r7584

2011-08-30 11:39

Echelon9


Ported: N/A

Details Diff		 PVS-Studio fix: V576 Incorrect format. Consider checking the [third] actual argument of the 'sprintf' function. The SIGNED integer type argument is expected.

Fixes a number of this class of issue with sprintf formats.
mod - /trunk/fs2_open/code/menuui/barracks.cpp Diff File
mod - /trunk/fs2_open/code/network/multi_pinfo.cpp Diff File
mod - /trunk/fs2_open/code/network/multi_pxo.cpp Diff File
mod - /trunk/fs2_open/code/network/multiui.cpp Diff File
mod - /trunk/fs2_open/code/network/stand_gui.cpp Diff File
mod - /trunk/fs2_open/code/stats/scoring.h Diff File
mod - /trunk/fs2_open/code/stats/stats.cpp Diff File

trunk r7583

2011-08-30 11:17

Echelon9


Ported: N/A

Details Diff		 PVS-Studio fix: V805 Decreased performance. It is inefficient to identify an empty string by using 'strlen(str) == 0' construct. A more efficient way is to check: str[0] == '\0' (missioncampaign.cpp).
mod - /trunk/fs2_open/code/mission/missioncampaign.cpp Diff File

trunk r7582

2011-08-30 10:32

Echelon9


Ported: N/A

Details Diff		 PVS-Studio fix: V523 The 'then' statement is equivalent to the 'else' statement (shipfx.cpp).

Also take opportunity to clean up the BSG warp effect code. That duplice if() else() had been included since the original WMC commit in r5261.
mod - /trunk/fs2_open/code/ship/shipfx.cpp Diff File

trunk r7581

2011-08-30 10:06

Echelon9


Ported: N/A

Details Diff		 PVS-Studio fix: V803 Decreased performance. In case 'aip->wp_index' is iterator it's more effective to use prefix form of decrement. Replace iterator-- with --iterator.
mod - /trunk/fs2_open/code/ai/aicode.cpp Diff File

trunk r7580

2011-08-30 09:55

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V570 The 'end_angle.a1d [axis]' variable is assigned to itself.
mod - /trunk/fs2_open/code/model/modelanim.cpp Diff File

trunk r7579

2011-08-30 09:48

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V547 Expression is always true. Unsigned type value is always >= 0.
mod - /trunk/fs2_open/code/fred2/missionsave.cpp Diff File

trunk r7578

2011-08-30 09:46

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V535 The variable 'i' is being used for this loop and for the outer loop.
mod - /trunk/fs2_open/code/bmpman/bmpman.cpp Diff File

trunk r7577

2011-08-30 09:40

The_E


Ported: N/A

Details Diff		 PVS Studio fix: V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 279, 287.
mod - /trunk/fs2_open/code/fred2/sexp_tree.cpp Diff File
 First  Prev  1 2 3 ... 40 ... 80 ... 120 ... 133 134 135 136 137 138 139 ... 160 ... 200 ... 240 ... 280 ... 320 ... 360 ... 400 ... 437 438 439  Next  Last