View Issue Details

IDProjectCategoryView StatusLast Update
0003133FSSCPgameplaypublic2014-12-07 20:36
ReporterAxem Assigned ToMageKing17  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.7.2 RC4 
Target Version3.7.2Fixed in Version3.7.2 
Summary0003133: dynamic weapon point firing causes a crash when used on a fighter with 6 firing points on a bank
DescriptionSomething to with confusion with 0-based and 1-based indexes when trying to figure out if something's a prime number with factor tables.

I think.

MageKing knows whats really going on.
TagsNo tags attached.

Activities

MageKing17

2014-12-07 20:32

developer   ~0016412

At some point the code should be changed to work for more than 6 slots in a bank, but that can wait until after 3.7.2.

MageKing17

2014-12-07 20:32

developer   ~0016413

Fix committed to trunk@11189.

Related Changesets

fs2open: trunk r11189

2014-12-07 16:21

MageKing17


Ported: N/A

Details Diff
Fix mantis 0003133. Fixes logic errors in factor_table not being sure if it's supposed to be 0-based or 1-based at different times. Affected Issues
0003133
mod - /trunk/fs2_open/code/io/keycontrol.cpp Diff File

Issue History

Date Modified Username Field Change
2014-12-07 20:30 Axem New Issue
2014-12-07 20:32 MageKing17 Note Added: 0016412
2014-12-07 20:32 MageKing17 Assigned To => MageKing17
2014-12-07 20:32 MageKing17 Status new => code review
2014-12-07 20:32 niffiwan Status code review => assigned
2014-12-07 20:32 niffiwan Status assigned => code review
2014-12-07 20:32 MageKing17 Changeset attached => fs2open trunk r11189
2014-12-07 20:32 MageKing17 Note Added: 0016413
2014-12-07 20:32 MageKing17 Status code review => resolved
2014-12-07 20:32 MageKing17 Resolution open => fixed
2014-12-07 20:34 chief1983 Product Version => 3.7.2 RC3
2014-12-07 20:34 chief1983 Fixed in Version => 3.7.2 RC4
2014-12-07 20:34 chief1983 Target Version => 3.7.2
2014-12-07 20:36 chief1983 Product Version 3.7.2 RC3 => 3.7.2 RC4
2014-12-07 20:36 chief1983 Fixed in Version 3.7.2 RC4 => 3.7.2