2018-10-22 04:55 EDT


View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0003109FSSCPHUDpublic2014-09-28 10:36
ReporterYarn 
Assigned ToYarn 
PriorityhighSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
Platformx64OSWindows 7OS Version
Product Version3.7.1 
Target Version3.7.2Fixed in Version 
Summary0003109: Retail head ANIs no longer appearing
DescriptionThe feature added in revision 11079 is causing the retail head ANIs to no longer appear. I think it's caused by an incorrect default, but I haven't played with the code yet because I wanted to report this quickly.
Steps To ReproducePlay any non-training mission from the main campaign and wait for a message. Notice that the head ANI does not appear.
TagsNo tags attached.
Attached Files
  • patch file icon mantis3109.patch (606 bytes) 2014-09-26 22:43 -
    Index: code/mission/missionmessage.h
    ===================================================================
    --- code/mission/missionmessage.h	(revision 11089)
    +++ code/mission/missionmessage.h	(working copy)
    @@ -190,7 +190,7 @@
     
     // function to parse a message from either messages.tbl or the mission file.  Both files have the
     // exact same format, so this function just gets reused in both instances.
    -void	message_parse(bool importing_from_fsm = false, bool builtin = false);
    +void	message_parse(bool importing_from_fsm = false, bool builtin = true);
     void	persona_parse();
     
     void	messages_init();
    
    patch file icon mantis3109.patch (606 bytes) 2014-09-26 22:43 +

-Relationships
related to 0002888resolvedGoober5000 Patch to allow for head .ani files without letters 
+Relationships

-Notes

~0016305

Yarn (developer)

The cause is exactly what I suspected: the builtin parameter of message_parse() is defaulting to false, which means that head ANIs don't appear unless they're specifically enabled in messages.tbl (the opposite of what's supposed to happen). The attached patch makes the builtin parameter default to true.

The reason that this report is not in code review yet is that I noticed that add_message() sets msg.append_suffix to false, and I'm not certain whether it's OK like that (I think it is).

~0016306

chief1983 (administrator)

Yeah I tried to cover my bases on whether it was going to append or not without messing with retail but I didn't have high hopes I got it right the first time. Part of the problem was that I didn't really have good test cases to use for either behavior.

~0016307

chief1983 (administrator)

In missionmessage.cpp, when it calls message_parse at line 594, that is in the parsing of messages.tbl, that's where it does set builtin to true. The one thing I wasn't sure of was if people are setting custom messages to use 'head-' or whatever and those also needed to use the head-a, head-b, etc selection. If that's the case, then that is probably why this broke. It should at least be working for actual built-in messages.

~0016308

Yarn (developer)

Yes, head ANIs are appearing with messages from messages.tbl. The problem only occurs with messages from mission files. If you open the retail missions in a text editor and look at the messages section, you'll see that none of the ANI file names there have letter suffixes. The ANIs that FRED lists also lack the suffixes (which is, at least for retail data, correct behavior).

~0016309

chief1983 (administrator)

Fix committed to trunk@11090.

~0016311

chief1983 (administrator)

Fixed by reverting 11079 until I can come up with a proper fix. Continue discussing about solution, if interested, in the original ticket 0002888.
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2014-09-26 22:29 Yarn New Issue
2014-09-26 22:29 Yarn Relationship added related to 0002888
2014-09-26 22:43 Yarn File Added: mantis3109.patch
2014-09-26 22:43 Yarn Assigned To => Yarn
2014-09-26 22:43 Yarn Status new => assigned
2014-09-26 22:50 Yarn Note Added: 0016305
2014-09-27 10:35 chief1983 Note Added: 0016306
2014-09-27 10:40 chief1983 Note Added: 0016307
2014-09-27 13:32 Yarn Note Added: 0016308
2014-09-28 10:29 chief1983 Changeset attached => fs2open trunk r11090
2014-09-28 10:29 chief1983 Note Added: 0016309
2014-09-28 10:29 chief1983 Status assigned => resolved
2014-09-28 10:29 chief1983 Resolution open => fixed
2014-09-28 10:36 chief1983 Note Added: 0016311
+Issue History