|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002804||FSSCP||beams||public||2013-03-05 21:10||2014-09-26 22:20|
|Target Version||Fixed in Version|
|Summary||0002804: Beam damage is unaffected by Armor/Shield/Subsystem factor|
|Description||As it says on the tin, a (player ship fighter, I haven't actually confirmed if this is also the case for turreted weapons, but I *assume* it is.) beam weapon will always deal its full 1x damage to anything it hits. It completely ignores any of the $Armor Factor and such. |
I'd love it if beams would be affected by the Factors so we can get a bit more creative with beams. And to avoid breaking any backwards compatibility or whatnot, make it a game_settings.tbl flag.
|Tags||No tags attached.|
Woolie Wool (reporter)
Last edited: 2013-03-06 20:11
Fighter beams do not appear to respect difficulty level scaling either (despite the fix of 2788).
EDIT: Subsystem damage appears to scale with difficulty, but not hull damage.
Last edited: 2014-08-25 18:52
I've created a patch, see attached and on github:
This adds a new game_settings.tbl option:
$Beams Use Armor/Shield/Subsystem Factors:
(let me know if you have any betters suggestions for the name).
I've also attached a small mod that I was using to test the changes. This should test all three types of weapon factors on "normal" beams and fighter beams. Normal beams are weak vs their target (i.e. see the relevant cruisers name) and the fighter beams are stronger vs one factor (the opposite of the normal beams). Using beams vs the friendlies should test difficulty level scaling.
The code also has a new debug_filter.cfg option: +Damage to more easily let you see exactly what damage a given ship is taking.
Unfortunately my Windows laptop is refusing to build execs at the moment :( I'm hoping I can build & post them tomorrow with a different machine.
Execs are ready for testing:
|Super neat, Niffiwan! I'll make some time to test this good and proper some time during this week and then cast feedback like a protoss high templar.|
Niffi is a derp :(
Here are some *real* execs for testing with (not redundant trunk execs...)
As per the suggestion, I will also change (before committing) the game_settings.tbl flag to be:
$Beams Use Damage Factors:
|Okay so I have tested this quite a bit now and haven't spotted any errors, bugs or other nasty bits. As far as I can see, this new flag works greato for both player and capship mounted beams~|
New patch uploaded with the option name changed to "$Beams Use Damage Factors:". I also removed the nprintf statements, I'll add them in separately when I've spruced them up a bit.
The patch itself is quite simple, I suppose the most important thing to review would be to ensure I didn't miss any places where the factors should apply.
|Fix committed to trunk@11089.|
fs2open: trunk r11089
Timestamp: 2014-09-26 22:56:53
|Fix mantis 2804: beams can use damage factors
Add game_setting.tbl option that allows beams to use weapons table
Armor/Shield/Subsystem damage factors
|mod - /trunk/fs2_open/code/ship/shiphit.cpp|
|mod - /trunk/fs2_open/code/mod_table/mod_table.cpp|
|mod - /trunk/fs2_open/code/mod_table/mod_table.h|
|2013-03-05 21:10||Spoon||New Issue|
|2013-03-06 20:04||Woolie Wool||Note Added: 0014755|
|2013-03-06 20:11||Woolie Wool||Note Edited: 0014755||View Revisions|
|2014-08-23 19:02||niffiwan||Assigned To||=> niffiwan|
|2014-08-23 19:02||niffiwan||Status||new => assigned|
|2014-08-25 06:49||niffiwan||File Added: mantis2804.patch|
|2014-08-25 06:49||niffiwan||File Added: mantis2804-mod.7z|
|2014-08-25 06:57||niffiwan||Note Added: 0016256|
|2014-08-25 06:57||niffiwan||Note Edited: 0016256||View Revisions|
|2014-08-25 18:52||niffiwan||Note Edited: 0016256||View Revisions|
|2014-08-25 18:52||niffiwan||Status||assigned => feedback|
|2014-08-25 20:38||Spoon||Note Added: 0016258|
|2014-08-25 20:38||Spoon||Status||feedback => assigned|
|2014-08-28 22:17||niffiwan||Note Added: 0016263|
|2014-09-07 18:26||Spoon||Note Added: 0016272|
|2014-09-11 06:17||niffiwan||File Added: mantis2804-2.patch|
|2014-09-11 06:23||niffiwan||Note Added: 0016275|
|2014-09-11 06:23||niffiwan||Status||assigned => code review|
|2014-09-26 22:20||niffiwan||Changeset attached||=> fs2open trunk r11089|
|2014-09-26 22:20||niffiwan||Note Added: 0016304|
|2014-09-26 22:20||niffiwan||Status||code review => resolved|
|2014-09-26 22:20||niffiwan||Resolution||open => fixed|